Skip to content

Fix issue where flexGrow change was ignored - #945

Merged
nickmurray47 merged 1 commit into
masterfrom
jules-fixChatResultsFlexStyle
Dec 14, 2020
Merged

nickmurray47 merged 1 commit into
masterfrom
jules-fixChatResultsFlexStyle

Conversation

@Julesssss

Copy link
Copy Markdown
Contributor

Fixes issue where chat switcher search results would not display. Mobile apps did not like the use of both flex and flexBox.

Fixed Issues

Fixes https://github.com/Expensify/Expensify/issues/148241

Tests

  • Open LHN
  • Tap the chat switcher to gain focus
  • Enter some text
  • Results should appear
  • Tap the x button to loose focus
  • Tap the chat switcher again to gain focus
  • Enter some text
  • Results should appear

Screenshots

N/A

@Julesssss
Julesssss requested review from a team and shawnborton December 14, 2020 19:01
@Julesssss Julesssss self-assigned this Dec 14, 2020
@botify
botify removed the request for review from a team December 14, 2020 19:01
@github-actions

github-actions Bot commented Dec 14, 2020 •

Copy link
Copy Markdown
Contributor

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@botify
botify requested a review from nickmurray47 December 14, 2020 19:01
@shawnborton

Copy link
Copy Markdown
Contributor

Tested and works great on web and iOS. I don't have Android studio set up locally, can you confirm it is working there too?

Otherwise all you @nickmurray47

@Julesssss

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@Julesssss

Copy link
Copy Markdown
Contributor Author

recheck

@Julesssss

Copy link
Copy Markdown
Contributor Author

Thanks @shawnborton. I verified this fix on an Android device 👍

@Julesssss

Copy link
Copy Markdown
Contributor Author

Tests are passing. I'm heading out now 👋

@nickmurray47 nickmurray47 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nickmurray47
nickmurray47 merged commit 179a549 into master Dec 14, 2020
@nickmurray47
nickmurray47 deleted the jules-fixChatResultsFlexStyle branch December 14, 2020 20:28
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants