Repository navigation
Collect legal entity tax ID before enabling Travel on non-USD workspaces - #94604
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@arosiclair Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b789210ddf
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
JmillsExpensify
left a comment
There was a problem hiding this comment.
No product concerns on this one.
# Conflicts: # src/pages/Travel/VerifyAccountPage.tsx
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index c6bf3e7b136..5968eb14681 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -1,13 +1,3 @@
-import type {OnboardingTask} from '@libs/actions/Welcome/OnboardingFlow';
-import StringUtils from '@libs/StringUtils';
-
-import CONST from '@src/CONST';
-import type {Country} from '@src/CONST';
-import type OriginalMessage from '@src/types/onyx/OriginalMessage';
-import type {OriginalMessageSettlementAccountLocked, PersonalRulesModifiedFields, PolicyRulesModifiedFields} from '@src/types/onyx/OriginalMessage';
-
-import type {ValueOf} from 'type-fest';
-
/**
* _____ __ __
* / ___/__ ___ ___ _______ _/ /____ ___/ /
@@ -19,6 +9,16 @@ import type {ValueOf} from 'type-fest';
* - Improve the prompts in prompts/translation, or
* - Improve context annotations in src/languages/en.ts
*/
+import type {OnboardingTask} from '@libs/actions/Welcome/OnboardingFlow';
+import StringUtils from '@libs/StringUtils';
+
+import CONST from '@src/CONST';
+import type {Country} from '@src/CONST';
+import type OriginalMessage from '@src/types/onyx/OriginalMessage';
+import type {OriginalMessageSettlementAccountLocked, PersonalRulesModifiedFields, PolicyRulesModifiedFields} from '@src/types/onyx/OriginalMessage';
+
+import type {ValueOf} from 'type-fest';
+
import {CONST as COMMON_CONST, Str} from 'expensify-common';
import startCase from 'lodash/startCase';
@@ -63,7 +63,6 @@ import type {
YourPlanPriceParams,
} from './params';
import type {TranslationDeepObject} from './types';
-
type StateValue = {
stateISO: string;
stateName: string;
@@ -4403,9 +4402,9 @@ ${amount} für ${merchant} – ${date}`,
nightsIn: 'Nächte in',
taxID: {
title: 'Steuer-ID',
- subtitle: 'Geben Sie die Steuer-ID Ihrer juristischen Person ein, damit wir die Reisekostenabrechnung in Ihrer Landeswährung einrichten können.',
+ subtitle: 'Geben Sie Ihre Steuer-ID der juristischen Person ein, damit wir die Reiseabrechnung in Ihrer lokalen Währung einrichten können.',
inputLabel: 'Steuer-ID der juristischen Person',
- error: {required: 'Bitte geben Sie die Steuernummer Ihrer juristischen Person ein.'},
+ error: {required: 'Bitte geben Sie Ihre steuerliche Identifikationsnummer der juristischen Person ein.'},
},
},
workspace: {
diff --git a/src/languages/es.ts b/src/languages/es.ts
index bdbf3f63a72..a91c43dfb2a 100644
--- a/src/languages/es.ts
+++ b/src/languages/es.ts
@@ -1,6 +1,3 @@
-import CONST from '@src/CONST';
-import type {OriginalMessageSettlementAccountLocked, PersonalRulesModifiedFields, PolicyRulesModifiedFields} from '@src/types/onyx/OriginalMessage';
-
/**
* _____ __ __
* / ___/__ ___ ___ _______ _/ /____ ___/ /
@@ -12,12 +9,14 @@ import type {OriginalMessageSettlementAccountLocked, PersonalRulesModifiedFields
* - Improve the prompts in prompts/translation, or
* - Improve context annotations in src/languages/en.ts
*/
+import CONST from '@src/CONST';
+import type {OriginalMessageSettlementAccountLocked, PersonalRulesModifiedFields, PolicyRulesModifiedFields} from '@src/types/onyx/OriginalMessage';
+
import {CONST as COMMON_CONST, Str} from 'expensify-common';
import type en from './en';
import type {ConciergeBrokenCardConnectionParams, PaidElsewhereParams, RemoveCopilotAccessConfirmationParams, UnsupportedFormulaValueErrorParams} from './params';
import type {TranslationDeepObject} from './types';
-
const translations: TranslationDeepObject<typeof en> = {
common: {
count: 'Contar',
@@ -4218,7 +4217,7 @@ ${amount} para ${merchant} - ${date}`,
title: 'ID fiscal',
subtitle: 'Introduce el NIF de tu entidad legal para que podamos configurar la facturación de viajes en tu moneda local.',
inputLabel: 'ID fiscal de la entidad jurídica',
- error: {required: 'Introduce el NIF fiscal de tu entidad legal.'},
+ error: {required: 'Por favor, introduce el NIF fiscal de tu entidad legal.'},
},
domainPermissionInfo: {
title: 'Dominio',
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index a8f70a0fab7..d6d05b8a1b1 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -1,13 +1,3 @@
-import type {OnboardingTask} from '@libs/actions/Welcome/OnboardingFlow';
-import StringUtils from '@libs/StringUtils';
-
-import CONST from '@src/CONST';
-import type {Country} from '@src/CONST';
-import type OriginalMessage from '@src/types/onyx/OriginalMessage';
-import type {OriginalMessageSettlementAccountLocked, PersonalRulesModifiedFields, PolicyRulesModifiedFields} from '@src/types/onyx/OriginalMessage';
-
-import type {ValueOf} from 'type-fest';
-
/**
* _____ __ __
* / ___/__ ___ ___ _______ _/ /____ ___/ /
@@ -19,6 +9,16 @@ import type {ValueOf} from 'type-fest';
* - Improve the prompts in prompts/translation, or
* - Improve context annotations in src/languages/en.ts
*/
+import type {OnboardingTask} from '@libs/actions/Welcome/OnboardingFlow';
+import StringUtils from '@libs/StringUtils';
+
+import CONST from '@src/CONST';
+import type {Country} from '@src/CONST';
+import type OriginalMessage from '@src/types/onyx/OriginalMessage';
+import type {OriginalMessageSettlementAccountLocked, PersonalRulesModifiedFields, PolicyRulesModifiedFields} from '@src/types/onyx/OriginalMessage';
+
+import type {ValueOf} from 'type-fest';
+
import {CONST as COMMON_CONST, Str} from 'expensify-common';
import startCase from 'lodash/startCase';
@@ -63,7 +63,6 @@ import type {
YourPlanPriceParams,
} from './params';
import type {TranslationDeepObject} from './types';
-
type StateValue = {
stateISO: string;
stateName: string;
@@ -4415,8 +4414,8 @@ ${amount} pour ${merchant} - ${date}`,
taxID: {
title: 'Identifiant fiscal',
subtitle: 'Saisissez l’identifiant fiscal de votre entité légale afin que nous puissions configurer la facturation des déplacements dans votre devise locale.',
- inputLabel: 'Identifiant fiscal de l’entité juridique',
- error: {required: 'Veuillez saisir l’identifiant fiscal de votre entité légale.'},
+ inputLabel: 'Identifiant fiscal de la personne morale',
+ error: {required: 'Veuillez saisir le numéro d’identification fiscale de votre entité légale.'},
},
},
workspace: {
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 6a6aa0b05dc..3b23dc0b6d7 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -1,13 +1,3 @@
-import type {OnboardingTask} from '@libs/actions/Welcome/OnboardingFlow';
-import StringUtils from '@libs/StringUtils';
-
-import CONST from '@src/CONST';
-import type {Country} from '@src/CONST';
-import type OriginalMessage from '@src/types/onyx/OriginalMessage';
-import type {OriginalMessageSettlementAccountLocked, PersonalRulesModifiedFields, PolicyRulesModifiedFields} from '@src/types/onyx/OriginalMessage';
-
-import type {ValueOf} from 'type-fest';
-
/**
* _____ __ __
* / ___/__ ___ ___ _______ _/ /____ ___/ /
@@ -19,6 +9,16 @@ import type {ValueOf} from 'type-fest';
* - Improve the prompts in prompts/translation, or
* - Improve context annotations in src/languages/en.ts
*/
+import type {OnboardingTask} from '@libs/actions/Welcome/OnboardingFlow';
+import StringUtils from '@libs/StringUtils';
+
+import CONST from '@src/CONST';
+import type {Country} from '@src/CONST';
+import type OriginalMessage from '@src/types/onyx/OriginalMessage';
+import type {OriginalMessageSettlementAccountLocked, PersonalRulesModifiedFields, PolicyRulesModifiedFields} from '@src/types/onyx/OriginalMessage';
+
+import type {ValueOf} from 'type-fest';
+
import {CONST as COMMON_CONST, Str} from 'expensify-common';
import startCase from 'lodash/startCase';
@@ -63,7 +63,6 @@ import type {
YourPlanPriceParams,
} from './params';
import type {TranslationDeepObject} from './types';
-
type StateValue = {
stateISO: string;
stateName: string;
@@ -4390,8 +4389,8 @@ ${amount} per ${merchant} - ${date}`,
taxID: {
title: 'Codice fiscale',
subtitle: 'Inserisci il codice fiscale della tua entità legale così possiamo configurare la fatturazione dei viaggi nella tua valuta locale.',
- inputLabel: 'Partita IVA dell’entità legale',
- error: {required: 'Inserisci il codice fiscale/partita IVA della tua entità legale.'},
+ inputLabel: 'Codice fiscale dell’entità legale',
+ error: {required: 'Inserisci il codice fiscale o la partita IVA della tua entità legale.'},
},
},
workspace: {
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 5a231759b92..df82e6835d3 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -1,13 +1,3 @@
-import type {OnboardingTask} from '@libs/actions/Welcome/OnboardingFlow';
-import StringUtils from '@libs/StringUtils';
-
-import CONST from '@src/CONST';
-import type {Country} from '@src/CONST';
-import type OriginalMessage from '@src/types/onyx/OriginalMessage';
-import type {OriginalMessageSettlementAccountLocked, PersonalRulesModifiedFields, PolicyRulesModifiedFields} from '@src/types/onyx/OriginalMessage';
-
-import type {ValueOf} from 'type-fest';
-
/**
* _____ __ __
* / ___/__ ___ ___ _______ _/ /____ ___/ /
@@ -19,6 +9,16 @@ import type {ValueOf} from 'type-fest';
* - Improve the prompts in prompts/translation, or
* - Improve context annotations in src/languages/en.ts
*/
+import type {OnboardingTask} from '@libs/actions/Welcome/OnboardingFlow';
+import StringUtils from '@libs/StringUtils';
+
+import CONST from '@src/CONST';
+import type {Country} from '@src/CONST';
+import type OriginalMessage from '@src/types/onyx/OriginalMessage';
+import type {OriginalMessageSettlementAccountLocked, PersonalRulesModifiedFields, PolicyRulesModifiedFields} from '@src/types/onyx/OriginalMessage';
+
+import type {ValueOf} from 'type-fest';
+
import {CONST as COMMON_CONST, Str} from 'expensify-common';
import startCase from 'lodash/startCase';
@@ -63,7 +63,6 @@ import type {
YourPlanPriceParams,
} from './params';
import type {TranslationDeepObject} from './types';
-
type StateValue = {
stateISO: string;
stateName: string;
@@ -4353,9 +4352,9 @@ ${integrationName === CONST.ONBOARDING_ACCOUNTING_MAPPING.other ? 'あなたの'
nightsIn: '泊(滞在先)',
taxID: {
title: '納税者番号',
- subtitle: '現地通貨での出張費の請求を設定できるように、法人の納税者番号を入力してください。',
+ subtitle: '現地通貨での出張請求を設定できるように、法人の納税者番号(税務登録番号)を入力してください。',
inputLabel: '法人納税者番号',
- error: {required: '法的事業体の納税者番号を入力してください。'},
+ error: {required: '法人の正式な納税者番号を入力してください。'},
},
},
workspace: {
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 4a768179f14..9014d379818 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -1,13 +1,3 @@
-import type {OnboardingTask} from '@libs/actions/Welcome/OnboardingFlow';
-import StringUtils from '@libs/StringUtils';
-
-import CONST from '@src/CONST';
-import type {Country} from '@src/CONST';
-import type OriginalMessage from '@src/types/onyx/OriginalMessage';
-import type {OriginalMessageSettlementAccountLocked, PersonalRulesModifiedFields, PolicyRulesModifiedFields} from '@src/types/onyx/OriginalMessage';
-
-import type {ValueOf} from 'type-fest';
-
/**
* _____ __ __
* / ___/__ ___ ___ _______ _/ /____ ___/ /
@@ -19,6 +9,16 @@ import type {ValueOf} from 'type-fest';
* - Improve the prompts in prompts/translation, or
* - Improve context annotations in src/languages/en.ts
*/
+import type {OnboardingTask} from '@libs/actions/Welcome/OnboardingFlow';
+import StringUtils from '@libs/StringUtils';
+
+import CONST from '@src/CONST';
+import type {Country} from '@src/CONST';
+import type OriginalMessage from '@src/types/onyx/OriginalMessage';
+import type {OriginalMessageSettlementAccountLocked, PersonalRulesModifiedFields, PolicyRulesModifiedFields} from '@src/types/onyx/OriginalMessage';
+
+import type {ValueOf} from 'type-fest';
+
import {CONST as COMMON_CONST, Str} from 'expensify-common';
import startCase from 'lodash/startCase';
@@ -63,7 +63,6 @@ import type {
YourPlanPriceParams,
} from './params';
import type {TranslationDeepObject} from './types';
-
type StateValue = {
stateISO: string;
stateName: string;
@@ -4384,9 +4383,9 @@ ${amount} voor ${merchant} - ${date}`,
nightsIn: 'nachten in',
taxID: {
title: 'Belastingnummer',
- subtitle: 'Voer het fiscale nummer van je rechtspersoon in zodat we reisfacturatie in je lokale valuta kunnen instellen.',
- inputLabel: 'Belastingnummer rechtspersoon',
- error: {required: 'Vul het fiscale identificatienummer van je rechtspersoon in.'},
+ subtitle: 'Voer het fiscale identificatienummer van je rechtspersoon in, zodat we reiskosten in je lokale valuta kunnen inrichten.',
+ inputLabel: 'RSIN / fiscaal nummer',
+ error: {required: 'Voer het fiscale nummer van je rechtspersoon in.'},
},
},
workspace: {
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 3755dad0426..5c8a5770ab0 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -1,13 +1,3 @@
-import type {OnboardingTask} from '@libs/actions/Welcome/OnboardingFlow';
-import StringUtils from '@libs/StringUtils';
-
-import CONST from '@src/CONST';
-import type {Country} from '@src/CONST';
-import type OriginalMessage from '@src/types/onyx/OriginalMessage';
-import type {OriginalMessageSettlementAccountLocked, PersonalRulesModifiedFields, PolicyRulesModifiedFields} from '@src/types/onyx/OriginalMessage';
-
-import type {ValueOf} from 'type-fest';
-
/**
* _____ __ __
* / ___/__ ___ ___ _______ _/ /____ ___/ /
@@ -19,6 +9,16 @@ import type {ValueOf} from 'type-fest';
* - Improve the prompts in prompts/translation, or
* - Improve context annotations in src/languages/en.ts
*/
+import type {OnboardingTask} from '@libs/actions/Welcome/OnboardingFlow';
+import StringUtils from '@libs/StringUtils';
+
+import CONST from '@src/CONST';
+import type {Country} from '@src/CONST';
+import type OriginalMessage from '@src/types/onyx/OriginalMessage';
+import type {OriginalMessageSettlementAccountLocked, PersonalRulesModifiedFields, PolicyRulesModifiedFields} from '@src/types/onyx/OriginalMessage';
+
+import type {ValueOf} from 'type-fest';
+
import {CONST as COMMON_CONST, Str} from 'expensify-common';
import startCase from 'lodash/startCase';
@@ -63,7 +63,6 @@ import type {
YourPlanPriceParams,
} from './params';
import type {TranslationDeepObject} from './types';
-
type StateValue = {
stateISO: string;
stateName: string;
@@ -4370,9 +4369,9 @@ ${amount} dla ${merchant} - ${date}`,
nightsIn: 'noce w',
taxID: {
title: 'NIP',
- subtitle: 'Podaj swój numer identyfikacji podatkowej podmiotu prawnego, żebyśmy mogli skonfigurować rozliczenia za podróże w twojej lokalnej walucie.',
+ subtitle: 'Wpisz swój identyfikator podatkowy podmiotu prawnego, żebyśmy mogli skonfigurować rozliczenia za podróże w twojej lokalnej walucie.',
inputLabel: 'NIP podmiotu prawnego',
- error: {required: 'Podaj swój identyfikator podatkowy podmiotu prawnego.'},
+ error: {required: 'Podaj swój podatkowy identyfikator prawnego podmiotu.'},
},
},
workspace: {
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 7e432643bc3..766a7e193c6 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -1,13 +1,3 @@
-import type {OnboardingTask} from '@libs/actions/Welcome/OnboardingFlow';
-import StringUtils from '@libs/StringUtils';
-
-import CONST from '@src/CONST';
-import type {Country} from '@src/CONST';
-import type OriginalMessage from '@src/types/onyx/OriginalMessage';
-import type {OriginalMessageSettlementAccountLocked, PersonalRulesModifiedFields, PolicyRulesModifiedFields} from '@src/types/onyx/OriginalMessage';
-
-import type {ValueOf} from 'type-fest';
-
/**
* _____ __ __
* / ___/__ ___ ___ _______ _/ /____ ___/ /
@@ -19,6 +9,16 @@ import type {ValueOf} from 'type-fest';
* - Improve the prompts in prompts/translation, or
* - Improve context annotations in src/languages/en.ts
*/
+import type {OnboardingTask} from '@libs/actions/Welcome/OnboardingFlow';
+import StringUtils from '@libs/StringUtils';
+
+import CONST from '@src/CONST';
+import type {Country} from '@src/CONST';
+import type OriginalMessage from '@src/types/onyx/OriginalMessage';
+import type {OriginalMessageSettlementAccountLocked, PersonalRulesModifiedFields, PolicyRulesModifiedFields} from '@src/types/onyx/OriginalMessage';
+
+import type {ValueOf} from 'type-fest';
+
import {CONST as COMMON_CONST, Str} from 'expensify-common';
import startCase from 'lodash/startCase';
@@ -63,7 +63,6 @@ import type {
YourPlanPriceParams,
} from './params';
import type {TranslationDeepObject} from './types';
-
type StateValue = {
stateISO: string;
stateName: string;
@@ -4374,9 +4373,9 @@ ${amount} para ${merchant} - ${date}`,
nightsIn: 'noites em',
taxID: {
title: 'CPF/CNPJ',
- subtitle: 'Insira o CNPJ da sua empresa para que possamos configurar a cobrança de viagens na sua moeda local.',
- inputLabel: 'CNPJ da pessoa jurídica',
- error: {required: 'Insira o CNPJ da sua entidade legal.'},
+ subtitle: 'Insira o CNPJ da sua pessoa jurídica para que possamos configurar a cobrança de viagens na sua moeda local.',
+ inputLabel: 'CNPJ da empresa',
+ error: {required: 'Insira o CNPJ da sua empresa.'},
},
},
workspace: {
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 1072db87d27..56765a7622e 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -1,13 +1,3 @@
-import type {OnboardingTask} from '@libs/actions/Welcome/OnboardingFlow';
-import StringUtils from '@libs/StringUtils';
-
-import CONST from '@src/CONST';
-import type {Country} from '@src/CONST';
-import type OriginalMessage from '@src/types/onyx/OriginalMessage';
-import type {OriginalMessageSettlementAccountLocked, PersonalRulesModifiedFields, PolicyRulesModifiedFields} from '@src/types/onyx/OriginalMessage';
-
-import type {ValueOf} from 'type-fest';
-
/**
* _____ __ __
* / ___/__ ___ ___ _______ _/ /____ ___/ /
@@ -19,6 +9,16 @@ import type {ValueOf} from 'type-fest';
* - Improve the prompts in prompts/translation, or
* - Improve context annotations in src/languages/en.ts
*/
+import type {OnboardingTask} from '@libs/actions/Welcome/OnboardingFlow';
+import StringUtils from '@libs/StringUtils';
+
+import CONST from '@src/CONST';
+import type {Country} from '@src/CONST';
+import type OriginalMessage from '@src/types/onyx/OriginalMessage';
+import type {OriginalMessageSettlementAccountLocked, PersonalRulesModifiedFields, PolicyRulesModifiedFields} from '@src/types/onyx/OriginalMessage';
+
+import type {ValueOf} from 'type-fest';
+
import {CONST as COMMON_CONST, Str} from 'expensify-common';
import startCase from 'lodash/startCase';
@@ -63,7 +63,6 @@ import type {
YourPlanPriceParams,
} from './params';
import type {TranslationDeepObject} from './types';
-
type StateValue = {
stateISO: string;
stateName: string;
@@ -4265,7 +4264,7 @@ ${amount},商户:${merchant} - 日期:${date}`,
carRental: '租车',
nightIn: '夜宿',
nightsIn: '入住晚数',
- taxID: {title: '税号', subtitle: '请输入您法人的税号,以便我们以本地货币为您设置差旅结算。', inputLabel: '法人税号', error: {required: '请输入您的法人税号。'}},
+ taxID: {title: '税号', subtitle: '请输入您法人的纳税识别号,以便我们以您的本地货币设置差旅账单。', inputLabel: '法律实体税号', error: {required: '请输入您的法人税号。'}},
},
workspace: {
common: {
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
🚧 rlinoz has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/rlinoz in version: 9.4.32-0 🚀
|
|
📝 Help site review — changes required This PR adds a Tax ID page to the Expensify Travel enablement flow: non-USD workspaces that aren't yet provisioned are now asked for their Legal entity tax ID before accepting the travel terms. That's a customer-facing step an admin will hit, so the help site should explain it. What I found: The existing article Enable Expensify Travel on a workspace documents the enablement flow but doesn't mention the new Tax ID step. No other travel article covers it. What I did: Added one FAQ entry to that article explaining when/why the Tax ID page appears and that it's skipped for USD and already-provisioned workspaces. UI labels (Tax ID, Legal entity tax ID, Continue) were verified against the strings in this PR. Draft help site PR: #95685 (labeled @blimpich, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
@rlinoz @stitesExpensify @blimpich Can you please explain Step 3 (d) and step 4( already-provisioned non-USD workspace). |
|
I dont think you will be able to test 3d, for 4 I think
|
|
Will check with testers if they have a non USD that already has travel enabled. Will be a hard one. |
|
🚀 Deployed to production by https://github.com/grgia in version: 9.4.32-3 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
When an admin enables Expensify Travel on a workspace that bills in a non-USD currency, our travel partner (Solutions) needs the legal entity's tax ID to provision a DK number. Today we never ask for it, so the workspace is silently billed in USD and an account manager has to chase the customer for the number by hand.
This adds a step to the Travel enablement flow: right before accepting the Spotnana terms, a non-USD workspace that hasn't been provisioned yet is asked for its legal entity tax ID. The value is carried into terms acceptance and stored on the workspace's travel settings so it can be sent to Solutions automatically. USD workspaces and already-provisioned workspaces are unaffected — they go straight to the terms page as before.
This is the App half of the feature. The Auth and Web-Expensify PRs below persist the tax ID and forward it to Solutions.
💡 Note: we decided here that this flow will become a dynamic stepper. This PR does not make that happen. That will be in a follow up PR. This is so this PR doesn't get any bigger than it needs to be.
Fixed Issues
Part of https://github.com/Expensify/Expensify/issues/649813
Depends on (must deploy first):
PROPOSAL: N/A
Tests
Prerequisite: a Collect/Control workspace you admin, set to a non-USD output currency (e.g. GBP), with Travel not yet enabled/provisioned, on a private (non-public) email domain.
All paths into terms acceptance are gated. For a non-USD, unprovisioned workspace, verify the Tax ID page appears before terms in each:
8. Single admin domain, account already validated, workspace address already set → Book travel → Tax ID page → terms.
9. Single admin domain, workspace address NOT set → Book travel → company address page → Tax ID page → terms.
10. Account not yet validated → Book travel → verify-account (magic code) → Tax ID page → terms.
11. Multiple admin domains → Book travel → domain selector → Tax ID page → terms.
Offline tests
The Tax ID page works offline: the value is held locally and submitted with the terms-acceptance request once back online.
QA Steps
Run on staging (https://staging.new.expensify.com) with a non-USD Collect/Control workspace you admin that has not yet enabled Travel.
Screenshots/Videos
Screen.Recording.2026-06-25.at.10.30.41.AM.mov
– written by Claude on Ben's behalf