Repository navigation
Make single-select filter rows use compact 52px row height to match multi-select - #94876
Conversation
…tch multi-select Co-authored-by: Shawn Borton <shawnborton@users.noreply.github.com>
|
🚧 shawnborton has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@sobitneupane can you help with screenshots and author/reviewer checklist please? Since this is a Melvin PR. Thanks! |
| contentContainerStyle: [styles.pb0], | ||
| ...selectionListStyle, | ||
| listItemWrapperStyle: [itemHeight !== undefined && {minHeight: itemHeight}, selectionListStyle?.listItemWrapperStyle], | ||
| listItemWrapperStyle: [{minHeight: itemHeight ?? variables.optionRowHeightCompact}, selectionListStyle?.listItemWrapperStyle], |
There was a problem hiding this comment.
❌ UI-3 (docs)
This line passes an inline object literal {minHeight: itemHeight ?? variables.optionRowHeightCompact} into the listItemWrapperStyle style array. Inline style objects create a new object every render (breaking memoization) and bypass the shared style system. A dedicated StyleUtils helper already exists for exactly this case (getMinimumHeight(minHeight: number) in src/styles/utils/index.ts), and it's already used elsewhere in this same FilterComponents directory (e.g. AmountFilterContent.tsx).
Replace the inline object with the helper:
const StyleUtils = useStyleUtils();
// ...
listItemWrapperStyle: [StyleUtils.getMinimumHeight(itemHeight ?? variables.optionRowHeightCompact), selectionListStyle?.listItemWrapperStyle],Reviewed at: 5bacb5c | Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.
|
Friendly bump |
|
reviewing it now |
|
@shawnborton There are still some rows using a 64px height.
|
|
@MelvinBot Please complete the PR author checklist. |
|
I've completed the PR Author Checklist in the description above. Since I'm the automated author, here's what I could and couldn't attest to: Completed (code-verifiable):
Left unchecked — require a human co-author to run on-device:
On the rows still at 64px you flagged (
If the intent of the linked issue is that those should also be compact, that's a broader change than this PR (and the avatar filters especially may need a separate design decision) — happy to scope that separately if you'd like. |
|
The only failing check is PR Author Checklist / checklist — and it's failing because the checklist itself is incomplete, not because of any code, lint, or test problem:
All actual code checks are green (ESLint, TypeScript, Prettier, Jest, Storybook, build, perf, etc.). There's no code fix to push here. The remaining boxes are human testing/verification attestations — e.g. ran on all platforms (Android/iOS native + mWeb, MacOS), added screenshots/videos, verified no console errors, tested offline. I won't tick those on your behalf since they're things a person needs to actually confirm. To clear the check: complete the remaining items in the PR Author Checklist section (add the platform screenshots + check the boxes you've verified). The check re-runs automatically on the next push/edit. |
|
@MelvinBot can you also implement this for more lists in filters like Amount, Purchase Amount, Total? Basically any list item that is just a label and a check selector. Do not do this for rows that have an avatar like bank or card. |
Co-authored-by: Shawn Borton <shawnborton@users.noreply.github.com>
|
Done — pushed What changed:
Left at 64px on purpose (avatar-bearing, per your instruction): Not touched — out of scope, flag me if you want them too:
Checks run locally
Platform screenshots + on-device verification still need a human, same as the rest of this PR. |
|
@stitesExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
🚧 shawnborton has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
Great, that feels better now. Let's continue with final review please. |
|
@shawnborton Even the height of bank account is reduced to 52px.
|
|
Can you show me what it looks like currently on prod? I don't seem to have that filter. |
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-07-02.at.15.07.03.movAndroid: mWeb ChromeScreen.Recording.2026-07-02.at.15.08.13.moviOS: HybridAppScreen.Recording.2026-07-02.at.15.15.40.moviOS: mWeb SafariScreen.Recording.2026-07-02.at.15.17.00.mov |
|
Nice, let's send it then! |
This comment was marked as resolved.
This comment was marked as resolved.
|
@MelvinBot Could you please complete the PR Author checklist, I have verified that all the items can be checked. |
|
@MelvinBot Could you please update Tests and QA steps with the following:
|
|
🤖 Done — I've completed the PR Author Checklist in the PR description, checking all items based on your verification that they can be checked. All checklist boxes (including the per-section "no JS console errors" items) are now checked. Thanks |
|
🤖 Done — I've updated both the Tests and QA Steps sections in the PR description with the flow you provided:
Thanks |
sobitneupane
left a comment
There was a problem hiding this comment.
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Testssection - I verified the steps for Staging and/or Production testing are in the
QA stepssection - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
- I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
toggleReportand notonIconClick). - I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar, I verified the components usingAvatarhave been tested & I retested again) - If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a
/** comment above it */ - The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to
thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor) - Any internal methods bound to
thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick) - All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
- If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
- If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added
Designlabel and/or tagged@Expensify/designso the design team can review the changes.
- For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
- If the
mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
Screenshots/Videos
Android: HybridApp
Screen.Recording.2026-07-02.at.15.07.03.mov
Android: mWeb Chrome
Screen.Recording.2026-07-02.at.15.08.13.mov
iOS: HybridApp
Screen.Recording.2026-07-02.at.15.15.40.mov
iOS: mWeb Safari
Screen.Recording.2026-07-02.at.15.17.00.mov
|
🚧 stitesExpensify has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/stitesExpensify in version: 9.4.32-0 🚀
|
|
🤖 Help site review: no changes required I reviewed the changes in this PR against Expensify's help site content under This is a UI-only styling change: it makes single-select filter rows in Spend > Filters (e.g. Withdrawal type) render at the compact 52px row height so they match the multi-select filter rows (e.g. Withdrawal status). The diff only touches Help site articles document what features do and how to use them, not the pixel-level row height of list items. Since nothing user-facing that the docs describe has changed, no updates to the help site are needed and no draft docs PR was created. I applied @shawnborton, there's no linked help site PR to review here since this purely visual row-height change doesn't affect any documented help site content. If you believe a specific article should be updated anyway, let me know which one and I'll draft it. |
|
🚀 Deployed to production by https://github.com/grgia in version: 9.4.32-3 🚀
Bundle Size Analysis (Sentry): |








Explanation of Change
In Spend > Filters, single-select filter rows (e.g. Withdrawal type) rendered 64px tall while multi-select filter rows (e.g. Withdrawal status) rendered 52px tall, so the two filter types looked inconsistent.
The generic single-select search-filter component defaulted its row height to
variables.optionRowHeight(64) and only applied aminHeightoverride on the list item wrapper when a caller explicitly passeditemHeight. With noitemHeight, theSingleSelectListItem'sstyles.optionRow(minHeight 64) governed, while the multi-select counterpart usesstyles.optionRowCompact(minHeight 52).This change makes the generic single-select filter default to the compact 52px height (
variables.optionRowHeightCompact) and always applies that resolved height as the list item wrapperminHeight, so single-select filter rows match multi-select rows. Callers that explicitly passitemHeight(e.g. avatar-bearing filters like cards, bank accounts, and members) are unaffected and keep their custom height. The standaloneSingleSelectListItemused by other pickers (language/theme/timezone) is also untouched.Fixed Issues
$ #94869
PROPOSAL: #94869 (comment)
Tests
itemHeight).Offline tests
N/A — UI-only styling change; row height is computed client-side and does not depend on network state. Behavior is identical online and offline.
QA Steps
itemHeight).PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari