Repository navigation
[Payment due @bernhardoj] Send optimistic Concierge timestamp for pregenerated replies - #95002
Conversation
…-pregenerated-replies
…-pregenerated-replies
…-pregenerated-replies
|
@bernhardoj Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
🚧 inimaga has triggered a test Expensify/App build. You can view the workflow run here. |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
This comment has been minimized.
This comment has been minimized.
|
Is this ready for review? If not, please let me know once it's ready for review |
|
@bernhardoj Yes it is ready for review |
|
The recordings can't seem to load for me. Can you reupload them? (I wanna see the question asked that triggers a follow-up response and how it compares between before and after fix) EDIT: I found a question that triggers a follow-up response now and can understand the before and after |
|
Videos now re-uploaded. So you can have an idea of what the before and after is. |
…-pregenerated-replies
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid.mp4Android: mWeb Chromeandroid.mweb.mp4iOS: HybridAppios.mp4iOS: mWeb Safariios.mweb.mp4MacOS: Chrome / Safariweb.mp4 |
|
Hmm, the lint errors are unrelated. Let's merge main and see if it's solved. |
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Good for product
…-pregenerated-replies
|
@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
…-pregenerated-replies
|
🚧 deetergp has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/deetergp in version: 9.4.34-0 🚀
|
|
🤖 No help site changes required. I reviewed the changes in this PR and no updates to Why: This is an internal message-ordering fix. It threads an The existing Concierge help articles (
@inimaga, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
This PR failing because of the issue #96101 |
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.34-14 🚀
|
|
🤖 Payment issue created: #96237 |
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.34-14 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Held on https://github.com/Expensify/Web-Expensify/pull/54097
This PR adds
optimisticConciergeCreatedto AddComment params for pregenerated suggested-followup responses. The suggested-followup flow now builds the optimistic Concierge action before callingaddCommentand sends the exact timestamp used for the local optimistic message, so the backend can persist the final Concierge reply without changing its chat position.Fixed Issues
$https://github.com/Expensify/Expensify/issues/651800
PROPOSAL: N/A
Tests
Manual Test:
Pre-requisite/Setup:
(Note: If testing using Staging or PROD backend, you can skip straight to Step 5)
Actual Test:
Expected behaviour
The order of messages is maintained.
Fix.-.Isssue.-.651800.mp4
Current behaviour / On Main Branch & in Prod (Control)
The order of messages is not maintained. Concierge responses would jump to the latest point.
Issue.651800.-.Before.Main.mp4
Offline tests
QA Steps
PR Author Checklist
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari