Repository navigation
Enhance odometer reading handling by introducing a baseline compariso… - #95039
Conversation
…n for user input. Update tests to verify correct re-hydration behavior when switching tabs, addressing issues with the typing guard state.
|
@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid.movAndroid: mWeb Chromemweb-chroe.moviOS: HybridAppios.moviOS: mWeb Safarimweb-safari.movMacOS: Chrome / Safariweb.mov |
|
🚧 Julesssss has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🤖 Ran the repro steps from #94961 on dev NewDot web with this PR's changes applied (branch Result: the bug does NOT reproduce — the fix works. ✅ Following the exact steps (odometer Start=100 / End=200 → Save for later → reopen → edit start 100→150→100 → Map → Odometer → Map):
Both were confirmed by reading the accessibility tree, not just the screenshots. No JS console errors.
Notes & caveats
|
|
🚀 Deployed to staging by https://github.com/Julesssss in version: 9.4.27-1 🚀
|
|
🤖 Help site review — no docs changes required. This PR is an internal bug fix: an edit-then-revert of an odometer reading was leaving It changes no user-facing feature, UI label, tab name, or documented workflow — it restores the behavior the help site already describes.
Since the documented behavior is correct and the fix simply makes the app match it, there is nothing to add or edit in @DylanDylann — no help site change is needed here, so there's no linked docs PR to review. If you believe any odometer/Save-for-later behavior is under-documented, let me know and I'll draft the update. |
|
🚀 Deployed to production by https://github.com/grgia in version: 9.4.27-2 🚀
Bundle Size Analysis (Sentry): |
|
🤖 Result: BLOCKED — could not test the App#95039 odometer fix on either session. Both browser sessions were stopped by the same environment problem: the App web dev build fails to compile, so the Expensify UI never loaded. This is an environment/dependency failure, not a regression in the odometer fix — no odometer flow was reachable in either session.
Both sessions used the exact literal session names as requested (the run-id prefix in the recording filenames is added automatically by the recording tooling; the session strings passed to every command were Root cause (blocker): webpack build error from a missing export in the Additional identical errors for Screenshots (captured at the blocker, full-page): Recordings (per session):
I did not loop re-opening past capturing the blocker. To retest the odometer fix, the dev environment's |





Explanation of Change
Fixed Issues
$ #94961
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-07-01.at.16.10.05.mov
Android: mWeb Chrome
Screen.Recording.2026-07-01.at.16.06.34.mov
iOS: Native
Screen.Recording.2026-07-01.at.16.07.05.mov
iOS: mWeb Safari
Screen.Recording.2026-07-01.at.16.04.00.mov
MacOS: Chrome / Safari
Screen.Recording.2026-07-01.at.15.59.09.mov