Repository navigation
Add Connect to Certinia Sandbox option - #95113
Conversation
Wire isSandbox through the prerequisites flow so sandbox uses the Salesforce test bundle links and OAuth endpoint.
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
|
@thelullabyy Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Adds connectSandboxButton to all language files to satisfy typecheck, and uses a named variable at the call site for readability.
|
Running translations for you. 👍 |
trjExpensify
left a comment
There was a problem hiding this comment.
Core PR for a WN project. 👍
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index 08cb0689c37..b69a2d16e39 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -5069,7 +5069,7 @@ ${amount} für ${merchant} – ${date}`,
oauth: 'Über Salesforce anmelden',
oauthDescription: 'Um die Einrichtung abzuschließen, müssen Sie sich über Salesforce und Certinia anmelden.\n\nVerwenden Sie die Schaltfläche unten, um fortzufahren.',
connectButton: 'Mit Certinia verbinden',
- connectSandboxButton: 'Mit Certinia Sandbox verbinden',
+ connectSandboxButton: 'Mit Certinia-Sandbox verbinden',
},
import: {
chartOfAccounts: 'Kontenplan',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index d4e462e0947..52411bdc606 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -5007,7 +5007,7 @@ ${integrationName === CONST.ONBOARDING_ACCOUNTING_MAPPING.other ? 'あなたの'
oauth: 'Salesforce からログイン',
oauthDescription: '設定を完了するには、Salesforce と Certinia を通じてサインインする必要があります。\n\n続行するには、下のボタンを使用してください。',
connectButton: 'Certinia に接続',
- connectSandboxButton: 'Certinia Sandbox に接続',
+ connectSandboxButton: 'Certinia サンドボックスに接続',
},
import: {
chartOfAccounts: '勘定科目表',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index fe22f51fe77..aefa299db4a 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -5044,7 +5044,7 @@ ${amount} voor ${merchant} - ${date}`,
oauth: 'Log in via Salesforce',
oauthDescription: 'Om de installatie te voltooien, moet je je aanmelden via Salesforce en Certinia.\n\nGebruik de knop hieronder om door te gaan.',
connectButton: 'Verbind met Certinia',
- connectSandboxButton: 'Verbind met Certinia Sandbox',
+ connectSandboxButton: 'Verbinding maken met Certinia Sandbox',
},
import: {
chartOfAccounts: 'Rekeningschema',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index f8e2ff8fb09..0b53ab3c640 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -5037,7 +5037,7 @@ ${amount} dla ${merchant} - ${date}`,
oauth: 'Zaloguj się przez Salesforce',
oauthDescription: 'Aby zakończyć konfigurację, musisz się zalogować przez Salesforce i Certinia.\n\nUżyj przycisku poniżej, żeby kontynuować.',
connectButton: 'Połącz z Certinia',
- connectSandboxButton: 'Połącz z Certinia Sandbox',
+ connectSandboxButton: 'Połącz z piaskownicą Certinia',
},
import: {
chartOfAccounts: 'Plan kont',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 9aea2807534..d50eb87e685 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -4906,7 +4906,7 @@ ${amount},商户:${merchant} - 日期:${date}`,
oauth: '通过 Salesforce 登录',
oauthDescription: '要完成设置,您需要通过 Salesforce 和 Certinia 登录。\n\n请使用下方按钮继续。',
connectButton: '连接到 Certinia',
- connectSandboxButton: '连接到 Certinia Sandbox',
+ connectSandboxButton: '连接 Certinia Sandbox',
},
import: {
chartOfAccounts: '会计科目表',
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
|
@ShridharGoel Please merge main and adding recordings in platforms as well |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppScreen.Recording.2026-07-07.at.15.36.32.moviOS: mWeb SafariScreen.Recording.2026-07-07.at.15.34.43.mov |
|
Besides this point #95113 (comment), I think PR doesn't work as well. Kindly check again... @ShridharGoel Screen.Recording.2026-07-06.at.23.33.12.mov |
|
The option is showing as below Screen.Recording.2026-07-07.at.1.13.33.PM.mov |
|
@codex review |
|
@ShridharGoel Bump on this #95113 (comment) |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1c38da28d5
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…-certinia-sandbox-connect
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@ShridharGoel Thanks for the update. Code LGTM but let's check this comment before I can approve #95113 (comment) |
…-certinia-sandbox-connect # Conflicts: # src/pages/workspace/accounting/certinia/prerequisites/CertiniaPrerequisitesStep.tsx
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 yuwenmemon has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.4.32-0 🚀
|
|
@ShridharGoel @thelullabyy @yuwenmemon Uable to |
|
🚀 Deployed to production by https://github.com/grgia in version: 9.4.32-3 🚀
Bundle Size Analysis (Sentry): |


Explanation of Change
Adds a "Connect to Certinia Sandbox" option to the Certinia connect menu. Selecting it opens the prerequisites flow with
isSandbox=true, which shows the Salesforce sandbox (test.salesforce.com) bundle install links and targets the sandbox OAuth endpoint on connect. The production "Connect to Certinia" flow is unchanged.Fixed Issues
$ #89443
PROPOSAL:
Tests
test.salesforce.com).login.salesforce.com) and the flow is unchanged.Offline tests
Same as tests.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
MacOS: Chrome / Safari
Screen.Recording.2026-07-07.at.1.13.33.PM.mov