Repository navigation
[No QA] Migrate GitHub Action bundling from ncc to esbuild - #95257
Conversation
Replace buildActions.sh (npx ncc) with .github/scripts/buildActions.ts, run directly via bun. esbuild's native single-file bundling (splitting: false) and tsconfig.json paths support remove the need for ncc's custom patches. Committed index.js bundles are intentionally not regenerated in this commit; that happens next. Co-authored-by: Cursor <cursoragent@cursor.com>
Regenerate all 24 committed index.js bundles using the new esbuild build script. Bundle contents differ from the ncc output (different minifier/module wrapper), but each action's runtime behavior is unchanged. Co-authored-by: Cursor <cursoragent@cursor.com>
@vercel/ncc was only used for GitHub Action bundling, which now runs on esbuild. Fully remove it so no traces remain: - Drop the devDependency and regenerate package-lock.json - Delete patches/@vercel+ncc/ (both patches + details.md) - esbuild's native single-file bundling and tsconfig.json paths support make both patches unnecessary - Remove @vercel/ncc from knip.json's ignoreDependencies - Drop the "npx ncc cache clean" hint from verifyActions.sh - Reword the ncc-compiled comment in bumpVersion.ts Removing @vercel/ncc changed dependency hoisting, so esbuild now resolves to the top-level ^0.28.1 (previously a deduped transitive 0.27.2) when npm install ran. Rebuilding the actions with that version picks up a small esbuild runtime helper change (safer __esm/__commonJS error handling); included here rather than as a separate commit since it's a direct consequence of the ncc removal + reinstall. Co-authored-by: Cursor <cursoragent@cursor.com>
Document the esbuild + buildActions.ts build process in place of the old ncc + buildActions.sh references. Co-authored-by: Cursor <cursoragent@cursor.com>
Add the blank line Prettier expects after a shebang line. Co-authored-by: Cursor <cursoragent@cursor.com>
|
npm has a |
The root tsconfig.json (used by npm run typecheck) includes .github/**/* but doesn't declare Bun's global types, so tsc failed with "Cannot find name 'Bun'". Use Node's fs/promises instead of Bun.file()/Bun.write() - functionally identical here and avoids needing Bun-specific types in the root tsconfig. Co-authored-by: Cursor <cursoragent@cursor.com>
storybook@10.1.10 (esbuild ^0.18.0-^0.27.0) and tsx (esbuild ~0.27.0) both cap below our devDependency's ^0.28.1, so npm couldn't dedupe them onto our version. It instead nested separate copies at the latest version satisfying their ranges (0.27.7), which falls inside the SNYK-JS-ESBUILD-17750815 directory traversal vulnerability range (>=0.27.3 <0.28.1). Previously, without our explicit devDependency, everything shared a single hoisted esbuild@0.27.2, which happened to be just below the vulnerable range. Add esbuild to the existing "overrides" block (already used for other transitively-vulnerable packages like ws, json5, follow-redirects) to force every consumer, including storybook and tsx, onto the patched 0.28.1+ line. Verified npx tsx and npx storybook --version still work, and npm run gh-actions-build produces identical bundles. Co-authored-by: Cursor <cursoragent@cursor.com>
- Rename NOTE_DONT_EDIT to COMPILED_FILE_BANNER (rulesdir/no-negated-variables flagged "DONT" as a negation; the compiled banner text itself is unchanged) - Move each action's error handling into buildAction() and have it return a boolean instead of indexing parallel results/GITHUB_ACTIONS arrays by position, which avoids the rulesdir/prefer-at violations without introducing possibly-undefined array access Co-authored-by: Cursor <cursoragent@cursor.com>
Run npm run gh-actions-build after oxfmt (via explicit priority, since lefthook only guarantees ordering between non-parallel commands when priority is set) whenever a staged .ts file under .github/ changes, so the rebuilt action bundles are committed alongside their source instead of relying solely on CI's verifyActions.sh to catch stale bundles. Rebuilt index.js files are staged with an explicit `git add` in the command itself, since stage_fixed's `files` option gates whether the command runs at all (it skips when the pre-run diff is empty), which would prevent the build from ever executing. Co-authored-by: Cursor <cursoragent@cursor.com>
Codecov Report✅ All modified and coverable lines are covered by tests. |
By default, lefthook's generated hook shim silently no-ops (exits 0) if it can't find a runnable lefthook binary - it prints "Can't find lefthook in PATH" but lets the commit through with zero checks run (not just gh-actions-build, but oxfmt too). This is a real risk with worktree-based development: a brand-new worktree has no node_modules until `npm install` runs, and it's easy to make a quick edit and try to commit before that. Setting the top-level assert_lefthook_installed option changes the generated shim's failure branch to exit 1 with a clear message instead of silently passing, so a missing lefthook now blocks the commit (escape hatches --no-verify / LEFTHOOK=0 still work) rather than silently skipping formatting and the bundle rebuild. This only affects the already-failing path, so it has no cost when lefthook is present and working normally. Verified by hiding node_modules/lefthook* and confirming `git commit` now aborts with exit 1 instead of succeeding silently, then restoring it and confirming normal commits still auto-format and rebuild bundles as expected. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
|
@MonilBhavsar Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
This comment has been minimized.
This comment has been minimized.
# Conflicts: # lefthook.yml
|
converting to draft while I look into the codex comment |
… and Octokit chain @actions/core (v3+) and @actions/github (v9+) are ESM-only, so scope the compiled actions to ESM via package.json "type": "module". Upgrade the Octokit plugin chain to the versions @actions/github v9 bundles, and fix the one breaking change in that chain: @octokit/plugin-throttling's onAbuseLimit callback was renamed onSecondaryRateLimit, with retryCount moving to its own handler argument. Co-authored-by: Cursor <cursoragent@cursor.com>
…y points esbuild flattens bundled files into one shared module scope, so checkSVGCompression/compressSvg and bumpVersion's action wrapper each having their own require.main === module guard meant both guards fired whichever bundle they ended up in -- for bumpVersion this silently executed the real version-bump logic as a side effect of building or testing checkSVGCompression, and vice versa. Fix by making compressSvg.ts (renamed .mts, since it needs unambiguous ESM to statically import svgo under ts-node) and bumpVersion.ts guard-free pure libraries, and moving CLI-invocation logic to new, never-imported compressSvg-cli.mts / bumpVersion-cli.ts entry points. Add runTsNodeEsm.mjs, a bootstrap needed to run a single .mts file as real ESM under ts-node (Node 20 throws ERR_REQUIRE_CYCLE_MODULE otherwise). Also convert the action wrappers' own require.main guards to the ESM idiom, since real ESM has no require.main. Co-authored-by: Cursor <cursoragent@cursor.com>
….exports Real ESM has no require.main, so convert the remaining 16 action-level if (require.main === module) guards to the equivalent ESM idiom: import.meta.url === pathToFileURL(process.argv.at(1) ?? '').href. Also remove markPullRequestsAsDeployed.ts's leftover module.exports = run (a CJS-only artifact; export default run already exists), and update its test to import the default export instead. Co-authored-by: Cursor <cursoragent@cursor.com>
@actions/core v3 and @actions/github v9 (and their @octokit/* and transitive deps) ship pure ESM, but Jest runs everything through babel-jest to CommonJS: - transformIgnorePatterns: stop treating @actions/@octokit and their ESM-only transitive deps (before-after-hook, json-with-bigint, universal-user-agent) as already-CJS node_modules. - New jest/esmExportsResolver.js: these packages only expose an "import" condition in their package.json exports maps, which Jest's default resolver doesn't request; add it for @actions/*/@octokit/* only. - babel-plugin-transform-import-meta: rewrites the action guards' bare import.meta.url (a syntax error once babel-jest transpiles the surrounding module to CJS) to a CJS-safe equivalent. - jest/setupGlobalPolyfills.ts: @actions/http-client reads the global TextEncoder at import time, earlier than jest/setup.ts's own (now-redundant) polyfill could run. - moduleNameMapper: strip explicit ".js" specifiers on relative imports (required by Node's ESM resolution in .github/libs, now real ESM) so Jest's resolver still finds the .ts source behind them. Also document the ESM output and the library/CLI split pattern in .github/workflows/README.md. Co-authored-by: Cursor <cursoragent@cursor.com>
This action landed on main after this branch converted the other 17 guards, so it still used `require.main === module`. esbuild leaves both identifiers untouched rather than failing the build, and `module` doesn't exist in an ES module, so the bundle threw `ReferenceError: module is not defined in ES module scope` on load — the action would have been dead in CI. Added a `no-restricted-globals` rule over `.github/actions/**` and `.github/libs/**` (the sources esbuild bundles) for `module`, `__dirname` and `__filename`, so the next one is caught by the ESLint check instead of at runtime. `.github/scripts/` is excluded: it runs directly under Bun, which provides these.
knip's "compare against main" check flagged it as unlisted. The extracted detectReactComponent uses `isIdentifier`/`isMemberExpression` from @babel/types in place of the hand-rolled `SuperClassType` and its unsafe assertion, so the import is real and the dependency should be declared alongside @babel/parser and @babel/traverse. It was already installed transitively via @babel/traverse, so this adds no install weight. knip now reports no new findings (net -1: declaring @octokit/plugin-rest-endpoint-methods explicitly also resolved a pre-existing unlisted finding in failureNotifier.ts).
`React Compiler Compliance` failed on this PR with:
HttpError: Server Error: Sorry, this diff is taking too long to generate.
{"resource":"PullRequest","field":"diff","code":"not_available"} - 422
GitHub builds every file's patch to answer `pulls.listFiles`, and gives up when
one page holds too much content. This PR rewrites 24 action bundles, each a few
MB of diff, which is enough to trip it. Measured against this PR: per_page=40
succeeds, per_page=50 and above return 422 — and it is deterministic, not a
transient hiccup, so retrying does not help.
Two changes:
- Request 30 files per page instead of 100. That resolves this PR (81 files over
3 pages), but the margin is thin enough that it can't be the only mitigation.
- Fall back to `git diff --name-status -M` when the API can't answer at all,
rather than failing the check. That compares the two trees directly, so it
needs only those two commits and not the history between them, which is what
makes it safe in CI's shallow checkout where a merge-base diff would not be.
It resolves against `fromRef` rather than the merge base, so it can report
files changed only on the base branch — too many files rather than too few,
which is the safe direction for the checks built on this.
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Reverted three things that were only needed while this code still ran under
ts-node/Jest CJS, verifying in each case that nothing depends on them:
- The detectReactComponent extraction. It existed so the test could import the
AST logic without pulling an @actions-importing module into scope, which stopped
mattering once the tests moved to bun:test. newComponentCategory.ts keeps only
the change the upgrade forces: @actions/github v9 dropped the
"./lib/interfaces" deep import path, so WebhookPayload is derived from
context.payload instead. This also drops the @babel/types dependency.
- The getMergedPR extraction from failureNotifier.ts, for the same reason. Only
the ESM entry-guard conversion remains.
- The scripts/compressSvg .mts rename and its '.mjs' import specifiers, which
existed to force unambiguous ESM for Node/ts-node. Bun and esbuild both resolve
plain .ts fine, so this also removes buildActions.ts's resolveExtensions
override, the knip {mts,cts} globs, and the eslint **/*.mts,**/*.cts entry.
Verified the case the rename was for: checkSVGCompression still fails on a
missing token rather than crashing in css-tree, and compress-svg still runs.
- The **/*.tsbuildinfo gitignore entry, redundant with main's existing
**/tsconfig.tsgo.tsbuildinfo.
Kept, having confirmed each is still load-bearing:
- The compressSvg/bumpVersion lib+CLI split. Re-tested the double-fire directly:
adding a guard back to compressSvg.ts makes it fire when checkSVGCompression's
bundle runs, because esbuild flattens every bundled file into one module scope
where they all share the entry point's import.meta.url.
- Git.ts's maxBuffer. `git diff -U0` over this branch is 171 MB against Node's
1 MB default.
tests/tooling: 396 pass, 0 fail. 51 non-generated files changed, down from 56,
and 7 files no longer touched at all.
`googleapis` is a mega-package containing every Google API (212 MB unpacked),
and esbuild has no way to tree-shake it because it is CJS. The two actions that
use it need exactly `google.auth.GoogleAuth` and `google.androidpublisher` v3,
so they now import `@googleapis/androidpublisher` (2.5 MB unpacked) directly.
Its `auth` export is the same AuthPlus instance the mega-package exposes as
`google.auth`, so the call sites are otherwise unchanged.
bundle before after change
checkAndroidStatus 771,910 52,874 -93%
getAndroidRolloutPercentage 764,891 45,855 -94%
all 24 bundles, total 83.13 MB 29.88 MB -64%
build wall time (median) 0.75s 0.45s -40%
The largest bundle is now authorChecklist at 69,843 lines, so nothing is in the
range that was breaking GitHub's diff viewer.
The createRequire banner still has to stay: googleapis-common and the rest of
the CJS dependency chain call require() on Node builtins, and all 24 bundles
still reference it.
Cutting googleapis down to @googleapis/androidpublisher shrank this PR's diff from ~4.1M to ~2.8M lines, which is enough for GitHub to generate the PR file list again: pulls.listFiles now succeeds at the default per_page=100, verified stable over five consecutive calls. So the per_page reduction and the local git-diff fallback are both unnecessary here, and scripts/utils/Git.ts goes back to main apart from one line. maxBuffer stays. `git diff -U0` over this branch is still 116.9 MB against Node's 1 MB default, so Git.diff would throw ENOBUFS locally without it. Worth noting the underlying fragility is real and outlives this PR: any PR whose diff GitHub can't generate will fail React Compiler Compliance with a confusing 422 rather than degrading gracefully. That deserves its own PR rather than riding along in a bundler migration.
|
@Julesssss opening this up for review. |
Julesssss
left a comment
There was a problem hiding this comment.
Good improvement, some minor comments
Node 24 exposes import.meta.main, so we can drop the pathToFileURL(process.argv) comparison. Actions already run on node24.
Scan .github/actions/javascript/*/<name>.ts instead of keeping a hard-coded list that new actions can miss.
|
🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.4.59-0 🚀
|
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.4.59-5 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
This PR replaces
@vercel/nccwithesbuildfor bundling our JavaScript GitHub Actions, and switches the compiled bundles from CommonJS to native ESM.Why
@actions/core/@actions/githubpast their CJS-only majors (both are ESM-only as of the versions used here), and fixes a realimport.meta.urlcrash incheckSVGCompression(itssvgo/css-treedependency is pure ESM and can't be safely bundled into CJS).What changed:
Bundler swap
.github/scripts/buildActions.shwith.github/scripts/buildActions.ts, run directly viabun. The script ends up much simpler — no manual background-PID juggling to get parallelism.@vercel/ncc: uninstalled the dependency, deletedpatches/@vercel+ncc/(both patches plusdetails.md), removed it fromknip.json, and scrubbed the remaining references inverifyActions.shand the workflows README.esbuilddevDependencyplus anoverridespin, and alefthookgh-actions-buildpre-commit hook — now that the build takes under a second, it's cheap enough to run on every commit that touches.github/**/*.ts.buildActions.tsbuilds 24 actions.buildActions.shlisted only 23 — it was missinggenerateHelpPreviewComment, so that action's committed bundle was never being rebuilt.googleapiswith@googleapis/androidpublisherin the two Android actions.googleapiscarries every Google API (212 MB unpacked) and is CJS, so esbuild can't tree-shake it; those two actions need onlygoogle.auth.GoogleAuthandgoogle.androidpublisherv3. The per-API package is 2.5 MB unpacked and itsauthexport is the sameAuthPlusinstance, so the call sites are otherwise unchanged.checkAndroidStatusdrops from 771,910 lines to 52,874 (-93%) andgetAndroidRolloutPercentagefrom 764,891 to 45,855 (-94%) — both were large enough to break GitHub's diff viewer.ESM output
formatfromcjstoesm, scoped via a new.github/actions/javascript/package.json({"type": "module"}) so it applies to the bundles and nothing else.createRequirebanner so bundled CJS dependencies (googleapis,lodash,semver,@babel/parser,@babel/traverse— none of which ship an ESM build) can still callrequire()on Node builtins.svgoexternal(not bundled) forcheckSVGCompressiononly, so Node's own ESM resolution gives itscss-treedependency a realimport.meta.urlinstead of esbuild's CJS-mode stub — this was crashing withERR_INVALID_ARG_VALUEbefore.if (require.main === module)entry guards (plusscripts/createOrUpdateDeployChecklist.ts) to the ESM idiom (import.meta.url === pathToFileURL(process.argv.at(1) ?? '').href).no-restricted-globalsESLint rule over.github/actions/**and.github/libs/**— the sources esbuild bundles — banningmodule,__dirnameand__filename. esbuild leaves these identifiers untouched instead of failing, so a CJS idiom in a bundled source builds fine and then throwsReferenceError: module is not defined in ES module scopewhen the action runs in CI.proposalPoliceCommentlanded on main after this branch's original guard conversion and hit exactly this — its bundle threw on load, so the action would have been dead in CI. The rule is there to catch the next one at lint time..github/scripts/is excluded — it runs directly under Bun, which does provide these.checkSVGCompression.ts/scripts/compressSvg.tsandbumpVersion.ts/scripts/bumpVersion.tseach had their ownif (require.main === module)guard, but esbuild flattens bundled files into one shared module scope, so both guards fired in each other's bundles — forbumpVersionthis silently executedscripts/bumpVersion.ts's real version-bump logic as a side effect of building/testingcheckSVGCompression, and vice versa (confirmed via isolated repro, unrelated to CJS vs ESM). Fixed by splitting both into guard-free libraries (imported by their action + tests) plus new, never-importedscripts/compressSvg-cli.ts/scripts/bumpVersion-cli.tsentry points for CLI use. This pattern is now documented in the workflows README.Dependency upgrades
@actions/core1.10.0 → 3.0.1,@actions/github5.1.1 → 9.1.1, and the@octokit/*chain aligned with what@actions/githubv9 bundles:core^7,plugin-paginate-rest^14,plugin-throttling^11,request-error^7,webhooks-types^7.6.1, plusplugin-rest-endpoint-methods^17 now declared explicitly.getInput/setOutput/setFailed/getOctokit/context. The API breakages were:@octokit/plugin-throttling'sonAbuseLimitrenamed toonSecondaryRateLimit, withretryCountmoving fromoptions.request.retryCountto its own handler argument (GithubUtils.ts,scripts/aggregateGitHubDataFromUpwork.ts).@octokit/plugin-rest-endpoint-methodsno longer exportsRestEndpointMethodsdirectly, onlyApi(which wraps it as{rest: RestEndpointMethods}), so it's derived asApi['rest'](GithubUtils.ts,isTeamMember.ts).@octokit/openapi-typesdirectly inGithubUtils.ts/DeployChecklistUtils.ts. It's only a transitive dependency, so the bare specifier resolved to whatever npm hoisted (v28) rather than the copy the endpoint methods were generated against (v27) — which made otherwise identical types mutually unassignable (issue.idisnumberin one andnumber | bigintin the other). These aliases now derive fromRestEndpointMethodTypes, which always matches the installed endpoint methods.Test adaptations for
@octokitv7These are the reason the dependency upgrade couldn't just be a version bump. All of these tests pass on main and broke silently on the upgrade — they kept passing type checks while firing real HTTP requests at
api.github.com.@octokit/plugin-rest-endpoint-methodsv17 exposes each REST namespace (octokit.rest.issues,.pulls,.actions,.teams,.repos) as aProxythat creates endpoint methods on first access. Bun'sjest.spyOnsilently no-ops on a Proxy-backed property — it returns a mock, but the property keeps its original value — so mocks never intercepted. That showed up asHttpError: Bad credentials(401) in several files, and as an outright hang inDeployChecklistUtilsonce the real retry backoff started running. Addedtests/utils/materializeOctokitNamespace.tsto copy a namespace into a plain object first, and applied it at each spy site.@octokit/requestv10 reads a response body withtext()and parses it itself rather than callingjson(), sopostOrReplaceComment's stubbedResponsereturned no comments. It now stubstext().Also in here
newComponentCategory.tsderivesWebhookPayloadfromcontext.payload:@actions/githubv9 dropped the./lib/interfacesdeep import path from its exports map, so the type can't be imported directly any more.Benchmarks
Measured back to back on the same machine today, so the two columns are directly comparable (
mainat0932767for the ncc baseline, this branch for esbuild):generateHelpPreviewComment)index.jssizeMost of the size and a good chunk of the time come from dropping the
googleapismega-package rather than from the bundler swap itself. On esbuild withgoogleapisstill in place the totals were 83.13 MB and 0.75s median, so the bundler change alone is roughly size-neutral against ncc; the per-API import is what makes it smaller.Two notes on reading this table honestly: esbuild builds one more action than ncc did, which very slightly flatters it; and rebuilding with ncc on
mainleavesisDeployChecklistLocked/index.jsandproposalPoliceComment/index.jsdirty, i.e. those two committed bundles are already stale on main today. Neither affects the conclusion.Fixed Issues
$
PROPOSAL:
Tests
Requires Node 26.5.0 / npm 11.17.0 (per
engines).npm installin a clean checkout.npm run gh-actions-buildand confirm all 24 actions build without error in well under two seconds../.github/scripts/verifyActions.shand confirm it reports "Github Actions are up to date!"..github/actions/javascript/contains exactly oneindex.jsand no extra chunk files:run()is ever reached):FAIL:lines. Each action should instead fail on a missing input, which means it loaded and ran.node .github/actions/javascript/checkSVGCompression/index.jswith noGITHUB_TOKENset fails withError: Input required and not supplied: GITHUB_TOKEN(not a crash).node .github/actions/javascript/bumpVersion/index.jswith noSEMVER_LEVELset fails withError: Input required and not supplied: SEMVER_LEVEL, and thatgit statusshows no unexpected file changes afterwards (i.e. it didn't actually bump the version as a side effect).npm run compress-svgand confirm it runs to completion and reports compression results (rather than erroring or silently doing nothing).npm run test:bunand confirm it passes. Thetests/tooling/portion is what covers.github/andscripts/; note these files depend on per-file isolation, so run them via that script (--parallel) rather than pointingbun testat the directory yourself.npm run typecheckandnpx eslint .github/ scripts/ tests/tooling/and confirm both are clean.if (require.main === module) { run(); }to any file under.github/actions/javascript/, runnpx eslinton it, and confirm it reports ano-restricted-globalserror pointing at the ESM idiom. Revert afterwards.Note that several of these bundled actions are exercised on this PR itself before merge, at least:
isAuthorizedContributorverifySignedCommitsauthorChecklistand
Validate GitHub Actionsruns the build step in CI.Offline tests
N/A - this PR only changes the GitHub Actions build tooling, not app code.
QA Steps
N/A - this PR only changes internal CI/build tooling; there is no end-user-facing or staging/production behavior to QA.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
N/A - build tooling change only, no app UI affected.
Android: mWeb Chrome
N/A - build tooling change only, no app UI affected.
iOS: Native
N/A - build tooling change only, no app UI affected.
iOS: mWeb Safari
N/A - build tooling change only, no app UI affected.
MacOS: Chrome / Safari
N/A - build tooling change only, no app UI affected.