Repository navigation
Only read foreground location permissions without requesting them at the beginning - #95372
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5d0279d7bc
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
trjExpensify
left a comment
There was a problem hiding this comment.
Sounds wise to keep Google happy 😄
|
@Pujan92 @Julesssss Ready for your review |
Julesssss
left a comment
There was a problem hiding this comment.
Could you add 1 test case where permission is disabled and user denies request the first time. Then on second time we should reshow the prompt.
I don't think this is expected. If a user denies the request the first time, we shouldn't show the prompt again the second time. It would be annoying for users if the prompt always appeared every time |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppRecord_2026-07-08-23-11-54.mp4Record_2026-07-08-23-10-46.mp4iOS: HybridAppSimulator.Screen.Recording.-.iPhone.15.Pro.-.2026-07-08.at.23.15.28.mov |
|
🚧 Julesssss has triggered a test Expensify/App build. You can view the workflow run here. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment has been minimized.
This comment has been minimized.
This comment was marked as outdated.
This comment was marked as outdated.
Pujan92
left a comment
There was a problem hiding this comment.
LGTM! Tests well as App custom prompt displayed first before requesting OS permission.
Julesssss
left a comment
There was a problem hiding this comment.
Testing well for me too.
i noticed an existing issue where the Android modal animation is a bit janky and appears to have its show animation restart. LMK if you are interested in working on that seperately!
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 Julesssss has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/Julesssss in version: 9.4.32-0 🚀
|
|
🤖 Help site review: no changes required I reviewed the changes in this PR against Conclusion: No help site updates are needed, so I did not open a draft PR. WhyThis PR is a permission-timing / Google Play prominent-disclosure compliance fix. It changes when the OS foreground-location prompt appears — opening the manual/GPS distance map now only reads the current permission status (falling back to a default location if not granted) instead of requesting it, so the OS prompt no longer fires on open without a prior explicit user action. The request now happens only when the user starts the request flow. The public help docs describe the user-facing distance/GPS workflow (e.g. @DylanDylann, please confirm you agree no help site changes are needed here. If you'd like an article to explicitly document the location-permission behavior, let me know and I'll draft one. |
|
🚀 Deployed to production by https://github.com/grgia in version: 9.4.32-3 🚀
Bundle Size Analysis (Sentry): |
|
Looks like this caused #95774 Will you guys handle it? |


Explanation of Change
Fixed Issues
$ #93747
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Test 1: Disable the location permission in App Settings
Test 2: Allow the location permission in App Settings
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-07-07.at.17.48.21.mov
Screen.Recording.2026-07-07.at.17.50.42.mov
iOS: HybridApp
Screen.Recording.2026-07-07.at.17.52.17.mov