Repository navigation
[Payment due @situchan] [No QA] Clear SW caches on web Update Required reload #95438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,10 @@ | ||
| import clearWorkboxRecoveryCaches from '@libs/clearWorkboxRecoveryCaches'; | ||
|
|
||
| /** | ||
| * On web or mWeb we can simply refresh the page and the user should have the new version of the app downloaded. | ||
| * On web or mWeb, clear stale service worker and Cache Storage entries before reloading | ||
| * so the user gets the latest bundle instead of a cached version that triggers Update Required. | ||
| */ | ||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | ||
| export default function updateApp(isProduction: boolean) { | ||
| window.location.reload(); | ||
| clearWorkboxRecoveryCaches().then(() => window.location.reload()); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the Update Required screen is open and the user has gone offline, this path now deletes Cache Storage and unregisters the service worker before reloading. The rest of the web recovery paths guard cache clearing with
navigator.onLinebecause clearing the cached shell while offline leaves the PWA unable to reload until connectivity returns; this button can hit the same case after the server has already setRAM_ONLY_UPDATE_REQUIREDand connectivity drops. Please keep the plain reload fallback when offline and only clear Workbox caches while online.Useful? React with 👍 / 👎.