Repository navigation
Adjust to use dedicated RevealExpensifyTravelCardDetails command - #95514
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
rafecolton
left a comment
There was a problem hiding this comment.
LGTM
It's kinda weird that we use input fields for the CVV, wondering if we should change that as a followup. @trjExpensify what do you think?
|
I think it's fine, did @Expensify/design green light it in a doc or something? |
|
Pretty sure we approved/suggested that because we got feedback that the original way we displayed CVV was not big or obvious enough. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 blimpich has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/blimpich in version: 9.4.32-0 🚀
|
|
🤖 No help site changes required. I reviewed the changes in this PR against the help site content in Why: This is a purely internal refactor with no user-facing impact. It swaps the deprecated
None of the feature names, tab names, settings labels, buttons, or documented steps change. The help site documents user-facing behavior, not internal API command or function names, so there is nothing to update. Docs I checkedI searched Since no changes are required, I did not create a draft help site PR. |
|
🚀 Deployed to production by https://github.com/grgia in version: 9.4.32-3 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
This replaces the deprecated
RevealExpensifyCardDetailsand start using the dedicated command for travel cards:RevealExpensifyTravelCardDetails.Fixed Issues
Part of https://github.com/Expensify/Expensify/issues/651797
PROPOSAL: https://github.com/Expensify/Expensify/issues/651797#issue-4731057934
Tests
Precondition: User with a Travel Card
RevealTravelCard.mov
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari