Fix: return home URL with backTo param for invalid reportID in getRoute by lorretheboy · Pull Request #95637 · Expensify/App

lorretheboy · 2026-07-08T17:30:40Z

Explanation of Change

Fixed Issues

$ #95195
PROPOSAL: #95195 (comment)

Tests

Test 1

In the browser address bar, navigate directly to a report URL with an empty/invalid reportID, e.g. https://dev.new.expensify.com:8082/r/ (or /r/undefined).
Verify the app lands and does not crash or get stuck loading.

Test 2

Open a normal, existing report from the LHN.
Navigate directly to a valid report URL
Verify the report opens correctly and any referrer/backTo query params still behave as before.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Test 1

In the browser address bar, navigate directly to a report URL with an empty/invalid reportID, e.g. https://dev.new.expensify.com:8082/r/ (or /r/undefined).
Verify the app lands and does not crash or get stuck loading.

Test 2

Open a normal, existing report from the LHN.
Navigate directly to a valid report URL
Verify the report opens correctly and any referrer/backTo query params still behave as before.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android-web.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios.web.mov

MacOS: Chrome / Safari

web.mov

lorretheboy · 2026-07-10T08:17:55Z

        getRoute: (reportID: string | undefined, reportActionID?: string, referrer?: string, backTo?: string) => {
            if (!reportID) {
                Log.warn('Invalid reportID is used to build the REPORT_WITH_ID route');
+                return getUrlWithBackToParam(ROUTES.HOME, backTo);


I think it's fine to add new use of getUrlWithBackToParam in this func as it is already used inside this one

codecov · 2026-07-10T08:20:50Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/ROUTES.ts	`20.91% <0.00%> (+0.61%)`	⬆️
... and 315 files with indirect coverage changes

melvin-bot · 2026-07-10T08:26:24Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

eVoloshchak · 2026-07-13T19:06:04Z

@lorretheboy, could you merge the latest main please?

lorretheboy · 2026-07-13T19:26:41Z

@eVoloshchak I merged main

eVoloshchak · 2026-07-15T14:26:01Z

Reviewer Checklist

Screenshots/Videos

Android: HybridApp

N/A

Android: mWeb Chrome

Screen.Recording.2026-07-15.at.20.49.25.mov

iOS: HybridApp

Screen.Recording.2026-07-15.at.20.43.52.mov

iOS: mWeb Safari

Screen.Recording.2026-07-15.at.20.40.43.mov

MacOS: Chrome / Safari

Screen.Recording.2026-07-15.at.20.44.10.mov

eVoloshchak

LGTM!

github-actions · 2026-07-16T13:35:31Z

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-07-16T13:41:16Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #95637.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-06c430a10d6-84c49dd-5a021d4fe9ae75735fc026dfacf05fe588cf13ca/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-06c430a-84c49dd-f065827895cb9a08ccfa6514c3f5a916c67a361d/index.html

Web 🕸️
https://95637.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

PR #95637 added a new getUrlWithBackToParam usage in ROUTES.ts, exceeding the allowed seatbelt count of 105 and failing ESLint on main. Co-authored-by: Cursor <cursoragent@cursor.com>

OSBotify · 2026-07-16T23:49:42Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.36-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-07-16T23:52:26Z

🤖 No help site changes required.

I reviewed the changes in this PR against the help site articles under App/docs/articles.

What this PR does: It's an internal bug fix. ROUTES.REPORT_WITH_ID.getRoute now returns the Home URL (carrying the backTo param) when it's given an empty/invalid reportID, instead of building a malformed r/undefined route — which was causing a deep-link crash (Sentry APP-284, linked from #95195). The only other change is a corresponding unit test update.

Why no docs update is needed: The help site documents user-facing product behavior — features, settings, workspaces, billing, integrations, and UI flows. This change is a purely internal navigation/routing fix with no change to any documented feature, tab, setting, label, or button. There is no user-facing behavior described in the help site that this alters, so no article requires an edit and no draft docs PR was created.

@lorretheboy, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

OSBotify · 2026-07-20T20:02:33Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.38-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

MelvinBot · 2026-07-20T20:05:43Z

Help site review: no changes required

I reviewed the changes in this PR against Expensify's help site content under App/docs/articles, and no help site updates are required.

Why: This PR is a purely internal crash/error-handling fix. In src/ROUTES.ts, when REPORT_WITH_ID.getRoute is called with an empty/invalid reportID, it now returns the Home URL (with the backTo param preserved) instead of building an invalid r/undefined route — preventing the deep-link crash tracked in the linked Sentry issue (APP-284). The other changes are an ESLint seatbelt count bump and a unit test update.

None of this changes any documented feature, workflow, setting, button, tab, or user-facing behavior described in the help site. The behavior is invisible to end users (it silently avoids a broken/crashing navigation state), so there is nothing to add or correct in App/docs/articles.

No draft PR has been created since no documentation changes are needed.

@lorretheboy, please confirm this assessment. If you believe a user-facing behavior here should be documented, let me know and I'll create the draft help site PR.

OSBotify · 2026-07-20T22:02:06Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.40-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-07-20T22:05:11Z

🤖 Help site review — no changes required

I reviewed the changes in this PR and no updates to Expensify's help site files under App/docs/articles are required, so I did not create a draft PR.

Why: This is an internal crash/navigation fix. It makes ROUTES.REPORT_WITH_ID.getRoute return the home URL (with the backTo param preserved) when an invalid/empty reportID is passed — resolving a HybridApp iOS deep-link crash (Expensify/App#95195). The diff only touches src/ROUTES.ts, an ESLint seatbelt count, and a unit test.

There is no change to any user-facing feature, setting, tab, button, label, or documented workflow. Help site articles describe product features and end-user workflows, and none of those are altered here — the behavior change is limited to how the app handles a malformed report link internally.

Since no help site changes are required, no draft PR was created. @lorretheboy, if you believe a help site update is warranted here, let me know and I'll create one.

OSBotify · 2026-07-21T01:06:21Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.4.40-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

Fix: return home URL with backTo param for invalid reportID in getRoute

f88a7e3

melvin-bot Bot assigned lorretheboy Jul 8, 2026

lorretheboy added 2 commits July 10, 2026 02:48

Merge branch 'main' of https://github.com/Expensify/App into fix/95195

e171649

fix: test

bee284f

lorretheboy commented Jul 10, 2026

View reviewed changes

lorretheboy marked this pull request as ready for review July 10, 2026 08:26

lorretheboy requested review from a team as code owners July 10, 2026 08:26

melvin-bot Bot requested review from eVoloshchak and removed request for a team July 10, 2026 08:26

melvin-bot Bot requested review from flaviadefaria and removed request for a team July 10, 2026 08:26

merge main

bfd3557

fix: conflicts

d98c0de

eVoloshchak approved these changes Jul 15, 2026

View reviewed changes

melvin-bot Bot requested a review from mountiny July 15, 2026 19:01

mountiny approved these changes Jul 16, 2026

View reviewed changes

mountiny merged commit 06c430a into Expensify:main Jul 16, 2026
33 checks passed

github-actions Bot mentioned this pull request Jul 16, 2026

[Due for payment 2026-07-28] Investigate workflow job failing on main: lint / ESLint check #96307

Closed

mountiny mentioned this pull request Jul 16, 2026

[NoQA] Fix main CI failures: seatbelt, personalDetailsList, and PolicyMemberTest #96309

Merged

50 of 52 tasks

OSBotify mentioned this pull request Jul 16, 2026

Deploy Checklist: New Expensify 2026-07-16 #96356

Closed

53 tasks done

melvin-bot Bot mentioned this pull request Jul 21, 2026

[Due for payment 2026-08-19] [$250] [Sentry: APP-284] HybridApp iOS DeepLinkManager handleViewReportLink crash #95195

Closed

quinthar added the #quality label Aug 11, 2026

Conversation

lorretheboy commented Jul 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

lorretheboy Jul 10, 2026

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Jul 10, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Jul 10, 2026

Uh oh!

eVoloshchak commented Jul 13, 2026

Uh oh!

lorretheboy commented Jul 13, 2026

Uh oh!

eVoloshchak commented Jul 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

eVoloshchak left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Jul 16, 2026

Uh oh!

github-actions Bot commented Jul 16, 2026

Uh oh!

OSBotify commented Jul 16, 2026

Uh oh!

MelvinBot commented Jul 16, 2026

Uh oh!

OSBotify commented Jul 20, 2026

Uh oh!

MelvinBot commented Jul 20, 2026

Help site review: no changes required

Uh oh!

OSBotify commented Jul 20, 2026

Uh oh!

MelvinBot commented Jul 20, 2026

Uh oh!

OSBotify commented Jul 21, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

lorretheboy commented Jul 8, 2026 •

edited

Loading

codecov Bot commented Jul 10, 2026 •

edited by github-actions Bot

Loading

eVoloshchak commented Jul 15, 2026 •

edited

Loading