Skip to content

[No QA] Reduce unsafe type assertions in search, hook, and mention tests - #95643

Merged
blimpich merged 1 commit into
Expensify:mainfrom
KJ21-ENG:chore/94739-seatbelt-search-hook-tests
Jul 8, 2026
Merged

blimpich merged 1 commit into
Expensify:mainfrom
KJ21-ENG:chore/94739-seatbelt-search-hook-tests

Conversation

@KJ21-ENG

@KJ21-ENG KJ21-ENG commented Jul 8, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Reduced @typescript-eslint/no-unsafe-type-assertion violations in tests/unit/Search/getSpendOverTimeStateTest.ts, tests/unit/hooks/useSaveSortedReportIDs.test.ts, and tests/unit/MentionUtilsTest.ts as part of the cleanup for Expensify/App issue #94739.

What changed:

  • Replaced unsafe test fixture assertions in tests/unit/Search/getSpendOverTimeStateTest.ts with structurally typed SearchQueryJSON, SearchResults, and month-group fixtures.
  • Replaced broad TransactionListItemType[] casts in tests/unit/hooks/useSaveSortedReportIDs.test.ts with fixture items derived from the hook parameter type.
  • Replaced partial Report and TText assertions in tests/unit/MentionUtilsTest.ts with typed report collection helpers and real render-html text nodes.
  • Verified with writable lint that the generated target-rule rows for these files are removed from the seatbelt TSV.
  • The generated TSV diff is intentionally not included in this PR because Expensify/App post-merge OSBotify automation tightens the baseline on main.

Why this approach is safe:

  • Test-only change; no product/runtime behavior changed.
  • Existing test scenarios and assertions were preserved.
  • The new fixtures are typed against the code under test instead of hiding mismatches behind unsafe assertions.

Reviewer focus:

  1. Start with the three edited test files and confirm the fixture helpers are real typing/narrowing rather than hidden unsafe casts.
  2. Check the count evidence below and confirm writable lint locally removed the target-rule rows for the edited files.
  3. Check the commands below; no manual QA is expected for this test-only cleanup.

Safety checks:

  • No SEATBELT_INCREASE.
  • No new eslint-disable for @typescript-eslint/no-unsafe-type-assertion.
  • No broad as unknown as substitutions.
  • No generic unsafe helper that hides casts.

Fixed Issues

$ #94739
PROPOSAL:

Count change

Current baseline source:

  • config/eslint/eslint.seatbelt.tsv

Before:

  • tests/unit/MentionUtilsTest.ts: 4 violations
  • tests/unit/Search/getSpendOverTimeStateTest.ts: 2 violations
  • tests/unit/hooks/useSaveSortedReportIDs.test.ts: 3 violations
  • Current global target-rule baseline: 5,329 violations

After:

  • tests/unit/MentionUtilsTest.ts: 0 violations
  • tests/unit/Search/getSpendOverTimeStateTest.ts: 0 violations
  • tests/unit/hooks/useSaveSortedReportIDs.test.ts: 0 violations
  • Current global target-rule baseline: 5,320 violations

Net reduction:

  • 9 fewer @typescript-eslint/no-unsafe-type-assertion violations.

TSV evidence:

  • Writable lint locally removed the target-rule rows for all three edited files from
    config/eslint/eslint.seatbelt.tsv.
  • Generated with:
    CI=true npm run lint -- --no-cache --show-warnings tests/unit/Search/getSpendOverTimeStateTest.ts tests/unit/hooks/useSaveSortedReportIDs.test.ts tests/unit/MentionUtilsTest.ts
  • The generated config/eslint/eslint.seatbelt.tsv diff is intentionally not
    included in this PR because Expensify/App post-merge OSBotify automation
    tightens the baseline on main.

Tests

  1. Run:

    CI=true npm run lint -- --no-cache --show-warnings tests/unit/Search/getSpendOverTimeStateTest.ts tests/unit/hooks/useSaveSortedReportIDs.test.ts tests/unit/MentionUtilsTest.ts

    Verify lint passes with no target-rule warnings for the edited files.

  2. Verify config/eslint/eslint.seatbelt.tsv locally contains the decrement described
    above, then restore it before committing:

    git diff -- config/eslint/eslint.seatbelt.tsv
    git restore config/eslint/eslint.seatbelt.tsv
    git diff --exit-code -- config/eslint/eslint.seatbelt.tsv
  3. Run:

    npm test -- --runTestsByPath tests/unit/Search/getSpendOverTimeStateTest.ts tests/unit/hooks/useSaveSortedReportIDs.test.ts tests/unit/MentionUtilsTest.ts

    Verify the targeted test suites pass.

  4. Run:

    npm run typecheck

    Verify TypeScript checks pass.

Offline tests

Not applicable. This is test-only cleanup and does not change network behavior.

QA Steps

No QA required. This PR only changes tests. The ESLint seatbelt baseline is tightened by Expensify/App post-merge OSBotify automation.

PR Author Checklist

For checklist items that are not applicable to this test-only cleanup, checked
means the item was considered and determined not applicable.

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Not applicable. This is test-only cleanup.

Android: mWeb Chrome

Not applicable. This is test-only cleanup.

iOS: Native

Not applicable. This is test-only cleanup.

iOS: mWeb Safari

Not applicable. This is test-only cleanup.

MacOS: Chrome / Safari

Not applicable. This is test-only cleanup.

cc @blimpich

@blimpich
blimpich self-requested a review July 8, 2026 18:55
@KJ21-ENG
KJ21-ENG marked this pull request as ready for review July 8, 2026 18:59
@KJ21-ENG
KJ21-ENG requested a review from a team as a code owner July 8, 2026 18:59
@melvin-bot
melvin-bot Bot requested review from ChavdaSachin and removed request for a team July 8, 2026 18:59
@melvin-bot

melvin-bot Bot commented Jul 8, 2026

Copy link
Copy Markdown

@ChavdaSachin Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@blimpich
blimpich removed the request for review from ChavdaSachin July 8, 2026 20:55
@blimpich
blimpich merged commit 1fe99dc into Expensify:main Jul 8, 2026
35 of 36 checks passed
@OSBotify OSBotify mentioned this pull request Jul 9, 2026
94 tasks done
@OSBotify

OSBotify commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/blimpich in version: 9.4.32-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/grgia in version: 9.4.32-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants