Repository navigation
Part 1 - Fix review workspace settings onboarding task completion - #95766
robertjchen merged 7 commits into
Conversation
|
@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 56ce09dba7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@FitseTLT BE PRs are merged, can you please check again? |
…settings-onboarding-task-completion # Conflicts: # src/libs/actions/Policy/Policy.ts # src/pages/workspace/rules/RulesBillableDefaultPage.tsx # src/pages/workspace/upgrade/WorkspaceUpgradePage.tsx # src/pages/workspace/workflows/WorkspaceAutoReportingFrequencyPage.tsx # src/pages/workspace/workflows/WorkspaceAutoReportingMonthlyOffsetPage.tsx
|
@dukenv0307 what's the param name for the reportActionID that I will send to the BE? |
|
@FitseTLT It's |
|
@situchan pls review it ASAP before it gets caught up with conflicts. We will need to do it in parts some three prs still left after this. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d5bf839303
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
ReviewThe core design is sound: each save mints one optimistic 1. The avatar/actor refactor silently changes all auto-completed onboarding tasks — verify visually (medium)
This is arguably more correct (it matches what the backend attributes), and the code comment says as much — but it's a behavior change beyond this PR's stated scope, and the test steps don't cover it. Please confirm the auto-completed onboarding "marked as complete" actions still look right visually. Also note: if 2. No unit tests, but the checklist claims otherwise (medium)The diff adds no test file, yet "I added unit tests for any new feature or bug fix" is checked. This PR adds logic-heavy branching (the 3. Minor
Things I checked that are fine
Reply with |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 79074fac66
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafarisetPolicyBillableMode.movsetPolicyDefaultReportTitle.movsetPolicyMaxExpenseAge.movsetPolicyMaxExpenseAmount.movsetPolicyMaxExpenseAmountNoReceipt.movsetPolicyPreventMemberCreatedTitle.movsetWorkspaceAutoReportingFrequency.movsetWorkspaceAutoReportingMonthlyOffset.movupdateGeneralSettings.movupdateWorkspaceDescription.mov |
|
Tested all 10 suites and looks good. setPolicyBillableMode.movsetPolicyDefaultReportTitle.movsetPolicyMaxExpenseAge.movsetPolicyMaxExpenseAmount.movsetPolicyMaxExpenseAmountNoReceipt.movsetPolicyPreventMemberCreatedTitle.movsetWorkspaceAutoReportingFrequency.movsetWorkspaceAutoReportingMonthlyOffset.movupdateGeneralSettings.movupdateWorkspaceDescription.mov |
|
One issue I found is that "Task" action badge disappears optimistically even if "Create an expense" task is still remaining. setPolicyDefaultReportTitle.movThis also happens in production (when check off "Review your workspace settings" task item manually) so out of scope. Screen.Recording.2026-08-02.at.5.46.29.PM.mov |
Regression scan — no regressions found ✅I reviewed the diff and live-tested the modified save flows on web. This PR is well-isolated: for any user without a pending "Review your workspace settings" task, every touched code path collapses to a no-op, so existing behavior is unchanged. Live web test (dev NewDot): changed workspace Description, Name, Default currency, and Workflows report frequency — all saved and persisted correctly, no console/HTTP errors (all requests Why the common path is safe (code analysis)1. The no-task path is a true no-op. 2. The shared 3. One minor gap (not a regression — pre-existing edge case)In Note: I couldn't verify the actual task-completion flow (steps 1–6, 8–10) end-to-end because the shared web session isn't onboarded as a Next Steps: Reply with EvidenceOverview after Name/Description/Currency saves persistedWorkflows report frequency saved as WeeklyFinal Overview confirming Name, Description, Currency persistedRules gated behind Control-plan upgrade paywall (plan restriction, not a regression) |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 robertjchen has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/robertjchen in version: 9.4.49-0 🚀
|
|
🤖 Help site review: no changes required I reviewed the changes in this PR against Expensify's help site files under Why: This PR is an internal, optimistic-data fix. It adds client-side Onyx data so the "Review your workspace settings" onboarding task is marked complete instantly when an admin changes a workspace setting — behavior the backend already performs. There's no new feature, no changed UI label/tab/button, and no change to how any setting works or is saved. What I checked:
Because no help site content describes this behavior, there's nothing to add or correct, and I did not open a draft docs PR. If you believe a specific help article should document the onboarding checklist / "Review your workspace settings" task, let me know which one and I'll draft the update. |
|
🚀 Deployed to production by https://github.com/arosiclair in version: 9.4.49-3 🚀
Bundle Size Analysis (Sentry): |




Explanation of Change
This PR adds the optimistic Onyx data that completes the "Review your workspace settings" onboarding task when a workspace setting is changed. The backend already completes the task when it processes these commands, so the client only mirrors that completion optimistically — no
CompleteTaskrequest is sent.Wired for 10 workspace-settings commands:
UPDATE_WORKSPACE_DESCRIPTIONUPDATE_WORKSPACE_GENERAL_SETTINGSSET_WORKSPACE_AUTO_REPORTING_FREQUENCYSET_WORKSPACE_AUTO_REPORTING_MONTHLY_OFFSETSET_POLICY_EXPENSE_MAX_AGESET_POLICY_EXPENSE_MAX_AMOUNTSET_POLICY_EXPENSE_MAX_AMOUNT_NO_RECEIPTSET_POLICY_BILLABLE_MODESET_POLICY_DEFAULT_REPORT_TITLESET_POLICY_PREVENT_MEMBER_CREATED_TITLEFixed Issues
$ #67648
PROPOSAL: #67648 (comment)
Tests
Precondition: sign in with an account onboarded as
newDotAdmin(invited to a workspace as an admin) so the "Review your workspace settings" task exists in the onboarding/Concierge chat.UpdateWorkspaceDescription) — there must be noCompleteTaskrequest.Overview → Name; Overview → Currency; Workflows → Report frequency; Workflows → Monthly offset; Rules → Max expense age; Rules → Max expense amount; Rules → Receipt required amount; Rules → Require receipts; Rules → Billable default; Reports → Default title; Reports → Enforce title toggle.
newDotManageTeam). Change a workspace setting and verify the setting saves normally and no task-completed action is created.CompleteTask: complete a task from the task header/preview, finish the Test Drive task, and create a workspace category/tag during onboarding. Verify each still completes and still sends itsCompleteTaskrequest.Offline tests
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
2026-07-28.18-11-41.mp4