Repository navigation
Revert "Merge pull request #92484 from software-mansion-labs/war-in/upgrade-to-rn-0.85" - #96015
jasperhuangg wants to merge 1 commit into
Conversation
…pgrade-to-rn-0.85" This reverts commit 3e5238b, reversing changes made to be7b63c060e93b598cc6e1908019cc99e39c17d5. package.json and package-lock.json required manual conflict resolution to keep dependency changes from later, unrelated PRs (expensify-common 2.0.191, webpack 5.108.4, babel-plugin-react-compiler bump, removal of @pmmmwh/react-refresh-webpack-plugin) while reverting only the RN 0.85 upgrade itself (React Native, Expo family, React, hermes-compiler, @react-native-community/cli, related patches).
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 72f474dfbb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (shouldIgnoreKey(nodeType)) continue; | ||
| if (!TYPES.includes(nodeType)) { | ||
| throw new Error(`You gave us a visitor for the node type ${nodeType} but it's not a valid type in @babel/traverse ${"7.29.7"}`); | ||
| throw new Error(`You gave us a visitor for the node type ${nodeType} but it's not a valid type in @babel/traverse ${"7.29.0"}`); |
There was a problem hiding this comment.
Rebuild the bundled author checklist action
When validateGithubActions.yml runs, it calls .github/scripts/verifyActions.sh, which rebuilds the JS action bundles and fails if git diff is non-empty. This bundled file was reverted to @babel/traverse 7.29.0, but package-lock.json still resolves node_modules/@babel/traverse to 7.29.7, so a clean npm run gh-actions-build will rewrite this bundle back to 7.29.7 and block the workflow until the generated index.js is regenerated from the current lockfile.
Useful? React with 👍 / 👎.
Explanation of Change
This reverts #92484 (upgrade to React Native 0.85), taking React Native, Expo, and React back to their pre-upgrade versions.
The GitHub "Revert" button couldn't do this automatically because
package.jsonandpackage-lock.jsonpicked up unrelated dependency changes from other PRs merged after #92484 (expensify-common bump, webpack bump, babel-plugin-react-compiler bump, removal of@pmmmwh/react-refresh-webpack-plugin). This PR was built by hand-reverting only the RN 0.85 upgrade in those two files while keeping the unrelated later changes intact, everything else (native config, patches, source files) reverted cleanly.What changed:
react-native0.85.3 -> 0.83.1,react/react-dom19.2.3 -> 19.2.0,hermes-compilerback to250829098.0.4expo,expo-asset,expo-audio,expo-font,expo-image,expo-image-manipulator,expo-location,expo-modules-core,expo-store-review,expo-task-manager,expo-video,expo-web-browser) back to their pre-Upgrade React Native to 0.85.3 #92484 versions@react-native-community/cli*,@react-native/babel-preset,@react-native/metro-configback to 20.0.0 / 0.83.1react-native/expo patch files, native config (metro.config.js,babel.config.js,ios/Podfile, gradle wrappers), and the touched source files (FullscreenLoadingIndicator.tsx,LoadingIndicator.tsx,RenderHTML.tsx,SAMLLoadingIndicator.tsx,BaseHTMLEngineProvider.tsx,TextCommentFragment.tsx,src/styles/index.ts)Fixed Issues
$
PROPOSAL:
Tests
bun install(ornpm install).react-nativeresolves to0.83.1andexpoto55.0.25innode_modules.Offline tests
Same as Tests, this is a dependency revert with no offline-specific behavior change.
QA Steps
Same as Tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari