Skip to content

Revert "Merge pull request #92484 from software-mansion-labs/war-in/upgrade-to-rn-0.85" - #96015

Closed
jasperhuangg wants to merge 1 commit into
mainfrom
revert-92484-rn085
Closed

jasperhuangg wants to merge 1 commit into
mainfrom
revert-92484-rn085

Conversation

@jasperhuangg

Copy link
Copy Markdown
Contributor

Explanation of Change

This reverts #92484 (upgrade to React Native 0.85), taking React Native, Expo, and React back to their pre-upgrade versions.

The GitHub "Revert" button couldn't do this automatically because package.json and package-lock.json picked up unrelated dependency changes from other PRs merged after #92484 (expensify-common bump, webpack bump, babel-plugin-react-compiler bump, removal of @pmmmwh/react-refresh-webpack-plugin). This PR was built by hand-reverting only the RN 0.85 upgrade in those two files while keeping the unrelated later changes intact, everything else (native config, patches, source files) reverted cleanly.

What changed:

  • react-native 0.85.3 -> 0.83.1, react/react-dom 19.2.3 -> 19.2.0, hermes-compiler back to 250829098.0.4
  • Expo family (expo, expo-asset, expo-audio, expo-font, expo-image, expo-image-manipulator, expo-location, expo-modules-core, expo-store-review, expo-task-manager, expo-video, expo-web-browser) back to their pre-Upgrade React Native to 0.85.3 #92484 versions
  • @react-native-community/cli*, @react-native/babel-preset, @react-native/metro-config back to 20.0.0 / 0.83.1
  • Restored the pre-upgrade react-native/expo patch files, native config (metro.config.js, babel.config.js, ios/Podfile, gradle wrappers), and the touched source files (FullscreenLoadingIndicator.tsx, LoadingIndicator.tsx, RenderHTML.tsx, SAMLLoadingIndicator.tsx, BaseHTMLEngineProvider.tsx, TextCommentFragment.tsx, src/styles/index.ts)
  • Kept unrelated dependency updates from later PRs: expensify-common 2.0.191, webpack ^5.108.4, babel-plugin-react-compiler bump, removal of the unused webpack refresh plugin

Fixed Issues

$
PROPOSAL:

Tests

  1. Pull this branch and run bun install (or npm install).
  2. Confirm react-native resolves to 0.83.1 and expo to 55.0.25 in node_modules.
  3. Build and launch the app on each platform.
  4. Verify the app boots normally and core flows (login, open a report, send a message) work with no regressions.
  • Verify that no errors appear in the JS console

Offline tests

Same as Tests, this is a dependency revert with no offline-specific behavior change.

QA Steps

Same as Tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

…pgrade-to-rn-0.85"

This reverts commit 3e5238b, reversing
changes made to be7b63c060e93b598cc6e1908019cc99e39c17d5.

package.json and package-lock.json required manual conflict resolution
to keep dependency changes from later, unrelated PRs (expensify-common
2.0.191, webpack 5.108.4, babel-plugin-react-compiler bump, removal of
@pmmmwh/react-refresh-webpack-plugin) while reverting only the RN 0.85
upgrade itself (React Native, Expo family, React, hermes-compiler,
@react-native-community/cli, related patches).
@jasperhuangg
jasperhuangg requested review from a team as code owners July 14, 2026 01:30
@melvin-bot
melvin-bot Bot requested review from inimaga and trjExpensify and removed request for a team July 14, 2026 01:30
@melvin-bot

melvin-bot Bot commented Jul 14, 2026

Copy link
Copy Markdown

@inimaga Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@codecov

codecov Bot commented Jul 14, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/components/FullscreenLoadingIndicator.tsx 100.00% <100.00%> (ø)
src/components/LoadingIndicator.tsx 100.00% <100.00%> (ø)
src/components/RenderHTML.tsx 95.00% <100.00%> (-0.24%) ⬇️
...pages/inbox/report/comment/TextCommentFragment.tsx 79.16% <100.00%> (-1.23%) ⬇️
src/styles/index.ts 60.30% <ø> (ø)
src/components/SAMLLoadingIndicator.tsx 0.00% <0.00%> (ø)
...ents/HTMLEngineProvider/BaseHTMLEngineProvider.tsx 81.69% <79.31%> (ø)
... and 16 files with indirect coverage changes

@jasperhuangg

Copy link
Copy Markdown
Contributor Author

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 72f474dfbb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

if (shouldIgnoreKey(nodeType)) continue;
if (!TYPES.includes(nodeType)) {
throw new Error(`You gave us a visitor for the node type ${nodeType} but it's not a valid type in @babel/traverse ${"7.29.7"}`);
throw new Error(`You gave us a visitor for the node type ${nodeType} but it's not a valid type in @babel/traverse ${"7.29.0"}`);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Rebuild the bundled author checklist action

When validateGithubActions.yml runs, it calls .github/scripts/verifyActions.sh, which rebuilds the JS action bundles and fails if git diff is non-empty. This bundled file was reverted to @babel/traverse 7.29.0, but package-lock.json still resolves node_modules/@babel/traverse to 7.29.7, so a clean npm run gh-actions-build will rewrite this bundle back to 7.29.7 and block the workflow until the generated index.js is regenerated from the current lockfile.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant