Repository navigation
[Part 13] Remove Onyx.connect from LocalePhoneNumber - #96192
danieldoglas merged 14 commits into
Conversation
|
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@marufsharifi Bump here |
|
@shubham1206agra, sorry for the delay. I will finalize this asap. thanks. |
|
PR doesn’t need product input as a refactor PR. Unassigning and unsubscribing myself. |
|
@marufsharifi Bump here again |
|
@shubham1206agra Sorry for the delay. This PR is ready for another review. All requested feedback has been addressed, and the required actions/checks are passing. Please take another look when you get a chance. |
|
Hi @shubham1206agra, apologies for the delay. I wasn't feeling well yesterday. I've now addressed the feedback, updated the PR, and it's ready for another review. Whenever you have a chance, could you please take another look? Thank you! |
|
@shubham1206agra, Gentle bump. thanks. |
|
@shubham1206agra, bump again. thanks. |
Reviewer Checklist
Screenshots/VideosScreen.Recording.2026-07-21.at.7.59.26.PM.movScreen.Recording.2026-07-21.at.8.03.02.PM.mov |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 danieldoglas has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/danieldoglas in version: 9.4.42-0 🚀
|
|
🤖 No help site changes required. This PR is an internal refactor tied to Expensify/App#66327 — removing There is no user-facing behavior change: no new or renamed features, tabs, settings, buttons, or workflows. All changes are to If a specific user-facing behavior did change that I missed, reply with the details and I'll draft the corresponding help site update. |
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.4.42-1 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
This PR threads the active
formatPhoneNumberfunction fromuseLocalize()through the IOU split, split distance, split scan, complete split, and duplicate expense/report flows.The main behavior change is that
Split.tsno longer owns/imports its own phone formatter for optimistic participant personal details. Instead, callers pass the current locale-aware formatter into:splitBillsplitBillAndOpenReportstartSplitBillcompleteSplitBillcreateSplitsAndOnyxDatacreateDistanceRequestduplicateExpenseTransactionduplicateReportbulkDuplicateExpensesbulkDuplicateReportsThe added callers cover manual split submit, scan skip-confirmation split submit, distance manual/GPS/odometer submit, completing split details, single duplicate actions, and bulk duplicate actions from Search.
Fixed Issues
$ #66327
PROPOSAL:
Tests
Offline tests
QA Steps
Case 1: Manual Split From Existing Chat Or Room
+.Split expense.Manual.Case 2: Complete Split Details After Scan
Case 3: Distance Split From Existing Chat Or Room
+.Split expense.Distance.Case 4: Duplicate Single Expense From Expense Details
Duplicate expense.Case 5: Duplicate Full Report
Duplicate report.Case 6: Bulk Duplicate Reports From Search
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Case 1: Manual Split From Existing Chat Or Room
Screencast.From.2026-07-17.20-00-34.webm
Case 2: Complete Split Details After Scan
Screencast.From.2026-07-17.20-05-08.webm
Case 3: Distance Split From Existing Chat Or Room
Screencast.From.2026-07-17.20-06-02.webm
Case 4: Duplicate Single Expense From Expense Details
Screencast.From.2026-07-17.20-12-02.webm
Case 5: Duplicate Full Report
Screencast.From.2026-07-17.20-15-02.webm
Case 6: Bulk Duplicate Reports From Search
Screencast.From.2026-07-17.20-16-18.webm