Repository navigation
Migrate outstanding report archived checks #96244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
blimpich
merged 6 commits into
Expensify:main
from
ShridharGoel:refactor/66422-outstanding-report-callers
Aug 11, 2026
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
897af82
refactor: pass NVPs to outstanding report checks
ShridharGoel bfd0e14
refactor: pass single NVP to report check
ShridharGoel 62a020e
refactor: require report NVP entry
ShridharGoel 26d3c47
Merge branch 'main' of github.com:Expensify/App into refactor/66422-o…
ShridharGoel 9b69721
Merge main into refactor/66422-outstanding-report-callers
ShridharGoel f031453
Merge branch 'main' into refactor/66422-outstanding-report-callers
ShridharGoel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When an archived transaction report is passed in from submit/share flows without a
routeReport, the archive check here is ignored:isReportOutstanding(..., reportNameValuePair, false)returns false, but the next line still makesshouldUseTransactionReporttrue because!routeReport. That means these flows can still submit to the archived report instead of forcing a new/open report, which undermines the new archived-report rejection this helper is now responsible for.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MelvinBot It seems this problem was already happening before our change. Could you verify again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right — this pre-dates the PR. ✅
The behavior codex flagged is driven entirely by the
|| !routeReportclause inshouldUseTransactionReport, and that line is unchanged by this PR. It's byte-for-byte identical onmain:The only change this PR makes to
resolveReportForMoneyRequestis passingreportNameValuePairintoisReportOutstandinginstead ofundefined— i.e. it only affectscanUseTransactionReport. When there's norouteReport,shouldUseTransactionReportshort-circuits totrueregardless ofcanUseTransactionReport, so an archived transaction report would be returned in that path both before and after this change. So codex's concern isn't a regression introduced here.Two things worth noting:
canUseTransactionReportmore reliable at rejecting archived reports (explicit NVPs vs. the oldOnyx.connect()fallback) — it just doesn't change the!routeReportoverride.Evidence
edc4aad):IOUUtils.ts:5669b69721):IOUUtils.ts:569shouldUseTransactionReportline as unchanged context; the only edited part of this function isisReportOutstanding(..., undefined, false)→isReportOutstanding(..., reportNameValuePair, false).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-verified — the conclusion holds: this is pre-existing, not introduced by this PR. ✅
The
shouldUseTransactionReport = !!transactionReport && (canUseTransactionReport || !routeReport)line codex flags is byte-for-byte identical onmain(before,edc4aadL566 vs. after,9b69721L569). This PR's only edit toresolveReportForMoneyRequestisisReportOutstanding(..., undefined, false)→isReportOutstanding(..., reportNameValuePair, false), which touches onlycanUseTransactionReport— not the!routeReportoverride.I also checked the two callers to see if codex's scenario (archived
transactionReport+ missingrouteReport) is actually reachable:IOURequestStepConfirmation.tsx:189passesrouteReport: reportWithDraftFallback(reportReal ?? reportDraft).SubmitDetailsPage.tsx:265passesrouteReport: report.In the normal flow
routeReportis populated, so the!routeReportbranch only fires in the fallback case — and that behavior is identical tomain. So there's no regression here to block on. If we want to stop the archived report from being reused even in the no-route-report fallback, that's a separate, pre-existing improvement best done as a follow-up rather than in this refactor.