Skip to content

Add search bar to Rillet pages - #96528

Merged
lakchote merged 14 commits into
Expensify:mainfrom
s77rt:rillet-search
Jul 23, 2026
Merged

lakchote merged 14 commits into
Expensify:mainfrom
s77rt:rillet-search

Conversation

@s77rt

@s77rt s77rt commented Jul 20, 2026

Copy link
Copy Markdown
Member

Explanation of Change

Added search bar to Rillet pages

Fixed Issues

$ #95018
PROPOSAL:

Tests

  • Have a workspace with Rillet connection
  1. Go to Workspace > Accounting > Export > Company card account
  2. Verify that a search bar is displayed if the number of items is >= 12
  3. Go to Advanced > Bill payment account
  4. Verify that a search bar is displayed if the number of items is >= 12
  5. Type something in the search bar
  6. Verify only the items containing the search term are displayed
Screen.Recording.2026-07-20.at.10.28.06.PM.mov
  • Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Same as Tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@codecov

codecov Bot commented Jul 20, 2026 •

Copy link
Copy Markdown

@s77rt
s77rt marked this pull request as ready for review July 20, 2026 21:47
@s77rt
s77rt requested review from a team as code owners July 20, 2026 21:47
@melvin-bot
melvin-bot Bot requested review from heyjennahay and truph01 July 20, 2026 21:47
@melvin-bot

melvin-bot Bot commented Jul 20, 2026

Copy link
Copy Markdown

@truph01 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@lakchote

Copy link
Copy Markdown
Contributor

@truph01 can you prioritize the review of this one please? let's aim to close this project soon

@s77rt please solve conflicts

thanks!

@lakchote
lakchote self-requested a review July 22, 2026 05:22
@truph01

truph01 commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2f64677fa1

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@truph01

truph01 commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained """"why"""" the code was doing something instead of only explaining """"what"""" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screen.Recording.2026-07-22.at.16.01.33.mov
Android: mWeb Chrome
iOS: HybridApp
Screen.Recording.2026-07-22.at.16.00.34.mov
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-07-22.at.15.55.23.mov

@truph01

truph01 commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot The logic introduced in this PR is quite similar across multiple pages. Could we consider extracting it into a shared hook to reduce duplication and make it easier to maintain?

@MelvinBot

Copy link
Copy Markdown
Contributor

Agreed — this is a good candidate for extraction. All 7 Rillet pages repeat the exact same three-line block, differing only in the item type:

const filterData = (item, searchInput) => tokenizedSearch([item], searchInput, () => [item.text ?? '', item.value]).length > 0;
const [searchValue, setSearchValue, filteredData] = useSearchResults(data, filterData);
const textInputOptions = {
    label: data.length >= CONST.STANDARD_LIST_ITEM_LIMIT ? translate('common.search') : undefined,
    value: searchValue,
    onChangeText: setSearchValue,
};

Since every page's list item is ListItem & {value} and searches on the same text/value keys, this can collapse into one generic hook wrapping useSearchResults:

function useSelectionListSearch<T extends ListItem & {value: string}>(data: T[]) {
    const {translate} = useLocalize();
    const filterData = useCallback((item: T, searchInput: string) => tokenizedSearch([item], searchInput, () => [item.text ?? '', item.value]).length > 0, []);
    const [searchValue, setSearchValue, filteredData] = useSearchResults(data, filterData);
    const textInputOptions = {
        label: data.length >= CONST.STANDARD_LIST_ITEM_LIMIT ? translate('common.search') : undefined,
        value: searchValue,
        onChangeText: setSearchValue,
    };
    return {filteredData, textInputOptions};
}

Each page then becomes one line:

const {filteredData, textInputOptions} = useSelectionListSearch(data);
// ...
data={filteredData}
textInputOptions={textInputOptions}

That removes ~6 duplicated lines from each of the 7 files and keeps the STANDARD_LIST_ITEM_LIMIT label logic in a single place.

Two things to decide when doing it:

  • Scope/location — if this search-over-a-SelectionScreen pattern is Rillet-specific, src/pages/workspace/accounting/rillet/ is fine; if other accounting connections (NetSuite/QBO/Xero) will want the same, a shared src/hooks/ home makes more sense.
  • value typing — the subsidiary selector types value as RilletSubsidiary['id'] and the others as account code/id. As long as they're all strings, T extends ListItem & {value: string} covers every current call site.

@truph01

truph01 commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

@s77rt Could you check the above suggestion?

@s77rt

s77rt commented Jul 23, 2026 •

Copy link
Copy Markdown
Member Author

Good call! Updated!

@truph01

truph01 commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

@truph01

truph01 commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c19208a88f

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/hooks/useSelectionListSearch.ts Resolved
@s77rt

s77rt commented Jul 23, 2026

Copy link
Copy Markdown
Member Author

Should be fixed now

@s77rt s77rt mentioned this pull request Jul 23, 2026
40 tasks done

@lakchote lakchote left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lakchote
lakchote merged commit a4b6ddf into Expensify:main Jul 23, 2026
38 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 lakchote has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Jul 23, 2026
51 tasks done
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/lakchote in version: 9.4.44-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 I reviewed the changes in this PR against Expensify's help site files under App/docs/articles.

No help site changes are required.

This PR adds a search bar to the Rillet accounting selector pages (Company card account, Bill payment account, etc.), appearing when a list has ≥ 12 items. This is a standard in-app usability enhancement to existing selection lists — it doesn't change any documented feature, workflow, or user-facing behavior that the help site describes.

I searched App/docs/articles for Rillet coverage and found no public-facing article about Rillet setup or its selector pages. The only reference is in an internal, unlisted AgentZero doc (Unlisted/Upcoming-Integrations-And-Accounting.md), which is explicitly not for public search indexing and describes the integration at a high level, not individual selector UI. Search bars that appear based on list length are a shared, undocumented UI convention across the app, so there's nothing to add or update.

Given that, I did not create a draft docs PR. If you'd like a docs update anyway (e.g., you expect a public Rillet setup article to be authored soon that should mention this), let me know and I'll draft one.

@s77rt, please confirm you agree no help site changes are needed here.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/marcaaron in version: 9.4.44-6 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants