Repository navigation
fix: iOS Share to Expensify screen does not close when swiping back - #96581
Conversation
|
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
Pull request overview
Fixes an iOS-only navigation regression in the native Share extension flow by ensuring the “Share to Expensify” modal can be dismissed with the back-swipe gesture, aligning behavior with expected iOS UX and the linked issue.
Changes:
- Enables
gestureEnabledfor theSHARE_MODAL_NAVIGATORscreen so the swipe-back gesture dismisses the Share modal on iOS. - Keeps existing full-screen modal configuration (no animation, full-height web styling) while adding gesture support specifically for the Share modal.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Reviewer Checklist
Screenshots/VideosScreen.Recording.2026-07-23.at.10.14.51.AM.movScreen.Recording.2026-07-23.at.10.32.54.AM.mov |
|
🚧 chuckdries has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/chuckdries in version: 9.4.44-0 🚀
|
|
🤖 I reviewed the changes in this PR and no help site updates are required. Why: This is an iOS-specific behavioral bug fix. The only change adds I searched Since there's nothing to document, I did not open a draft docs PR. @samranahm, please confirm you agree no help site changes are needed here. If you'd like me to document the Share to Expensify flow anyway, reply and I'll draft a docs PR. |
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.4.44-6 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Fixed Issues
$ #94908
PROPOSAL: #94908 (comment)
Tests
Offline tests
Same as test
QA Steps
Same as test
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android.Native.mp4
Android: mWeb Chrome
N/A Share sheet is native-only
iOS: Native
IOS.Native.mp4
iOS: mWeb Safari
N/A Share sheet is native-only
MacOS: Chrome / Safari
N/A Share sheet is native-only