Repository navigation
Allow payments admin to update workspace payer - #96662
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
🚧 flodnv has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/flodnv in version: 9.4.43-0 🚀
|
|
🤖 No help site changes required. This PR is a bug fix that brings the code in line with what the help site already documents. It lets a Payments Admin share the workspace bank account when setting/changing the Payer, by adding a The relevant articles already state that Payments Admins have this capability, so they remain accurate:
Since the documented behavior already matches the fixed behavior, there's nothing to add or correct, so I did not open a draft docs PR. @ShridharGoel, please confirm you agree no help site update is needed. If you think an article should call out the Payer-change flow specifically, let me know and I'll draft a PR. |
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.4.43-1 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Payments admins could open the payer page, but the bank account sharing check only allowed workspace owners or existing sharees. This change also allows members with
WORKFLOWS_PAYMENTSwrite access to share the workspace bank account. Payments admins can now change the payer back to themselves after selecting the workspace owner.Fixed Issues
$ #95625
PROPOSAL:
Tests
Offline tests
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avatar, I verified thatAvataris working as expected)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
MacOS: Chrome / Safari
Screen.Recording.2026-07-21.at.9.58.41.PM.mov