Skip to content

Allow payments admin to update workspace payer - #96662

Merged
flodnv merged 2 commits into
Expensify:mainfrom
ShridharGoel:fix/payments-admin-payer-access
Jul 22, 2026
Merged

flodnv merged 2 commits into
Expensify:mainfrom
ShridharGoel:fix/payments-admin-payer-access

Conversation

@ShridharGoel

@ShridharGoel ShridharGoel commented Jul 21, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Payments admins could open the payer page, but the bank account sharing check only allowed workspace owners or existing sharees. This change also allows members with WORKFLOWS_PAYMENTS write access to share the workspace bank account. Payments admins can now change the payer back to themselves after selecting the workspace owner.

Fixed Issues

$ #95625
PROPOSAL:

Tests

  1. Create a Control workspace.
  2. Invite another user and assign them the Payments Admin role.
  3. Sign in as the Payments Admin.
  4. Go to Workspace settings > Workflows and add a bank account.
  5. Open Payer, select the workspace owner, and save.
  6. Open Payer again, select the Payments Admin, and save.
  7. Verify the payer changes to the Payments Admin without showing the bank account access error.
  • Verify that no errors appear in the JS console

Offline tests

  1. Repeat the test steps through selecting the Payments Admin as payer.
  2. Go offline before saving.
  3. Save, reconnect, and verify the payer update completes without showing the bank account access error.

QA Steps

Same as tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (for example, StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar, I verified that Avatar is working as expected)
  • If the PR modifies a component related to any of the existing Storybook stories, I verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

MacOS: Chrome / Safari
Screen.Recording.2026-07-21.at.9.58.41.PM.mov

@ShridharGoel
ShridharGoel marked this pull request as ready for review July 21, 2026 16:29
@ShridharGoel
ShridharGoel requested review from a team as code owners July 21, 2026 16:29
@melvin-bot
melvin-bot Bot requested review from Pujan92 and joekaufmanexpensify and removed request for a team and joekaufmanexpensify July 21, 2026 16:29
@melvin-bot

melvin-bot Bot commented Jul 21, 2026

Copy link
Copy Markdown

@Pujan92 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@ShridharGoel
ShridharGoel requested a review from flodnv July 21, 2026 16:29
@codecov

codecov Bot commented Jul 21, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
...orkspace/workflows/WorkspaceWorkflowsPayerPage.tsx 62.50% <0.00%> (-0.42%) ⬇️
... and 10 files with indirect coverage changes

@flodnv
flodnv merged commit bd9d219 into Expensify:main Jul 22, 2026
38 of 39 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 flodnv has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Jul 22, 2026
52 tasks done
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/flodnv in version: 9.4.43-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 No help site changes required.

This PR is a bug fix that brings the code in line with what the help site already documents. It lets a Payments Admin share the workspace bank account when setting/changing the Payer, by adding a WORKFLOWS_PAYMENTS write-access check to the share gate in WorkspaceWorkflowsPayerPage.tsx. No user-facing feature, label, or flow was added or renamed.

The relevant articles already state that Payments Admins have this capability, so they remain accurate:

Since the documented behavior already matches the fixed behavior, there's nothing to add or correct, so I did not open a draft docs PR.

@ShridharGoel, please confirm you agree no help site update is needed. If you think an article should call out the Payer-change flow specifically, let me know and I'll draft a PR.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.4.43-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants