Repository navigation
Fix empty view shows briefly when sorting - #96700
Conversation
|
@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f36d909764
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@bernhardoj were you able to report a bug for this: |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppios.moviOS: mWeb SafariMacOS: Chrome / Safariweb.mov |
|
@JS00001 I haven't reported it yet. We need this PR first to fix the empty view so the QA can reproduce that easier. (If we don't fix this empty view bug yet, QA can still reproduce it, but just with an extra step; they need to at least perform the same sort more than once) |
|
🚧 JS00001 has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/JS00001 in version: 9.4.44-0 🚀
|
Help site review — no docs changes requiredI reviewed the changes in this PR against the help site content under Conclusion: No help site updates are required. This is an internal bug fix that stops the empty state from flashing briefly while sorting the Spend / Search table. The change reworks how
There is no new feature, no user-facing UI text, no setting/label/button, and no workflow change — nothing that the help site documents. The help articles describe what Spend/Search does, not the transient loading behavior this fix polishes, so there's nothing to add or correct. Because no changes are required, I did not open a draft docs PR. @bernhardoj, please confirm you agree the current help site content already reflects this behavior and that no docs update is needed. If you think an article should be updated, let me know and I'll open a draft help site PR. |
Issues attributed to commits in this pull requestThis pull request was merged and Sentry observed the following issues:
|
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.4.44-6 🚀
Bundle Size Analysis (Sentry): |

Explanation of Change
Fixed Issues
$ #96074
PROPOSAL: #96074 (comment)
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
Web only
Prerequisite: have some expenses
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
web.mp4