Repository navigation
Reset stale tab title to "New Expensify" on logout #96916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
fdd3461
Reset stale tab title on logout via race-safe useDocumentTitle cleanup
MelvinBot 1eb9001
Switch to signed-out root screen approach: reset tab title via useDoc…
MelvinBot f63d144
Scope tab title reset to public root sign-in screen, not SignInModal
MelvinBot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When an anonymous user is viewing an anonymous-accessible report and clicks Sign in,
signOutAndRedirectToSignIn()opensROUTES.SIGN_IN_MODAL, andSignInModalrenders this sameSignInPagecomponent. SinceuseDocumentTitle('')runs from the focused modal too, it clears the report’s document title back toCONFIG.SITE_TITLEeven though the user has not landed on the signed-out root screen. Please gate this reset to the public root sign-in route or keep it out of the reusable modal instance.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if it's an issue but @MelvinBot let’s implement it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch — implemented in f63d144. This is a real issue:
SignInModalrenders this sameSignInPagecomponent, souseDocumentTitle('')fired from the modal too and would clear the underlying anonymous-accessible report's tab title.Rather than reintroduce route-name coupling, I gated the reset behind an explicit prop:
shouldResetTabTitleprop toSignInPage(defaults totrue), and moved theuseDocumentTitle('')call into a tinyResetTabTitleOnFocuschild that only mounts when the prop istrue. Threaded the prop throughSignInPageWrapperand theWithThemeHOC.SignInModalnow passesshouldResetTabTitle={false}, so the reusable modal instance never touches the title.PublicScreens) renders the default export with no prop, so it keeps resetting to "New Expensify" on logout as intended.Local checks:
oxfmt, ESLint (0 errors),tsctypecheck (clean; the oneBaseGenericTooltipTS2590error is pre-existing and unrelated), React Compiler compliance, and thePublicSignInPageRootUrlTest+SessionTestsuites all pass.