Repository navigation
Read Consolidated Travel Billing settings from the resolved fund - #96943
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5e27956618
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@rlinoz @blimpich I'm OoO tomorrow, in case we're able to deploy web-e PR please feel free review this PR as well , the jest test is failing on main https://expensify.slack.com/archives/C01GTK53T8Q/p1786615752269259, I'll try to be back online later tonight and merge main in case the fix gets pushed, thanks ! |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
Merge conflicts 😢. I think I caused these, so apologies! |
|
no worries 😄 |
|
WIll wait for the Web-E PR to hit staging before removing hold from the title |
# Conflicts: # src/libs/API/parameters/PayTravelInvoicingSpendParams.ts # src/libs/actions/TravelBilling.ts # src/pages/workspace/travel/WorkspaceTravelBillingMonthlyLimitPage.tsx # src/pages/workspace/travel/WorkspaceTravelBillingSection.tsx # src/pages/workspace/travel/WorkspaceTravelBillingSettlementAccountPage.tsx # src/pages/workspace/travel/WorkspaceTravelBillingSettlementFrequencyPage.tsx
|
@rlinoz lets merge this 💪 |
There was a problem hiding this comment.
Looks good, does this have to be internal QA @allgandalf ?
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
🚧 rlinoz has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/rlinoz in version: 9.4.58-0 🚀
|
No help site changes requiredI reviewed this PR against the help articles under Why: This is a purely internal data-source refactor. It swaps the Onyx key the workspace Travel settings read from — None of this changes anything a customer sees or does:
I checked the three existing CTB articles and confirmed none describe the underlying feed/account plumbing that this PR touches:
@allgandalf, since there are no user-facing changes here, there's no help site PR to review. If you believe the shift to feed-wide (domain-shared) travel spend/limit is worth calling out for customers with domain-shared feeds, let me know and I'll draft the docs update. |
|
@rlinoz @blimpich @allgandalf We can validate this PR with an Expensifail account up to Step 9. I’m not sure how we can validate Step 10 with our available accounts. |
|
Yeah, I don't think we can, we would need a private domain that doesn't have a domain yet. |
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.4.58-4 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
App side of moving Consolidated Travel Billing onto the universal-feed rails. The workspace Travel settings now read the card settings from the resolved fund (via
useDefaultFundID) instead of the workspace account, so a feed shared on the domain shows feed-wide travel spend and limit, and a workspace-scoped feed still works through the fallback. Draft, part of the multi-PR effort with Auth https://github.com/Expensify/Auth/pull/23192 and Web-E https://github.com/Expensify/Web-Expensify/pull/54821.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/662524
PROPOSAL:
Tests
Testing needs an admin whose primary login is on a verified private domain that has a settlement (business) bank account.
workspaceAccountIDfallback.Offline tests
With the network off, perform steps 4-6 and confirm each change is applied optimistically to the feed shown in the section, then re-enable the network and confirm it persists.
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as Tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari