Skip to content
Merged
13 changes: 7 additions & 6 deletions src/CONST/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -174,15 +174,16 @@ const onboardingInviteTypes = {

const onboardingCompanySize = {
MICRO_SMALL: '1-4',
MICRO_MEDIUM: '5-10',

// This range is deprecated in favor of the smaller ranges above, but the constant is kept to compare against saved data for backwards compatibility.
MICRO: '1-10',

SMALL: '11-50',
MICRO_MEDIUM: '5-9',
Comment thread
ShridharGoel marked this conversation as resolved.
Resolved
SMALL: '10-50',
MEDIUM_SMALL: '51-100',
MEDIUM: '101-1000',
LARGE: '1001+',

// These ranges are deprecated, but the constants are kept to compare against saved data for backwards compatibility.
LEGACY_MICRO_MEDIUM: '5-10',
LEGACY_MICRO: '1-10',
LEGACY_SMALL: '11-50',
} as const;

const onboardingPersonalTrackGoals = {
Expand Down
3 changes: 2 additions & 1 deletion src/components/SidePanel/RHPVariantTest/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@ const shouldOpenRHPVariant: ShouldOpenRHPVariant = (variantOverride) => {
const isMicroCompany =
onboardingCompanySize === CONST.ONBOARDING_COMPANY_SIZE.MICRO_SMALL ||
onboardingCompanySize === CONST.ONBOARDING_COMPANY_SIZE.MICRO_MEDIUM ||
onboardingCompanySize === CONST.ONBOARDING_COMPANY_SIZE.MICRO;
onboardingCompanySize === CONST.ONBOARDING_COMPANY_SIZE.LEGACY_MICRO_MEDIUM ||
onboardingCompanySize === CONST.ONBOARDING_COMPANY_SIZE.LEGACY_MICRO;
const isRHPConciergeDM = variant === CONST.ONBOARDING_RHP_VARIANT.RHP_CONCIERGE_DM;
const isRHPAdminsRoom = variant === CONST.ONBOARDING_RHP_VARIANT.RHP_ADMINS_ROOM;
const isRHPHomePage = variant === CONST.ONBOARDING_RHP_VARIANT.RHP_HOME_PAGE;
Expand Down
8 changes: 5 additions & 3 deletions src/languages/de.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3373,12 +3373,14 @@ ${amount} für ${merchant} – ${date}`,
employees: {
title: 'Wie viele Mitarbeitende haben Sie?',
[CONST.ONBOARDING_COMPANY_SIZE.MICRO_SMALL]: '1–4 Mitarbeitende',
[CONST.ONBOARDING_COMPANY_SIZE.MICRO_MEDIUM]: '5–10 Mitarbeitende',
[CONST.ONBOARDING_COMPANY_SIZE.MICRO]: '1–10 Mitarbeitende',
[CONST.ONBOARDING_COMPANY_SIZE.SMALL]: '11–50 Mitarbeitende',
[CONST.ONBOARDING_COMPANY_SIZE.MICRO_MEDIUM]: '5–9 Mitarbeitende',
[CONST.ONBOARDING_COMPANY_SIZE.SMALL]: '10–50 Mitarbeitende',
[CONST.ONBOARDING_COMPANY_SIZE.MEDIUM_SMALL]: '51–100 Mitarbeitende',
[CONST.ONBOARDING_COMPANY_SIZE.MEDIUM]: '101–1.000 Mitarbeitende',
[CONST.ONBOARDING_COMPANY_SIZE.LARGE]: 'Mehr als 1.000 Mitarbeitende',
[CONST.ONBOARDING_COMPANY_SIZE.LEGACY_MICRO_MEDIUM]: '5–10 Mitarbeitende',
[CONST.ONBOARDING_COMPANY_SIZE.LEGACY_MICRO]: '1–10 Mitarbeitende',
[CONST.ONBOARDING_COMPANY_SIZE.LEGACY_SMALL]: '11–50 Mitarbeitende',
},
accounting: {
title: 'Verwendest du eine Buchhaltungssoftware?',
Expand Down
8 changes: 5 additions & 3 deletions src/languages/el.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3425,12 +3425,14 @@ ${amount} για ${merchant} - ${date}`,
employees: {
title: 'Πόσους υπαλλήλους έχετε;',
[CONST.ONBOARDING_COMPANY_SIZE.MICRO_SMALL]: '1–4 εργαζόμενοι',
[CONST.ONBOARDING_COMPANY_SIZE.MICRO_MEDIUM]: '5-10 εργαζόμενοι',
[CONST.ONBOARDING_COMPANY_SIZE.MICRO]: '1–10 εργαζόμενοι',
[CONST.ONBOARDING_COMPANY_SIZE.SMALL]: '11–50 εργαζόμενοι',
[CONST.ONBOARDING_COMPANY_SIZE.MICRO_MEDIUM]: '5–9 εργαζόμενοι',
[CONST.ONBOARDING_COMPANY_SIZE.SMALL]: '10–50 εργαζόμενοι',
[CONST.ONBOARDING_COMPANY_SIZE.MEDIUM_SMALL]: '51-100 εργαζόμενοι',
[CONST.ONBOARDING_COMPANY_SIZE.MEDIUM]: '101-1.000 εργαζόμενοι',
[CONST.ONBOARDING_COMPANY_SIZE.LARGE]: 'Περισσότεροι από 1.000 εργαζόμενοι',
[CONST.ONBOARDING_COMPANY_SIZE.LEGACY_MICRO_MEDIUM]: '5-10 εργαζόμενοι',
[CONST.ONBOARDING_COMPANY_SIZE.LEGACY_MICRO]: '1–10 εργαζόμενοι',
[CONST.ONBOARDING_COMPANY_SIZE.LEGACY_SMALL]: '11–50 εργαζόμενοι',
},
accounting: {
title: 'Χρησιμοποιείτε κάποιο λογιστικό λογισμικό;',
Expand Down
8 changes: 5 additions & 3 deletions src/languages/en.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3471,12 +3471,14 @@ const translations = {
employees: {
title: 'How many employees do you have?',
[CONST.ONBOARDING_COMPANY_SIZE.MICRO_SMALL]: '1-4 employees',
[CONST.ONBOARDING_COMPANY_SIZE.MICRO_MEDIUM]: '5-10 employees',
[CONST.ONBOARDING_COMPANY_SIZE.MICRO]: '1-10 employees',
[CONST.ONBOARDING_COMPANY_SIZE.SMALL]: '11-50 employees',
[CONST.ONBOARDING_COMPANY_SIZE.MICRO_MEDIUM]: '5-9 employees',
[CONST.ONBOARDING_COMPANY_SIZE.SMALL]: '10-50 employees',
[CONST.ONBOARDING_COMPANY_SIZE.MEDIUM_SMALL]: '51-100 employees',
[CONST.ONBOARDING_COMPANY_SIZE.MEDIUM]: '101-1,000 employees',
[CONST.ONBOARDING_COMPANY_SIZE.LARGE]: 'More than 1,000 employees',
[CONST.ONBOARDING_COMPANY_SIZE.LEGACY_MICRO_MEDIUM]: '5-10 employees',
[CONST.ONBOARDING_COMPANY_SIZE.LEGACY_MICRO]: '1-10 employees',
[CONST.ONBOARDING_COMPANY_SIZE.LEGACY_SMALL]: '11-50 employees',
},
accounting: {
title: 'Do you use any accounting software?',
Expand Down
8 changes: 5 additions & 3 deletions src/languages/es.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3279,12 +3279,14 @@ ${amount} para ${merchant} - ${date}`,
employees: {
title: '¿Cuántos empleados tienes?',
[CONST.ONBOARDING_COMPANY_SIZE.MICRO_SMALL]: '1-4 empleados',
[CONST.ONBOARDING_COMPANY_SIZE.MICRO_MEDIUM]: '5-10 empleados',
[CONST.ONBOARDING_COMPANY_SIZE.MICRO]: '1-10 empleados',
[CONST.ONBOARDING_COMPANY_SIZE.SMALL]: '11-50 empleados',
[CONST.ONBOARDING_COMPANY_SIZE.MICRO_MEDIUM]: '5-9 empleados',
[CONST.ONBOARDING_COMPANY_SIZE.SMALL]: '10-50 empleados',
[CONST.ONBOARDING_COMPANY_SIZE.MEDIUM_SMALL]: '51-100 empleados',
[CONST.ONBOARDING_COMPANY_SIZE.MEDIUM]: '101-1,000 empleados',
[CONST.ONBOARDING_COMPANY_SIZE.LARGE]: 'Más de 1,000 empleados',
[CONST.ONBOARDING_COMPANY_SIZE.LEGACY_MICRO_MEDIUM]: '5-10 empleados',
[CONST.ONBOARDING_COMPANY_SIZE.LEGACY_MICRO]: '1-10 empleados',
[CONST.ONBOARDING_COMPANY_SIZE.LEGACY_SMALL]: '11-50 empleados',
},
accounting: {
title: '¿Utilizas algún software de contabilidad?',
Expand Down
8 changes: 5 additions & 3 deletions src/languages/fr.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3379,12 +3379,14 @@ ${amount} pour ${merchant} - ${date}`,
employees: {
title: 'Combien d’employés avez-vous ?',
[CONST.ONBOARDING_COMPANY_SIZE.MICRO_SMALL]: '1 à 4 employés',
[CONST.ONBOARDING_COMPANY_SIZE.MICRO_MEDIUM]: '5 à 10 employés',
[CONST.ONBOARDING_COMPANY_SIZE.MICRO]: '1 à 10 employés',
[CONST.ONBOARDING_COMPANY_SIZE.SMALL]: '11 à 50 employés',
[CONST.ONBOARDING_COMPANY_SIZE.MICRO_MEDIUM]: '5 à 9 employés',
[CONST.ONBOARDING_COMPANY_SIZE.SMALL]: '10 à 50 employés',
[CONST.ONBOARDING_COMPANY_SIZE.MEDIUM_SMALL]: '51 à 100 employés',
[CONST.ONBOARDING_COMPANY_SIZE.MEDIUM]: '101 à 1 000 employés',
[CONST.ONBOARDING_COMPANY_SIZE.LARGE]: 'Plus de 1 000 employés',
[CONST.ONBOARDING_COMPANY_SIZE.LEGACY_MICRO_MEDIUM]: '5 à 10 employés',
[CONST.ONBOARDING_COMPANY_SIZE.LEGACY_MICRO]: '1 à 10 employés',
[CONST.ONBOARDING_COMPANY_SIZE.LEGACY_SMALL]: '11 à 50 employés',
},
accounting: {
title: 'Utilisez-vous un logiciel de comptabilité ?',
Expand Down
8 changes: 5 additions & 3 deletions src/languages/it.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3359,12 +3359,14 @@ ${amount} per ${merchant} - ${date}`,
employees: {
title: 'Quanti dipendenti hai?',
[CONST.ONBOARDING_COMPANY_SIZE.MICRO_SMALL]: '1-4 dipendenti',
[CONST.ONBOARDING_COMPANY_SIZE.MICRO_MEDIUM]: '5-10 dipendenti',
[CONST.ONBOARDING_COMPANY_SIZE.MICRO]: '1-10 dipendenti',
[CONST.ONBOARDING_COMPANY_SIZE.SMALL]: '11-50 dipendenti',
[CONST.ONBOARDING_COMPANY_SIZE.MICRO_MEDIUM]: '5-9 dipendenti',
[CONST.ONBOARDING_COMPANY_SIZE.SMALL]: '10-50 dipendenti',
[CONST.ONBOARDING_COMPANY_SIZE.MEDIUM_SMALL]: '51-100 dipendenti',
[CONST.ONBOARDING_COMPANY_SIZE.MEDIUM]: 'Da 101 a 1.000 dipendenti',
[CONST.ONBOARDING_COMPANY_SIZE.LARGE]: 'Più di 1.000 dipendenti',
[CONST.ONBOARDING_COMPANY_SIZE.LEGACY_MICRO_MEDIUM]: '5-10 dipendenti',
[CONST.ONBOARDING_COMPANY_SIZE.LEGACY_MICRO]: '1-10 dipendenti',
[CONST.ONBOARDING_COMPANY_SIZE.LEGACY_SMALL]: '11-50 dipendenti',
},
accounting: {
title: 'Usi un software di contabilità?',
Expand Down
8 changes: 5 additions & 3 deletions src/languages/ja.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3330,12 +3330,14 @@ ${date} の ${merchant} への ${amount}`,
employees: {
title: '従業員は何人いますか?',
[CONST.ONBOARDING_COMPANY_SIZE.MICRO_SMALL]: '1~4名の従業員',
[CONST.ONBOARDING_COMPANY_SIZE.MICRO_MEDIUM]: '5~10人の従業員',
[CONST.ONBOARDING_COMPANY_SIZE.MICRO]: '従業員数 1~10 人',
[CONST.ONBOARDING_COMPANY_SIZE.SMALL]: '11~50名の従業員',
[CONST.ONBOARDING_COMPANY_SIZE.MICRO_MEDIUM]: '5~9人の従業員',
[CONST.ONBOARDING_COMPANY_SIZE.SMALL]: '10~50名の従業員',
[CONST.ONBOARDING_COMPANY_SIZE.MEDIUM_SMALL]: '51~100人の従業員',
[CONST.ONBOARDING_COMPANY_SIZE.MEDIUM]: '101~1,000人の従業員',
[CONST.ONBOARDING_COMPANY_SIZE.LARGE]: '1,000人超の従業員',
[CONST.ONBOARDING_COMPANY_SIZE.LEGACY_MICRO_MEDIUM]: '5~10人の従業員',
[CONST.ONBOARDING_COMPANY_SIZE.LEGACY_MICRO]: '従業員数 1~10 人',
[CONST.ONBOARDING_COMPANY_SIZE.LEGACY_SMALL]: '11~50名の従業員',
},
accounting: {
title: '会計ソフトを利用していますか?',
Expand Down
8 changes: 5 additions & 3 deletions src/languages/nl.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3362,12 +3362,14 @@ ${amount} voor ${merchant} - ${date}`,
employees: {
title: 'Hoeveel medewerkers heb je?',
[CONST.ONBOARDING_COMPANY_SIZE.MICRO_SMALL]: '1-4 medewerkers',
[CONST.ONBOARDING_COMPANY_SIZE.MICRO_MEDIUM]: '5-10 medewerkers',
[CONST.ONBOARDING_COMPANY_SIZE.MICRO]: '1-10 medewerkers',
[CONST.ONBOARDING_COMPANY_SIZE.SMALL]: '11-50 medewerkers',
[CONST.ONBOARDING_COMPANY_SIZE.MICRO_MEDIUM]: '5-9 medewerkers',
[CONST.ONBOARDING_COMPANY_SIZE.SMALL]: '10-50 medewerkers',
[CONST.ONBOARDING_COMPANY_SIZE.MEDIUM_SMALL]: '51-100 medewerkers',
[CONST.ONBOARDING_COMPANY_SIZE.MEDIUM]: '101-1.000 werknemers',
[CONST.ONBOARDING_COMPANY_SIZE.LARGE]: 'Meer dan 1.000 medewerkers',
[CONST.ONBOARDING_COMPANY_SIZE.LEGACY_MICRO_MEDIUM]: '5-10 medewerkers',
[CONST.ONBOARDING_COMPANY_SIZE.LEGACY_MICRO]: '1-10 medewerkers',
[CONST.ONBOARDING_COMPANY_SIZE.LEGACY_SMALL]: '11-50 medewerkers',
},
accounting: {
title: 'Gebruikt u een boekhoudprogramma?',
Expand Down
8 changes: 5 additions & 3 deletions src/languages/pl.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3391,12 +3391,14 @@ ${amount} dla ${merchant} - ${date}`,
employees: {
title: 'Ilu masz pracowników?',
[CONST.ONBOARDING_COMPANY_SIZE.MICRO_SMALL]: '1–4 pracowników',
[CONST.ONBOARDING_COMPANY_SIZE.MICRO_MEDIUM]: '5–10 pracowników',
[CONST.ONBOARDING_COMPANY_SIZE.MICRO]: '1–10 pracowników',
[CONST.ONBOARDING_COMPANY_SIZE.SMALL]: '11–50 pracowników',
[CONST.ONBOARDING_COMPANY_SIZE.MICRO_MEDIUM]: '5–9 pracowników',
[CONST.ONBOARDING_COMPANY_SIZE.SMALL]: '10–50 pracowników',
[CONST.ONBOARDING_COMPANY_SIZE.MEDIUM_SMALL]: '51–100 pracowników',
[CONST.ONBOARDING_COMPANY_SIZE.MEDIUM]: '101–1 000 pracowników',
[CONST.ONBOARDING_COMPANY_SIZE.LARGE]: 'Ponad 1000 pracowników',
[CONST.ONBOARDING_COMPANY_SIZE.LEGACY_MICRO_MEDIUM]: '5–10 pracowników',
[CONST.ONBOARDING_COMPANY_SIZE.LEGACY_MICRO]: '1–10 pracowników',
[CONST.ONBOARDING_COMPANY_SIZE.LEGACY_SMALL]: '11–50 pracowników',
},
accounting: {
title: 'Czy korzystasz z jakiegoś oprogramowania księgowego?',
Expand Down
8 changes: 5 additions & 3 deletions src/languages/pt-BR.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3350,12 +3350,14 @@ ${amount} para ${merchant} - ${date}`,
employees: {
title: 'Quantos funcionários você tem?',
[CONST.ONBOARDING_COMPANY_SIZE.MICRO_SMALL]: '1–4 funcionários',
[CONST.ONBOARDING_COMPANY_SIZE.MICRO_MEDIUM]: '5–10 funcionários',
[CONST.ONBOARDING_COMPANY_SIZE.MICRO]: '1-10 funcionários',
[CONST.ONBOARDING_COMPANY_SIZE.SMALL]: '11–50 funcionários',
[CONST.ONBOARDING_COMPANY_SIZE.MICRO_MEDIUM]: '5–9 funcionários',
[CONST.ONBOARDING_COMPANY_SIZE.SMALL]: '10–50 funcionários',
[CONST.ONBOARDING_COMPANY_SIZE.MEDIUM_SMALL]: '51 a 100 funcionários',
[CONST.ONBOARDING_COMPANY_SIZE.MEDIUM]: '101–1.000 funcionários',
[CONST.ONBOARDING_COMPANY_SIZE.LARGE]: 'Mais de 1.000 funcionários',
[CONST.ONBOARDING_COMPANY_SIZE.LEGACY_MICRO_MEDIUM]: '5–10 funcionários',
[CONST.ONBOARDING_COMPANY_SIZE.LEGACY_MICRO]: '1-10 funcionários',
[CONST.ONBOARDING_COMPANY_SIZE.LEGACY_SMALL]: '11–50 funcionários',
},
accounting: {
title: 'Você usa algum software de contabilidade?',
Expand Down
8 changes: 5 additions & 3 deletions src/languages/zh-hans.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3246,12 +3246,14 @@ ${amount},商户:${merchant} - 日期:${date}`,
employees: {
title: '您有多少名员工?',
[CONST.ONBOARDING_COMPANY_SIZE.MICRO_SMALL]: '1–4 名员工',
[CONST.ONBOARDING_COMPANY_SIZE.MICRO_MEDIUM]: '5–10 名员工',
[CONST.ONBOARDING_COMPANY_SIZE.MICRO]: '1-10 名员工',
[CONST.ONBOARDING_COMPANY_SIZE.SMALL]: '11–50 名员工',
[CONST.ONBOARDING_COMPANY_SIZE.MICRO_MEDIUM]: '5–9 名员工',
[CONST.ONBOARDING_COMPANY_SIZE.SMALL]: '10–50 名员工',
[CONST.ONBOARDING_COMPANY_SIZE.MEDIUM_SMALL]: '51–100 名员工',
[CONST.ONBOARDING_COMPANY_SIZE.MEDIUM]: '101–1,000 名员工',
[CONST.ONBOARDING_COMPANY_SIZE.LARGE]: '超过 1,000 名员工',
[CONST.ONBOARDING_COMPANY_SIZE.LEGACY_MICRO_MEDIUM]: '5–10 名员工',
[CONST.ONBOARDING_COMPANY_SIZE.LEGACY_MICRO]: '1-10 名员工',
[CONST.ONBOARDING_COMPANY_SIZE.LEGACY_SMALL]: '11–50 名员工',
},
accounting: {
title: '你是否使用任何会计软件?',
Expand Down
2 changes: 2 additions & 0 deletions src/libs/getWorkspaceCreatedAnalyticsEvent.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ const SALES_ELIGIBLE_COMPANY_SIZES = new Set<string>([
CONST.ONBOARDING_COMPANY_SIZE.MEDIUM_SMALL,
CONST.ONBOARDING_COMPANY_SIZE.MEDIUM,
CONST.ONBOARDING_COMPANY_SIZE.LARGE,
CONST.ONBOARDING_COMPANY_SIZE.LEGACY_MICRO_MEDIUM,
CONST.ONBOARDING_COMPANY_SIZE.LEGACY_SMALL,
]);

/**
Expand Down
12 changes: 8 additions & 4 deletions src/pages/OnboardingEmployees/BaseOnboardingEmployees.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -88,15 +88,19 @@ function BaseOnboardingEmployees({shouldUseNativeStyles, route}: BaseOnboardingE
const isVsb = onboardingValues?.signupQualifier === CONST.ONBOARDING_SIGNUP_QUALIFIERS.VSB;
return Object.values(CONST.ONBOARDING_COMPANY_SIZE)
.filter((size) => {
// Always hide the deprecated 1-10 option.
if (size === CONST.ONBOARDING_COMPANY_SIZE.MICRO) {
// Always hide deprecated options.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resumed onboarding can continue with no visible selection. BaseOnboardingEmployees hides legacy 5-10 and 11-50 values, but the component initializes its selection from the persisted Onyx value. A user who selected either range before updating sees no selected option, yet can press Continue and submit the hidden legacy value. Clear invalid legacy selections on load (requiring a new selection) or render the persisted legacy selection.

Does this matter? 🤔

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really, very specific scenario - looks like it will happen if a user drops after selecting the company size before this is deployed

if (
size === CONST.ONBOARDING_COMPANY_SIZE.LEGACY_MICRO_MEDIUM ||
size === CONST.ONBOARDING_COMPANY_SIZE.LEGACY_MICRO ||
size === CONST.ONBOARDING_COMPANY_SIZE.LEGACY_SMALL
) {
return false;
}
// For VSB-qualified users (1-9 from landing page), only show 1-4 and 5-10.
// For VSB-qualified users (1-9 from landing page), only show 1-4 and 5-9.
if (isVsb) {
return size === CONST.ONBOARDING_COMPANY_SIZE.MICRO_SMALL || size === CONST.ONBOARDING_COMPANY_SIZE.MICRO_MEDIUM;
}
// For SMB-qualified users, hide 1-4 and 5-10 since they already indicated 10+.
// For SMB-qualified users, hide 1-4 and 5-9 since they already indicated 10+.
if (isSmb) {
return size !== CONST.ONBOARDING_COMPANY_SIZE.MICRO_SMALL && size !== CONST.ONBOARDING_COMPANY_SIZE.MICRO_MEDIUM;
}
Expand Down
4 changes: 1 addition & 3 deletions src/pages/inbox/HeaderView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,6 @@ function HeaderView({onNavigationMenuButtonClicked, reportID}: HeaderViewProps)
isAdminRoom(report) &&
!!canUserPerformWriteAction(report, isReportArchived) &&
!isChatThread &&
introSelected?.companySize !== CONST.ONBOARDING_COMPANY_SIZE.MICRO &&
introSelected?.companySize !== CONST.ONBOARDING_COMPANY_SIZE.MICRO_SMALL;

const accountManagerAccountID = bookCallDetails?.accountManagerAccountID;
Expand All @@ -234,7 +233,6 @@ function HeaderView({onNavigationMenuButtonClicked, reportID}: HeaderViewProps)
!accountManagerAccountID &&
!!accountGuideDetails?.calendarLink &&
accountGuideDetails?.email !== CONST.EMAIL.CONCIERGE &&
introSelected?.companySize !== CONST.ONBOARDING_COMPANY_SIZE.MICRO &&
introSelected?.companySize !== CONST.ONBOARDING_COMPANY_SIZE.MICRO_SMALL;

// Show the "Book a call" button in the 1:1 DM with the assigned support person, or in the Concierge chat
Expand Down Expand Up @@ -329,7 +327,7 @@ function HeaderView({onNavigationMenuButtonClicked, reportID}: HeaderViewProps)
const [onboardingPurposeSelected] = useOnyx(ONYXKEYS.ONBOARDING_PURPOSE_SELECTED);
const isChatUsedForOnboarding = isChatUsedForOnboardingReportUtils(report, onboarding, conciergeReportID, onboardingPurposeSelected);
const shouldShowRegisterForWebinar =
(introSelected?.companySize === CONST.ONBOARDING_COMPANY_SIZE.MICRO || introSelected?.companySize === CONST.ONBOARDING_COMPANY_SIZE.MICRO_SMALL) &&
(introSelected?.companySize === CONST.ONBOARDING_COMPANY_SIZE.LEGACY_MICRO || introSelected?.companySize === CONST.ONBOARDING_COMPANY_SIZE.MICRO_SMALL) &&

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump. It looks to me like the same problem exists here. Aren't we missing at least 1 value?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MICRO_MEDIUM (5-9) is intentionally excluded because those users get the guide booking button, not the webinar

(isChatUsedForOnboarding || (isAdminRoom(report) && !isChatThread)) &&
!shouldMirrorSidePanelHeader;
const shouldShowOnBoardingHelpDropdownButton = (shouldShowRegisterForWebinar || shouldShowGuideBooking) && !isReportArchived && !shouldMirrorSidePanelHeader;
Expand Down
Loading
Loading