Repository navigation
[Payment due @bernhardoj] Update NewDot onboarding employee ranges #97021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
8570a3a
971ce02
08b3258
f0f68ec
64a5ef8
1caee77
1d92a16
e1bd64a
4271655
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -88,15 +88,19 @@ function BaseOnboardingEmployees({shouldUseNativeStyles, route}: BaseOnboardingE | |
| const isVsb = onboardingValues?.signupQualifier === CONST.ONBOARDING_SIGNUP_QUALIFIERS.VSB; | ||
| return Object.values(CONST.ONBOARDING_COMPANY_SIZE) | ||
| .filter((size) => { | ||
| // Always hide the deprecated 1-10 option. | ||
| if (size === CONST.ONBOARDING_COMPANY_SIZE.MICRO) { | ||
| // Always hide deprecated options. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Resumed onboarding can continue with no visible selection. BaseOnboardingEmployees hides legacy Does this matter? 🤔
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not really, very specific scenario - looks like it will happen if a user drops after selecting the company size before this is deployed |
||
| if ( | ||
| size === CONST.ONBOARDING_COMPANY_SIZE.LEGACY_MICRO_MEDIUM || | ||
| size === CONST.ONBOARDING_COMPANY_SIZE.LEGACY_MICRO || | ||
| size === CONST.ONBOARDING_COMPANY_SIZE.LEGACY_SMALL | ||
| ) { | ||
| return false; | ||
| } | ||
| // For VSB-qualified users (1-9 from landing page), only show 1-4 and 5-10. | ||
| // For VSB-qualified users (1-9 from landing page), only show 1-4 and 5-9. | ||
| if (isVsb) { | ||
| return size === CONST.ONBOARDING_COMPANY_SIZE.MICRO_SMALL || size === CONST.ONBOARDING_COMPANY_SIZE.MICRO_MEDIUM; | ||
| } | ||
| // For SMB-qualified users, hide 1-4 and 5-10 since they already indicated 10+. | ||
| // For SMB-qualified users, hide 1-4 and 5-9 since they already indicated 10+. | ||
| if (isSmb) { | ||
| return size !== CONST.ONBOARDING_COMPANY_SIZE.MICRO_SMALL && size !== CONST.ONBOARDING_COMPANY_SIZE.MICRO_MEDIUM; | ||
| } | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -222,7 +222,6 @@ function HeaderView({onNavigationMenuButtonClicked, reportID}: HeaderViewProps) | |
| isAdminRoom(report) && | ||
| !!canUserPerformWriteAction(report, isReportArchived) && | ||
| !isChatThread && | ||
| introSelected?.companySize !== CONST.ONBOARDING_COMPANY_SIZE.MICRO && | ||
| introSelected?.companySize !== CONST.ONBOARDING_COMPANY_SIZE.MICRO_SMALL; | ||
|
|
||
| const accountManagerAccountID = bookCallDetails?.accountManagerAccountID; | ||
|
|
@@ -234,7 +233,6 @@ function HeaderView({onNavigationMenuButtonClicked, reportID}: HeaderViewProps) | |
| !accountManagerAccountID && | ||
| !!accountGuideDetails?.calendarLink && | ||
| accountGuideDetails?.email !== CONST.EMAIL.CONCIERGE && | ||
| introSelected?.companySize !== CONST.ONBOARDING_COMPANY_SIZE.MICRO && | ||
| introSelected?.companySize !== CONST.ONBOARDING_COMPANY_SIZE.MICRO_SMALL; | ||
|
|
||
| // Show the "Book a call" button in the 1:1 DM with the assigned support person, or in the Concierge chat | ||
|
|
@@ -329,7 +327,7 @@ function HeaderView({onNavigationMenuButtonClicked, reportID}: HeaderViewProps) | |
| const [onboardingPurposeSelected] = useOnyx(ONYXKEYS.ONBOARDING_PURPOSE_SELECTED); | ||
| const isChatUsedForOnboarding = isChatUsedForOnboardingReportUtils(report, onboarding, conciergeReportID, onboardingPurposeSelected); | ||
| const shouldShowRegisterForWebinar = | ||
| (introSelected?.companySize === CONST.ONBOARDING_COMPANY_SIZE.MICRO || introSelected?.companySize === CONST.ONBOARDING_COMPANY_SIZE.MICRO_SMALL) && | ||
| (introSelected?.companySize === CONST.ONBOARDING_COMPANY_SIZE.LEGACY_MICRO || introSelected?.companySize === CONST.ONBOARDING_COMPANY_SIZE.MICRO_SMALL) && | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same question
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bump. It looks to me like the same problem exists here. Aren't we missing at least 1 value?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. MICRO_MEDIUM (5-9) is intentionally excluded because those users get the guide booking button, not the webinar |
||
| (isChatUsedForOnboarding || (isAdminRoom(report) && !isChatThread)) && | ||
| !shouldMirrorSidePanelHeader; | ||
| const shouldShowOnBoardingHelpDropdownButton = (shouldShowRegisterForWebinar || shouldShowGuideBooking) && !isReportArchived && !shouldMirrorSidePanelHeader; | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.