Repository navigation
Lazy-load contact options: shell first, createOption after getValidOptions #97087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mjasikowski
merged 50 commits into
Expensify:main
from
software-mansion-labs:jmgraa/lazy-contact-searchOptions
Aug 18, 2026
Merged
Changes from all commits
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
4509a2f
add contact options lazy loading
jmgraa 698ef39
move lazy loading to separate component
jmgraa f71a45e
move policy, tag, and archive lookups inside createFullOption
jmgraa ff17fea
add tests for lazy loading and hydration of contactOptions
jmgraa 0e9b5b0
add eslint rule for translateLocal in lazyContactOptions
jmgraa 67eb436
add test to ensure createOption and lazy shell remain in sync for fil…
jmgraa 1f2bdeb
remove lazyContactOptions and introduce lazyHydrationData
jmgraa dd91862
empty commit to trigger ci
jmgraa ea82e46
refactor lazy hydration logic to utilize a shared context for persona…
jmgraa 7a879c0
unify text generation and streamline lazy hydration context
jmgraa 57e8c83
add GetPersonalDetailOptionTextProps
jmgraa 50f1ebc
call getPersonalDetailOptionText with object arguments
jmgraa cee50f0
skip phone formatting for a field no shell consumer reads
jmgraa 2575190
stop building contacts for the search "in" filter
jmgraa c0852be
document what includeP2P costs on the option list
jmgraa deeb34d
memoize contact hydration per shell
jmgraa 6ac089c
type contact shells so display fields cannot be read unhydrated
jmgraa d82d283
Merge remote-tracking branch 'upstream' into jmgraa/lazy-contact-sear…
jmgraa 0de78f9
remove alternateText from LazyPersonalDetailOption
jmgraa 3e5f7bc
clarify compile error handling of hydrateLazyPersonalDetailOption
jmgraa f5bc963
test lazy hydration of participant options
jmgraa f5d4398
fix ESLint seatbelt configuration of translateLocal
jmgraa 7db05fc
Merge remote-tracking branch 'upstream' into jmgraa/lazy-contact-sear…
jmgraa a4ea4eb
include conciergeReportID parameter
jmgraa 19df340
require includeP2P parameter
jmgraa 0dadcd6
improve type safety and support direct hydration
jmgraa 3b5b6d2
bound NewChatPage contact hydration
jmgraa 54044af
type filter/rank helpers structurally and drop the deprecated transla…
jmgraa 7ef0030
update useGroupChatDraftParticipantSync to strip the hydration flag f…
jmgraa be8e0cc
update comments for clarity
jmgraa d79acd8
cleanup lazy contact build
jmgraa 308e690
reuse filterReports logic for filterSelfDMChat
jmgraa b8c7fc9
add tests for preserving selected and bold marks
jmgraa 4e7b4c3
remove unused PersonalDetailShell
jmgraa 59b75cc
fix spell errors
jmgraa a41ab6a
support diacritics and zero-width characters in search terms
jmgraa 1965838
swap conditions in isSearchTermsFound
jmgraa 7fe6e0a
shorten comments
jmgraa 856abaf
rename hydrateLazyPersonalDetailOption and hydrateContactOption
jmgraa 8e9b127
apply getValidOptionsConfig based on defined contexts
jmgraa 9742441
Merge remote-tracking branch 'upstream' into jmgraa/lazy-contact-sear…
jmgraa 7b52b2a
remove deferred hydration logic and simplify getValidOptions function
jmgraa 2b14d18
remove unused PersonalDetailFilterRankFields type export
jmgraa 7476a90
refactor comment
jmgraa 768baff
fix whitespaces
jmgraa 0717515
fix comments formatting
jmgraa d24d01e
Merge remote-tracking branch 'upstream' into jmgraa/lazy-contact-sear…
jmgraa f6683a2
run fmt
jmgraa 768bcd7
empty commit to trigger ci
jmgraa b7b99c9
Merge remote-tracking branch 'upstream' into jmgraa/lazy-contact-sear…
jmgraa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.