Skip to content

[CP Staging] Revert "fix: Tax - No autofocus in the name editing menu taxes" - #97125

Merged
mountiny merged 1 commit into
Expensify:mainfrom
software-mansion-labs:revert-95917
Jul 27, 2026
Merged

mountiny merged 1 commit into
Expensify:mainfrom
software-mansion-labs:revert-95917

Conversation

@war-in

@war-in war-in commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Reverts #95917

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

@mountiny

Copy link
Copy Markdown
Contributor

@TaduJR @eVoloshchak we suspect that the FS update is contributing to uptick in crashes https://expensify.slack.com/archives/C05LX9D6E07/p1784965512988289

it is not clear to us, but since the original bug this fixed is not that critical we want to test with a revert

@mountiny
mountiny marked this pull request as ready for review July 27, 2026 17:26
@mountiny
mountiny requested a review from a team as a code owner July 27, 2026 17:26
@mountiny mountiny changed the title Revert "fix: Tax - No autofocus in the name editing menu taxes" [CP Staging] Revert "fix: Tax - No autofocus in the name editing menu taxes" Jul 27, 2026
@melvin-bot
melvin-bot Bot requested review from lakchote and removed request for a team July 27, 2026 17:26
@melvin-bot

melvin-bot Bot commented Jul 27, 2026

Copy link
Copy Markdown

@lakchote Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@mountiny

Copy link
Copy Markdown
Contributor

Running a quick build to confirm this works fine

@github-actions

Copy link
Copy Markdown
Contributor

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@mountiny
mountiny merged commit 4c66847 into Expensify:main Jul 27, 2026
43 of 47 checks passed
@mountiny

Copy link
Copy Markdown
Contributor

Built fine

@melvin-bot melvin-bot Bot added the Emergency label Jul 27, 2026
@melvin-bot

melvin-bot Bot commented Jul 27, 2026

Copy link
Copy Markdown

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

Copy link
Copy Markdown
Contributor

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.46-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@mountiny

Copy link
Copy Markdown
Contributor

Not emergency, revert

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/marcaaron in version: 9.4.46-10 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants