Repository navigation
[Part 23] Remove Onyx.connect from LocalePhoneNumber - #97220
danieldoglas merged 1 commit into
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@chuckdries Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosScreen.Recording.2026-07-30.at.7.06.36.PM.mov |
|
@mountiny, i think this is approved just needs to be merged, could you please take a look. thanks. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 danieldoglas has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/danieldoglas in version: 9.4.49-0 🚀
|
|
🤖 No help site changes required. I reviewed the changes in this PR against the help site articles under WhyThis is a purely internal refactor. It migrates The optimistic report action text it produces ( Since no changes are required, I did not create a docs draft PR. |
|
🚀 Deployed to production by https://github.com/arosiclair in version: 9.4.49-3 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
This PR migrates the optimistic task-assignee action formatting path away from the deprecated
LocalePhoneNumberformatter.Fixed Issues
$ #66327
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screencast.From.2026-07-28.15-38-38.webm