Repository navigation
Revert useConfirmModal to use ConfirmModal for DeleteWorkspaceFlow - #97318
Conversation
|
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@shubham1206agra |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@ZhenjaHorbach Can you revert 8d3d912 exactly? Slight modifications are fine |
But what's the point? 😅 |
| // TODO: temporary fix for https://github.com/Expensify/App/issues/96369 - the error modal is kept as a locally controlled ConfirmModal | ||
| // instead of the global useConfirmModal one, because closing the loading delete confirmation modal and immediately pushing another | ||
| // global modal leaves the flow latched on iOS, so a second delete attempt never restarts the flow. | ||
| const [deleteWorkspaceErrorMessage, setDeleteWorkspaceErrorMessage] = useState<string>(); |
There was a problem hiding this comment.
@ZhenjaHorbach FYI, This is not locale agnostic. Not sure if this is even a realistic worry. Probably not.
There was a problem hiding this comment.
It's okay
The previous version resolved translate() at show-time too
But probably yes, cheap to fix, so I updated it and the state now holds the translation key, and translate() runs at render time
Reviewer Checklist
Screenshots/VideosScreen.Recording.2026-07-30.at.9.02.14.PM.movScreen.Recording.2026-07-30.at.9.12.46.PM.mov |
|
We did not find an internal engineer to review this PR, trying to assign a random engineer to #96369 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 Gonals has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/Gonals in version: 9.4.49-0 🚀
|
|
🤖 I reviewed the changes in this PR against the help site files under No help site changes are required. This PR reverts the workspace-deletion error modal from the global
Since this is a bug fix that restores existing behavior rather than adding or changing anything user-facing, there's nothing to update on the help site, so I did not create a docs PR. @ZhenjaHorbach, please confirm you agree no help site changes are needed. If you think a doc update is warranted, let me know what behavior changed and I'll create the draft PR. |
|
🚀 Deployed to production by https://github.com/arosiclair in version: 9.4.49-3 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Fixed Issues
$ #96369
PROPOSAL:
Tests
Precondition:
Steps:
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
2026-07-29.12.16.48.mov
Android: mWeb Chrome
2026-07-29.12.16.48.mov
iOS: Native
2026-07-29.12.10.10.mov
iOS: mWeb Safari
2026-07-29.12.12.29.mov
MacOS: Chrome / Safari
2026-07-29.11.45.27.mov