Skip to content

[No QA] Docs updates for E/A#94694 Import workflows on Workflows page - #97383

Merged
CortneyOfstad merged 4 commits into
mainfrom
claude-docsImportWorkflowsWorkflowsPage
Sep 16, 2026
Merged

CortneyOfstad merged 4 commits into
mainfrom
claude-docsImportWorkflowsWorkflowsPage

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

PR #94694 surfaces the spreadsheet importer on the Workflows page: under Approvals, admins can now click More → Import workflows to bulk-configure approval workflows via spreadsheet. Previously this importer was only reachable from Members → three-dot menu → Import via Spreadsheet, so the help site had no coverage of the Workflows-page entry point.

This PR documents the new flow by adding a How to import approval workflows from a spreadsheet section to the Add Approvals article. It:

  • Documents the exact UI path: Workspaces > [Workspace Name] > Workflows → Approvals → More → Import workflows.
  • Notes the Control-plan requirement / upgrade prompt for the advanced approval fields (Submit to, Forward to, Over limit forward to, Approval limit).
  • Notes the v1 behavior that the import reuses the Members mapping screen and returns you to the Members page, and cross-links to the existing Invite Multiple Members via Spreadsheet section for column-mapping and template details.
  • Adds relevant search keywords (import workflows, import approval workflows, bulk approval workflows, spreadsheet import).

Files changed

  • docs/articles/new-expensify/workspaces/Add-Approvals.md

Related PR


@jayeshmangwani, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Co-authored-by: Jayesh Mangwani <jayeshmangwani@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Jul 29, 2026
@stephanieelliott stephanieelliott self-assigned this Sep 5, 2026
@stephanieelliott
stephanieelliott marked this pull request as ready for review September 16, 2026 08:02
@github-actions github-actions Bot changed the title Docs updates for E/A#94694 Import workflows on Workflows page [No QA] Docs updates for E/A#94694 Import workflows on Workflows page Sep 16, 2026
@OSBotify

This comment has been minimized.

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR adds a single new section — How to import approval workflows from a spreadsheet — to Add-Approvals.md, documenting the new Workflows-page entry point for the spreadsheet importer (E/A#94694). It also extends the keywords list. The addition is well-scoped, uses a compliant task-based heading, and cross-links appropriately. However, the step sequence contains a non-actionable fragment and appears to omit a UI step (the More menu) that the PR description itself references.

Scores Summary

  • Readability: 7/10 — Prose is clear and scannable, but Step 3 ("Under Approvals.") is a sentence fragment with no action, breaking the sequential/action-oriented step standard.
  • AI Readiness: 8/10 — Strong task-based "How to..." heading with the feature name, realistic search keywords added, single-workflow focus, correct ## hierarchy. Content retrieves well.
  • Style Compliance: 6/10 — Good bolding of UI labels and correct unified navigation phrasing, but a likely-missing More menu step (per PR body: Approvals -> More -> Import workflows) and a mixed action verb ("click Upload File" vs. "Select") reduce UI-exactness.

Key Findings

  • Step 3 ("Under Approvals.") is not an action and reads as an incomplete step; it should be rewritten to start with a verb (e.g., "Under Approvals, select More.").
  • Possible UI accuracy gap: the PR description documents the path as Approvals -> More -> Import workflows, but the steps jump straight from "Under Approvals" to "Select Import workflows", omitting the More menu. Please confirm and reconcile.
  • Mixed action verbs in Step 5 ("Drag and drop your file or click Upload File") — prefer Select for consistency with the rest of the article.
  • Positives: task-based heading with feature name, unified web/mobile navigation phrasing per conventions, relative cross-link with descriptive anchor text placed outside the numbered steps, and the Control-plan requirement is clearly called out.
  • Keyword additions (import workflows, import approval workflows, bulk approval workflows, spreadsheet import) align with real search intent.

Recommendations

  • Fix Step 3 so every numbered step begins with an action verb and reflects the true UI flow.
  • Reconcile the step list with the More menu path described in the PR body to ensure UI-exactness.
  • Standardize the action verb ("Select" vs. "click") within the step list.

Files Reviewed

  • docs/articles/new-expensify/workspaces/Add-Approvals.md — New section + keyword updates. Solid overall; address the step-sequence and UI-path items before merge.

Note: This is a summary review of the proposed changes only.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 84a21ec668

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@stephanieelliott
stephanieelliott requested a review from a team September 16, 2026 08:15
@melvin-bot

melvin-bot Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @CortneyOfstad

@melvin-bot
melvin-bot Bot requested review from CortneyOfstad and removed request for a team September 16, 2026 08:15
@melvin-bot

melvin-bot Bot commented Sep 16, 2026

Copy link
Copy Markdown

@CortneyOfstad Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@OSBotify

This comment has been minimized.

@OSBotify

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://aa32931d.helpdot.pages.dev ⚡️

Updated articles:

@CortneyOfstad
CortneyOfstad merged commit a3e6700 into main Sep 16, 2026
16 of 17 checks passed
@CortneyOfstad
CortneyOfstad deleted the claude-docsImportWorkflowsWorkflowsPage branch September 16, 2026 14:49
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/CortneyOfstad in version: 9.4.81-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/luacmartins in version: 9.4.81-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 failure ❌

1 similar comment
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/luacmartins in version: 9.4.81-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 failure ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants