Skip to content

[CP Staging] Revert "Add filter negation feature" - #97464

Closed
mountiny wants to merge 1 commit into
mainfrom
revert-93909-feat/93208-filter-negation
Closed

mountiny wants to merge 1 commit into
mainfrom
revert-93909-feat/93208-filter-negation

Conversation

@mountiny

Copy link
Copy Markdown
Contributor

Reverts #93909

Fixed issues

$ #97447

@mountiny mountiny self-assigned this Jul 30, 2026
@mountiny
mountiny requested review from a team as code owners July 30, 2026 12:49
@melvin-bot
melvin-bot Bot requested review from JmillsExpensify and shubham1206agra and removed request for a team July 30, 2026 12:49
@melvin-bot

melvin-bot Bot commented Jul 30, 2026

Copy link
Copy Markdown

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team July 30, 2026 12:49
@github-actions

Copy link
Copy Markdown
Contributor

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@codecov

codecov Bot commented Jul 30, 2026 •

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3bc360c115

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/libs/SearchUIUtils.ts
Comment on lines +3181 to +3183
function buildTagGroupQuery(queryJSON: SearchQueryJSON, tag: string): SearchQueryJSON | undefined {
if (!tag || tag === CONST.SEARCH.TAG_EMPTY_VALUE || tag === CONST.SEARCH.TAG_UNTAGGED_VALUE) {
return buildEmptyTagGroupQuery(queryJSON);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Reuse missing-tag query for selected groups

Please route selected tag groups through the same missing-tag path. This helper now correctly turns the No Tag drill-down into -has:tag, but bulk actions/export still build selected-group queries via useSearchBulkActions.addSelectedGroupsFilter() → getSelectedGroupFilterEntry(), which emits tag:none; selecting the No Tag group and then exporting/deleting all matching items will therefore send tag:none instead of -has:tag, so the action won't target the untagged expenses.

Useful? React with 👍 / 👎.

@mountiny

Copy link
Copy Markdown
Contributor Author

This Pr seems to fix the issues #97432

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants