Repository navigation
Refactor Workspace menu data into a shared source - #97559
carlosmiceli merged 26 commits into
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@marufsharifi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
JmillsExpensify
left a comment
There was a problem hiding this comment.
No product review required.
|
@marufsharifi Addressed the above comment, ready for your review. |
|
@marufsharifi Thanks for the thorough review. All valid comments have been addressed, including the regression and coverage gaps. Could you please take another look? |
|
@nabi-ebrahimi, thanks, checking again. |
|
Resolved the conflict. |
|
@marufsharifi Can you please review this when you got a chance, Thanks |
|
@MelvinBot Review. |
|
🤖 Review — this is a clean, faithful refactor. I traced all 21 menu rows and confirmed the extracted Behavior-preservation verification
Optional (non-blocking): the The only red checks are the PR Reviewer Checklist / independent-approval process checks — nothing code-related; they'll clear once you complete the reviewer checklist Melvin pinged you about. |
|
@marufsharifi resolved conflicts, thanks. |
|
@nabi-ebrahimi, could you please check the above comments. thanks. |
@marufsharifi thanks for the review. All actionable comments have been addressed. Could you please review again? |
|
Same here, @marufsharifi. Please complete your re-review today! |
|
I'am testing this, i will finish in a few hours. thanks. |
marufsharifi
left a comment
There was a problem hiding this comment.
Tested works perfect, but some minor suggestions.
|
@marufsharifi thanks for the detailed review. All actionable comments have been addressed. Could you please review again? |
|
🚧 carlosmiceli has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.4.58-0 🚀
|
|
🤖 No help site changes required. I reviewed the changes in this PR against the help site articles under Why: This is a behavior-preserving internal refactor. It extracts the existing Workspace menu definitions from DetailsFiles changed:
The shared helper owns the same menu labels, icons, routes, ordering, permissions, feature gates, badges, RBRs, and highlight state that previously lived inline. Per the PR description, no Workspace menu item is added, removed, renamed, or reordered, and the Workspace UI is unchanged. Because nothing customer-facing (feature names, tab names, settings labels, buttons, or navigation) changed, none of the help articles need edits. @nabi-ebrahimi — no linked help site PR was created since no docs changes are needed. If you believe a specific article should still be updated, reply with the article and what changed and I'll take another pass. |
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.4.58-4 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Extracts the existing Workspace menu definitions from
WorkspaceInitialPageinto the sharedgetWorkspaceMenuItemshelper.The shared source owns the existing menu labels, icons, routes, ordering, permissions, feature gates, badges, RBRs, and highlight state.
WorkspaceInitialPagecontinues to own hooks, policy loading, connection prefetching, rendering, and guarded navigation actions.This is a behavior-preserving prerequisite for adding Workspace navigation suggestions in a follow-up PR. It does not add new Search Router suggestions or change the Workspace UI.
Fixed Issues
$ #92752
PROPOSAL: #92752 (comment)
Tests
Tests
Workspace menu remains unchanged
Expected: No Workspace menu item is added, removed, renamed, or reordered.
Workspace navigation remains unchanged
Expected: Every row opens its correct existing page, and the selected row remains highlighted.
Permissions and feature visibility remain unchanged
Expected: Users only see the same pages allowed by their permissions and enabled Workspace features.
Existing menu indicators remain unchanged
Expected: Existing icons, badges, error indicators, and highlights appear as before.
Responsive layouts
Expected: The menu, header, scrolling, focus, and navigation behave as before, with no visible UI changes.
Offline tests
Same as Tests.
QA Steps
Same as Tests.
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-08-01.at.9.53.20.AM.mov
Android: mWeb Chrome
Screen_Recording_20260801_095012_Chrome.mp4
iOS: Native
Screen.Recording.2026-08-01.at.10.14.02.AM.mp4
iOS: mWeb Safari
Screen.Recording.2026-08-01.at.10.17.18.AM.mov
MacOS: Chrome / Safari
Screen.Recording.2026-07-31.at.6.57.05.PM.mov
Screen.Recording.2026-08-01.at.8.54.53.AM.mov
Screen.Recording.2026-08-01.at.9.28.17.AM.mov
Screen.Recording.2026-08-01.at.9.29.20.AM.mov