Repository navigation
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 97fc48e243
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| const sourcePath = localPath.startsWith('file://') ? decodeURI(localPath) : localPath; | ||
| return RNFetchBlob.MediaCollection.copyToMediaStore( |
There was a problem hiding this comment.
Strip file:// before Android gallery saves
When the pending receipt path is the durable native URI returned by moveReceiptToDurableStorage (for example file:///.../Receipts-Upload/foo.jpg), this helper only decodes the URI and still passes the file:// scheme into RNFetchBlob.MediaCollection.copyToMediaStore. The Android download path already notes that copyToMediaStore takes a bare POSIX path, and the previous implementation passed fileURIToPath(url) for local files; with the new helper, saving offline receipts on Android will fail for the common file:// receipt paths right before sign-out clears the queue.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
added the change, now we use fileURIToPath in android save to browser logic
JmillsExpensify
left a comment
There was a problem hiding this comment.
Big fan on this one. LGTM
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppscreen-20260804-162022-1785853180379.mp4iOS: HybridAppScreen.Recording.2026-08-04.at.15.56.17.movScreen.Recording.2026-08-04.at.15.51.14.movScreen.Recording.2026-08-04.at.15.48.22.mov |
eVoloshchak
left a comment
There was a problem hiding this comment.
LGTM!
TS check failing does not seem related to this PR
|
Test 1 denied permission shows the modal
This isn't ideal, since you see the message about Expensify not being able to save your image after you've already clicked "Sign Out", so even if you click the |
|
thanks for review! The typecheck is gone now 👍
I agree, and it's unavoidable on iOS, we only learn access is None when the write itself rejects, by which point the user has already confirmed sign-out. It only happens on an explicit denial and the receipt loss is covered by the general offline-data-loss warning, I think this is acceptable |
|
The gh actions are down now |
|
Only |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.52-0 🚀
|
Help site review — no docs changes required ✅I reviewed the changes in this PR against Why: This PR re-lands the "save offline receipts on sign out" feature (from the reverted #94973) plus the regression fix, and its primary customer-facing behavior is already documented in the New Expensify help site:
That article accurately reflects the manual sign-out flow this PR ships (the confirmation prompt → Save and sign out → receipts saved to the device's Photos). Since the behavior matches what's already published, there's nothing to add, so I did not open a draft PR. Edge cases I considered but left undocumentedThe PR also handles two behaviors that aren't in the article, but neither is worth surfacing to end users:
If you'd like, I'm happy to extend the existing Q&A to mention the "even if a session expires, we still try to save your receipts" behavior — just let me know and I'll draft it. Note: this is a mobile-native-only feature (iOS/Android), so it isn't reproducible on the web build. @rinej, since the behavior is already covered by the existing Create-an-Expense help article, please confirm it still reflects the current behavior. If you'd rather I add the forced-sign-out/failure nuance, reply and I'll open a draft help site PR. |
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.52-11 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
On iOS and Android, if you sign out while a receipt is still uploading, the app now saves that receipt image to your device gallery before it clears storage. That way you can add it again later instead of losing it.
Manual sign-out from Settings shows a short confirmation prompt. Forced sign-outs (expired or invalid session) save silently without a prompt. If saving fails for any reason, sign-out still completes normally.
It is based on the reverted PR -> #94973
Just added the fix for the regression -> #95957
Fixed Issues
$ #97487
PROPOSAL: #92139 (comment)
Tests
Test 1 denied permission shows the modal
Precondition: iOS Settings → Expensify → Photos → None
Test 2 - Happy path: receipt is saved
Precondition: iOS Settings → Expensify → Photos → Add Photos Only (or All Photos)
Go offline, create a scan expense with an image receipt (stays queued).
Sign out → confirm.
✅ Verify no permission modal appears, sign-out completes, and the receipt image is now in the Camera Roll / Photos.
Repeat for other platforms
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Permission Already Granted:
NotificationWithSettingGranted.mp4
Permission First Granted:
NotificationFixWithNoPermissions.mp4
Permission Already Denied:
NotificaitonWithNoPermissionGranted.mp4
Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari