Repository navigation
[No QA] Update a few more stray usages of Magic code - #97597
Conversation
|
@mjasikowski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e258f9ef2e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| CODE_HITS=$(grep -rn --include="*.ts" --include="*.tsx" "magicCode\|MagicCode\|MAGIC_CODE" "$ROOT_DIR/src" "$ROOT_DIR/tests" 2>/dev/null | filter_comments || true) | ||
| DOCS_HITS=$(grep -rn --include="*.md" "magic.code\|magic code\|magicCode\|MagicCode\|MAGIC_CODE" "$ROOT_DIR" 2>/dev/null | grep -v "node_modules" || true) | ||
| LANG_HITS=$(grep -rni --include="*.ts" "magic.code\|magic code|magic-code" "$ROOT_DIR/src/languages" 2>/dev/null | filter_comments || true) | ||
| CODE_HITS=$(grep -rn --include="*.ts" --include="*.tsx" "magicCode\|magic-code|MagicCode\|MAGIC_CODE" "$ROOT_DIR/src" "$ROOT_DIR/tests" 2>/dev/null | filter_comments || true) |
There was a problem hiding this comment.
Restore alternation for MagicCode checks
In the PR workflow that runs ./scripts/checkValidateCodeTerminology.sh, this grep call still uses basic regex syntax (confirmed by grep --help: -E, --extended-regexp is the option for extended regex), so the new bare | is treated as a literal instead of an alternation. As written, the code check no longer matches standalone magic-code or MagicCode in TS/TSX files, letting exactly the terminology violations this change is meant to block pass CI; escape both separators as \| or switch the command to grep -E.
Useful? React with 👍 / 👎.
|
@NikkiWines got ESLint and Typescript failures |
|
@mjasikowski updated! |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 chuckdries has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/chuckdries in version: 9.4.49-0 🚀
|
|
🤖 No help site changes required. I reviewed the changes in this PR against Expensify's help site files under Why: This PR is an internal terminology cleanup — it extends the Help site verification
@NikkiWines, since this is an internal-only cleanup with no user-facing changes, there's no help site PR to review. If you believe any public article should still be updated, let me know and I'll open a docs PR. |
|
🚀 Deployed to production by https://github.com/arosiclair in version: 9.4.49-3 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Updates the CI tool to check for
magic-codeas well. Fixes stray usages.Fixed Issues
$ N/A follow up PR
PROPOSAL:
Tests
N/A
Offline tests
N/A
QA Steps
N/A
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari