Repository navigation
Migrate money request time step to dynamic routes (#83850 part 2 #97762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mjasikowski
merged 13 commits into
Expensify:main
from
suneox:83850-migrate-money-request-part-2-v2-suneox
Aug 11, 2026
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
2e7a9a8
Migrate money request time step to dynamic routes (#83850 part 2, re-…
suneox 5b1d1a6
Fix cspell and trim the per diem navigation comments
suneox fdf4186
Merge remote-tracking branch 'upstream/main' into 83850-migrate-money…
suneox 878eada
Merge remote-tracking branch 'upstream/main' into 83850-migrate-money…
suneox 76209bb
update codex review
suneox 77a4e29
fix per-diem ws navigation back
suneox 81be246
Merge remote-tracking branch 'upstream/main' into 83850-migrate-money…
suneox c0ae300
Merge remote-tracking branch 'upstream/main' into 83850-migrate-money…
suneox 3303e33
removed test reverted in pr #97900
suneox f6cbed7
Merge remote-tracking branch 'upstream/main' into 83850-migrate-money…
suneox 1eb6560
cleanup comment
suneox 60014e3
cleanup comment
suneox d335028
Merge branch 'main' into 83850-migrate-money-request-part-2-v2-suneox
suneox File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The removed static time route accepted an optional
backToReportpath segment, so existing links like/create/submit/time/<transactionID>/<reportID>/<backToReport>no longer match this redirect because the pattern ends after the reportID. Those legacy URLs now fall through afterMONEY_REQUEST_STEP_TIMEwas removed from the linking config instead of opening the migrated dynamic time step; add a more specific redirect that carries the extra segment into the new start/destination/time path.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@suneox Could you check the Codex comments? 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/*/*/time/*/*does not end at the reportID. In getMatchingNewRoute a trailing*compiles to(.*)(multi-segment) while non-trailing wildcards compile to([^/]+)(exactly one segment). So the last wildcard swallows<reportID>/<backToReport>and $4 carries both segments into the new path.