Repository navigation
Refactor Domain menu data into shared source - #97855
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@marufsharifi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@marufsharifi Can you please review this when you got a chance, Thanks |
|
@MelvinBot Review |
Review — looks good ✅This is a clean, behavior-preserving extraction. The menu order, labels, icons, routes, One thing to confirm, two optional nits: 1. Dropped Optional nits2. Redundant icon re-mapping — 3. Test coverage — Runtime check: I drove Workspaces → Domains on web with the test account, but it doesn't administer any domain (empty "Enhance your security with domains" state), so the admin menu itself couldn't be exercised at runtime. No errors or regressions in the reachable UI. The refactor's equivalence is well established by the static analysis above + the unit tests, so this is low risk. |
|
@marufsharifi thanks for the review. All comments have been addressed, and the focused checks and tests pass. Could you please take another look? |
|
@marufsharifi kindly bump, Thanks. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-08-20.at.12.05.07.PM.movAndroid: mWeb ChromeScreen_Recording_20260814_152906_Chrome.mp4iOS: HybridAppScreen.Recording.2026-08-14.at.3.31.00.PM.moviOS: mWeb SafariScreen.Recording.2026-08-14.at.3.34.09.PM.movMacOS: Chrome / SafariScreen.Recording.2026-08-14.at.3.21.12.PM.mov |
|
@marufsharifi kindly bump, thanks. |
|
@nabi-ebrahimi, thanks, i am reviewing. |
|
How are you getting on, do you think you'll complete the review today? |
|
@trjExpensify, yes, but Github is down. |
|
Yeah, bad GH. Seems like we're back on track now! |
|
I will finish this in an hour. thanks. |
marufsharifi
left a comment
There was a problem hiding this comment.
Tested, it works perfect, but some minor suggestions.
|
@marufsharifi thanks for the detailed review. All actionable comments have been addressed, and I replied to the optional items with the reasoning for keeping the current approach. Could you please review again? |
|
... and another! @marufsharifi, please re-review it today. |
|
Thanks, i will finish this in afternoon. |
marufsharifi
left a comment
There was a problem hiding this comment.
Looks good, but a minor suggestion.
|
@marufsharifi thanks for the review. All actionable comments have been addressed. Please take another look. |
|
@carlosmiceli can you please also merge this one too if it looks good to you, cause domain navigation is also blocked by this one. Thanks. |
|
@trjExpensify I think we are waiting for your review as Product here, Thanks! |
|
No need, I just had to leave yesterday before CI checks completed. |
|
🚧 carlosmiceli has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.4.59-0 🚀
|
Help site review: no changes required ✅I reviewed the changes in this PR and no updates are needed to Expensify's help site files under Why: This is a behavior-preserving code refactor. It extracts the existing Domain menu definitions into a shared What I checked
The PR itself notes this is a prerequisite for adding Domain navigation suggestions in a separate PR — that follow-up may introduce user-facing behavior worth documenting, but this one does not. @nabi-ebrahimi, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Note: no help site PR was created because this refactor has no user-facing changes to document. If you believe a docs update is still warranted (e.g. for the upcoming Domain navigation suggestions feature), let me know and I'll draft one. |
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.4.59-5 🚀
Bundle Size Analysis (Sentry): |

Explanation of Change
This PR extracts the existing Domain menu definitions into a shared
getDomainMenuItemsbuilder and updatesDomainInitialPageto consume it.The menu order, labels, icons, routes, access rules, and error indicators remain unchanged. This is a behavior-preserving prerequisite for adding Domain navigation suggestions in a separate PR.
Fixed Issues
$ #92752
PROPOSAL: #92752 (comment)
Tests
Domain menu remains unchanged
Precondition: The user administers a domain.
Expected: Every row opens its corresponding Domain page, and the menu looks and behaves as it did before this refactor.
Offline tests
Same as Tests.
QA Steps
Same as Tests.
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-08-06.at.7.24.12.PM.mov
Android: mWeb Chrome
Recording_20260806_192841.mp4
iOS: Native
Screen.Recording.2026-08-06.at.7.48.40.PM.mov
iOS: mWeb Safari
Screen.Recording.2026-08-06.at.7.32.43.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2026-08-06.at.6.38.06.AM.mov