Repository navigation
[Payment due @huult] fix: Show IES name on export surfaces - #97898
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3c6b565d85
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4c0b16d6ec
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@ShridharGoel Tag me when it's ready |
|
@huult It's already ready |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-08-19.at.13.57.34.mp4Android: mWeb ChromeScreen.Recording.2026-08-19.at.13.53.58.mp4iOS: HybridAppScreen.Recording.2026-08-19.at.14.04.05.mp4iOS: mWeb SafariScreen.Recording.2026-08-19.at.14.01.40.mp4MacOS: Chrome / SafariScreen.Recording.2026-08-19.at.13.45.18.mp4 |
Screen.Recording.2026-08-06.at.15.41.13.movBUG: The failure message still shows "QuickBooks Online" when exporting a report to Intuit Enterprise Suite. |
Screen.Recording.2026-08-06.at.15.45.34.movBUG: When I copy the message "Started exporting this report to Intuit Enterprise Suite..." and paste it, it changes to "Started exporting this report to QuickBooks Online...". |
Screen.Recording.2026-08-06.at.15.47.32.movQUESTION: When exporting a report to Intuit Enterprise Suite, the connection name is still quickbooksOnline. Is that expected? |
|
I think we should add unit tests for |
|
@lakchote could you run this translation? |
|
🎯 @huult, thanks for reviewing and testing this PR! 🎉 A payment issue will be created for your review once this PR is deployed to production. If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created. |
|
@lakchote @mountiny It looks like no internal engineer has been assigned to this PR yet. Could you help check this PR and run the translation mentioned in this comment? |
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index 948af772..86cdd9ef 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -4596,8 +4596,8 @@ ${amount} für ${merchant} – ${date}`,
subscription: 'Abonnement',
markAsEntered: 'Als manuell erfasst markieren',
markAsExported: 'Als exportiert markieren',
- exportIntegrationSelected: ({connectionName, connectionNameFriendly}) =>
- `Exportieren nach ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]}`,
+ exportIntegrationSelected: ({connectionName, connectionNameFriendly}: ExportIntegrationSelectedParams) =>
+ `Export nach ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]}`,
letsDoubleCheck: 'Lass uns noch einmal überprüfen, ob alles richtig aussieht.',
lineItemLevel: 'Positionsebene',
reportLevel: 'Report-Ebene',
@@ -7281,7 +7281,7 @@ Wenn du die Abrechnung für das gesamte Abonnement übernehmen willst, bitte sie
reportName,
connectionName,
connectionNameFriendly,
- }) => `Die folgenden Berichte wurden bereits nach ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]} exportiert. Sind Sie sicher, dass Sie sie noch einmal exportieren möchten?
+ }: ExportAgainModalDescriptionParams) => `Die folgenden Berichte wurden bereits nach ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]} exportiert. Sind Sie sicher, dass Sie sie erneut exportieren möchten?
${reportName}`,
confirmText: 'Ja, erneut exportieren',
@@ -7290,7 +7290,7 @@ ${reportName}`,
exportDifferentCompaniesModal: {
title: 'Vorsicht!',
description: (connectionName: ConnectionName, connectionNameFriendly?: string) =>
- `Die ausgewählten Berichte sind mit verschiedenen ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]}-Unternehmen verbunden und können daher nicht zusammen exportiert werden. Wählen Sie Berichte aus, die mit demselben Unternehmen verbunden sind, und versuchen Sie es erneut.`,
+ `Die ausgewählten Berichte sind mit verschiedenen ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]}-Unternehmen verbunden, daher können sie nicht gemeinsam exportiert werden. Wählen Sie Berichte aus, die mit demselben Unternehmen verbunden sind, und versuchen Sie es erneut.`,
confirmText: 'Verstanden',
},
exportPartialModal: {
@@ -7299,12 +7299,14 @@ ${reportName}`,
description: (integration: ConnectionName, hasReportsOnOtherIntegrations: boolean, hasIneligibleReports: boolean, connectionNameFriendly?: string) => {
const reasons: string[] = [];
if (hasReportsOnOtherIntegrations) {
- reasons.push(`Nur mit ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[integration]} verbundene Berichte werden exportiert.`);
+ reasons.push(`Es werden nur Berichte exportiert, die mit ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[integration]} verknüpft sind.`);
}
if (hasIneligibleReports) {
- reasons.push(`Nur exportierbare Berichte werden exportiert.`);
+ reasons.push(`Es werden nur Berichte exportiert, die für den Export berechtigt sind.`);
}
- return `${reasons.join('\n\n')}\n\nDie folgenden Berichte werden exportiert:`;
+ return `${reasons.join('\n\n')}
+
+Die folgenden Reports werden exportiert:`;
},
confirmText: () => ({
one: `1 Bericht exportieren`,
diff --git a/src/languages/el.ts b/src/languages/el.ts
index 9ecb2932..33d886eb 100644
--- a/src/languages/el.ts
+++ b/src/languages/el.ts
@@ -4676,7 +4676,8 @@ ${amount} για ${merchant} - ${date}`,
subscription: 'Συνδρομή',
markAsEntered: 'Σήμανση ως καταχωρισμένο χειροκίνητα',
markAsExported: 'Επισήμανση ως εξαχθέν',
- exportIntegrationSelected: ({connectionName, connectionNameFriendly}) => `Εξαγωγή σε ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]}`,
+ exportIntegrationSelected: ({connectionName, connectionNameFriendly}: ExportIntegrationSelectedParams) =>
+ `Εξαγωγή σε ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]}`,
letsDoubleCheck: 'Ας ελέγξουμε άλλη μία φορά ότι όλα φαίνονται σωστά.',
lineItemLevel: 'Σε επίπεδο επιμέρους στοιχείου',
reportLevel: 'Επίπεδο αναφοράς',
@@ -7538,7 +7539,7 @@ _Για πιο αναλυτικές οδηγίες, [επισκεφθείτε τ
reportName,
connectionName,
connectionNameFriendly,
- }) => `Οι παρακάτω αναφορές έχουν ήδη εξαχθεί στο ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]}. Είστε βέβαιοι ότι θέλετε να τις εξαγάγετε ξανά;
+ }: ExportAgainModalDescriptionParams) => `Οι παρακάτω αναφορές έχουν ήδη εξαχθεί στο ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]}. Είστε βέβαιοι ότι θέλετε να τις εξαγάγετε ξανά;
${reportName}`,
confirmText: 'Ναι, εξαγωγή ξανά',
@@ -7546,22 +7547,24 @@ ${reportName}`,
},
exportDifferentCompaniesModal: {
title: 'Προσοχή!',
- description: (connectionName, connectionNameFriendly) =>
- `Οι επιλεγμένες αναφορές είναι συνδεδεμένες με διαφορετικές εταιρείες ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]}, επομένως δεν μπορούν να εξαχθούν μαζί. Επιλέξτε αναφορές που είναι συνδεδεμένες με την ίδια εταιρεία και δοκιμάστε ξανά.`,
+ description: (connectionName: ConnectionName, connectionNameFriendly?: string) =>
+ `Οι επιλεγμένες αναφορές είναι συνδεδεμένες με διαφορετικές εταιρείες ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]}, επομένως δεν γίνεται να εξαχθούν μαζί. Επιλέξτε αναφορές συνδεδεμένες με την ίδια εταιρεία και δοκιμάστε ξανά.`,
confirmText: 'Το κατάλαβα',
},
exportPartialModal: {
- title: (exportableCount, selectedCount, integration, connectionNameFriendly) =>
+ title: (exportableCount: number, selectedCount: number, integration: ConnectionName, connectionNameFriendly?: string) =>
`Εξαγωγή ${exportableCount}/${selectedCount} αναφορών στο ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[integration]};`,
- description: (integration, hasReportsOnOtherIntegrations, hasIneligibleReports, connectionNameFriendly) => {
+ description: (integration: ConnectionName, hasReportsOnOtherIntegrations: boolean, hasIneligibleReports: boolean, connectionNameFriendly?: string) => {
const reasons: string[] = [];
if (hasReportsOnOtherIntegrations) {
- reasons.push(`Θα εξαχθούν μόνο οι αναφορές που είναι συνδεδεμένες στο ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[integration]}.`);
+ reasons.push(`Μόνο οι αναφορές που είναι συνδεδεμένες με το ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[integration]} θα εξαχθούν.`);
}
if (hasIneligibleReports) {
- reasons.push(`Θα εξαχθούν μόνο οι αναφορές που είναι επιλέξιμες για εξαγωγή.`);
+ reasons.push(`Μόνο οι αναφορές που είναι κατάλληλες για εξαγωγή θα εξαχθούν.`);
}
- return `${reasons.join('\n\n')}\n\nΘα εξαχθούν οι παρακάτω αναφορές:`;
+ return `${reasons.join('\n\n')}
+
+Οι ακόλουθες αναφορές θα εξαχθούν:`;
},
confirmText: () => ({
one: `Εξαγωγή 1 αναφοράς`,
diff --git a/src/languages/es.ts b/src/languages/es.ts
index 311fe207..b9f6a4b2 100644
--- a/src/languages/es.ts
+++ b/src/languages/es.ts
@@ -4520,7 +4520,8 @@ ${amount} para ${merchant} - ${date}`,
subscription: 'Suscripción',
markAsEntered: 'Marcar como introducido manualmente',
markAsExported: 'Marcar como exportado',
- exportIntegrationSelected: ({connectionName, connectionNameFriendly}) => `Exportar a ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]}`,
+ exportIntegrationSelected: ({connectionName, connectionNameFriendly}: ExportIntegrationSelectedParams) =>
+ `Exportar a ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]}`,
letsDoubleCheck: 'Verifiquemos que todo esté correcto',
reportField: 'Campo del informe',
lineItemLevel: 'Nivel de partida',
@@ -7238,7 +7239,7 @@ El plan Controlar empieza en 9 $ por miembro activo al mes.`,
reportName,
connectionName,
connectionNameFriendly,
- }) => `Los siguientes informes ya se han exportado a ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]}. ¿Seguro que quieres exportarlos de nuevo?
+ }: ExportAgainModalDescriptionParams) => `Los siguientes informes ya se han exportado a ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]}. ¿Seguro que quieres exportarlos de nuevo?
${reportName}`,
confirmText: 'Sí, exportar de nuevo',
@@ -7246,22 +7247,24 @@ ${reportName}`,
},
exportDifferentCompaniesModal: {
title: '¡Cuidado!',
- description: (connectionName, connectionNameFriendly) =>
- `Los informes seleccionados están conectados a diferentes empresas de ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]}, por lo que no se pueden exportar juntos. Selecciona informes conectados a la misma empresa e inténtalo de nuevo.`,
+ description: (connectionName: ConnectionName, connectionNameFriendly?: string) =>
+ `Los informes seleccionados están conectados a diferentes empresas ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]}, por lo que no se pueden exportar juntos. Selecciona informes conectados a la misma empresa e inténtalo de nuevo.`,
confirmText: 'Entendido',
},
exportPartialModal: {
- title: (exportableCount, selectedCount, integration, connectionNameFriendly) =>
+ title: (exportableCount: number, selectedCount: number, integration: ConnectionName, connectionNameFriendly?: string) =>
`¿Exportar ${exportableCount}/${selectedCount} informes a ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[integration]}?`,
- description: (integration, hasReportsOnOtherIntegrations, hasIneligibleReports, connectionNameFriendly) => {
+ description: (integration: ConnectionName, hasReportsOnOtherIntegrations: boolean, hasIneligibleReports: boolean, connectionNameFriendly?: string) => {
const reasons: string[] = [];
if (hasReportsOnOtherIntegrations) {
reasons.push(`Solo se exportarán los informes conectados a ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[integration]}.`);
}
if (hasIneligibleReports) {
- reasons.push(`Solo se exportarán los informes aptos para la exportación.`);
+ reasons.push(`Solo se exportarán los informes que sean aptos para exportarse.`);
}
- return `${reasons.join('\n\n')}\n\nSe exportarán los siguientes informes:`;
+ return `${reasons.join('\n\n')}
+
+Se exportarán los siguientes informes:`;
},
confirmText: () => ({
one: `Exportar 1 informe`,
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index 7bef96c5..7a6f818a 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -4605,7 +4605,8 @@ ${amount} pour ${merchant} - ${date}`,
subscription: 'Abonnement',
markAsEntered: 'Marquer comme saisi manuellement',
markAsExported: 'Marquer comme exporté',
- exportIntegrationSelected: ({connectionName, connectionNameFriendly}) => `Exporter vers ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]}`,
+ exportIntegrationSelected: ({connectionName, connectionNameFriendly}: ExportIntegrationSelectedParams) =>
+ `Exporter vers ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]}`,
letsDoubleCheck: 'Vérifions une seconde fois que tout est correct.',
lineItemLevel: 'Niveau poste de ligne',
reportLevel: 'Niveau de la note de frais',
@@ -7303,7 +7304,7 @@ Si vous souhaitez prendre en charge la facturation de l’ensemble de son abonne
reportName,
connectionName,
connectionNameFriendly,
- }) => `Les notes de frais suivantes ont déjà été exportées vers ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]}. Voulez-vous vraiment les exporter à nouveau ?
+ }: ExportAgainModalDescriptionParams) => `Les notes de frais suivantes ont déjà été exportées vers ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]}. Voulez-vous vraiment les exporter à nouveau ?
${reportName}`,
confirmText: 'Oui, exporter à nouveau',
@@ -7312,21 +7313,23 @@ ${reportName}`,
exportDifferentCompaniesModal: {
title: 'Attention !',
description: (connectionName: ConnectionName, connectionNameFriendly?: string) =>
- `Les notes de frais sélectionnées sont connectées à différentes entreprises ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]}, elles ne peuvent donc pas être exportées ensemble. Sélectionnez des notes de frais connectées à la même entreprise, puis réessayez.`,
+ `Les notes de frais sélectionnées sont liées à différentes sociétés ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]}, elles ne peuvent donc pas être exportées ensemble. Sélectionnez des notes de frais liées à la même société et réessayez.`,
confirmText: 'Compris',
},
exportPartialModal: {
title: (exportableCount: number, selectedCount: number, integration: ConnectionName, connectionNameFriendly?: string) =>
- `Exporter ${exportableCount}/${selectedCount} rapports vers ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[integration]} ?`,
+ `Exporter ${exportableCount}/${selectedCount} notes de frais vers ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[integration]} ?`,
description: (integration: ConnectionName, hasReportsOnOtherIntegrations: boolean, hasIneligibleReports: boolean, connectionNameFriendly?: string) => {
const reasons: string[] = [];
if (hasReportsOnOtherIntegrations) {
- reasons.push(`Seuls les rapports connectés à ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[integration]} seront exportés.`);
+ reasons.push(`Seules les notes de frais liées à ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[integration]} seront exportées.`);
}
if (hasIneligibleReports) {
- reasons.push(`Seuls les rapports éligibles à l’exportation seront exportés.`);
+ reasons.push(`Seules les notes de frais pouvant être exportées seront exportées.`);
}
- return `${reasons.join('\n\n')}\n\nLes rapports suivants seront exportés :`;
+ return `${reasons.join('\n\n')}
+
+Les notes de frais suivantes seront exportées :`;
},
confirmText: () => ({
one: `Exporter 1 rapport`,
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 3cdc3167..4ea204e6 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -4572,7 +4572,8 @@ ${amount} per ${merchant} - ${date}`,
subscription: 'Abbonamento',
markAsEntered: 'Segna come inserito manualmente',
markAsExported: 'Segna come esportato',
- exportIntegrationSelected: ({connectionName, connectionNameFriendly}) => `Esporta in ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]}`,
+ exportIntegrationSelected: ({connectionName, connectionNameFriendly}: ExportIntegrationSelectedParams) =>
+ `Esporta in ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]}`,
letsDoubleCheck: 'Controlliamo che sia tutto corretto.',
lineItemLevel: 'Livello voce di dettaglio',
reportLevel: 'Livello report',
@@ -7248,7 +7249,7 @@ Se vuoi assumere la fatturazione per l'intero abbonamento, chiedi loro di aggiun
reportName,
connectionName,
connectionNameFriendly,
- }) => `I seguenti report sono già stati esportati in ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]}. Vuoi davvero esportarli di nuovo?
+ }: ExportAgainModalDescriptionParams) => `I seguenti report sono già stati esportati in ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]}. Sei sicuro di volerli esportare di nuovo?
${reportName}`,
confirmText: 'Sì, esporta di nuovo',
@@ -7257,21 +7258,23 @@ ${reportName}`,
exportDifferentCompaniesModal: {
title: 'Attenzione!',
description: (connectionName: ConnectionName, connectionNameFriendly?: string) =>
- `I report selezionati sono collegati ad aziende ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]} diverse, quindi non possono essere esportati insieme. Seleziona i report collegati alla stessa azienda e riprova.`,
+ `I report selezionati sono collegati a diverse aziende ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]}, quindi non possono essere esportati insieme. Seleziona report collegati alla stessa azienda e riprova.`,
confirmText: 'Ho capito',
},
exportPartialModal: {
title: (exportableCount: number, selectedCount: number, integration: ConnectionName, connectionNameFriendly?: string) =>
- `Esportare ${exportableCount}/${selectedCount} report in ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[integration]}?`,
+ `Esportare ${exportableCount}/${selectedCount} report su ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[integration]}?`,
description: (integration: ConnectionName, hasReportsOnOtherIntegrations: boolean, hasIneligibleReports: boolean, connectionNameFriendly?: string) => {
const reasons: string[] = [];
if (hasReportsOnOtherIntegrations) {
- reasons.push(`Verranno esportati solo i report collegati a ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[integration]}.`);
+ reasons.push(`Solo i report collegati a ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[integration]} verranno esportati.`);
}
if (hasIneligibleReports) {
reasons.push(`Verranno esportati solo i report idonei all’esportazione.`);
}
- return `${reasons.join('\n\n')}\n\nVerranno esportati i seguenti report:`;
+ return `${reasons.join('\n\n')}
+
+Verranno esportati i seguenti report:`;
},
confirmText: () => ({
one: `Esporta 1 report`,
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index be164488..aeff8ba1 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -4535,7 +4535,7 @@ ${integrationName === CONST.ONBOARDING_ACCOUNTING_MAPPING.other ? 'あなたの'
subscription: 'サブスクリプション',
markAsEntered: '手入力としてマーク',
markAsExported: 'エクスポート済みにする',
- exportIntegrationSelected: ({connectionName, connectionNameFriendly}) =>
+ exportIntegrationSelected: ({connectionName, connectionNameFriendly}: ExportIntegrationSelectedParams) =>
`${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]} にエクスポート`,
letsDoubleCheck: 'すべて正しく表示されているか、もう一度確認しましょう。',
lineItemLevel: '明細レベル',
@@ -7163,7 +7163,7 @@ Control プランは、アクティブメンバー1人あたり月額 $9 から
reportName,
connectionName,
connectionNameFriendly,
- }) => `次のレポートはすでに ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]} にエクスポートされています。もう一度エクスポートしてもよろしいですか?
+ }: ExportAgainModalDescriptionParams) => `次のレポートはすでに ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]} にエクスポートされています。もう一度エクスポートしてもよろしいですか?
${reportName}`,
confirmText: 'はい、再度エクスポートします',
@@ -7172,21 +7172,23 @@ ${reportName}`,
exportDifferentCompaniesModal: {
title: '注意!',
description: (connectionName: ConnectionName, connectionNameFriendly?: string) =>
- `選択したレポートは異なる ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]} の会社に接続されているため、一緒にエクスポートすることはできません。同じ会社に接続されているレポートを選択して、もう一度お試しください。`,
+ `選択されたレポートは異なる ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]} 会社に接続されているため、まとめてエクスポートすることはできません。同じ会社に接続されているレポートを選択して、もう一度お試しください。`,
confirmText: '了解',
},
exportPartialModal: {
title: (exportableCount: number, selectedCount: number, integration: ConnectionName, connectionNameFriendly?: string) =>
- `${exportableCount}/${selectedCount}件のレポートを${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[integration]}にエクスポートしますか?`,
+ `${selectedCount}件中${exportableCount}件のレポートを${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[integration]}にエクスポートしますか?`,
description: (integration: ConnectionName, hasReportsOnOtherIntegrations: boolean, hasIneligibleReports: boolean, connectionNameFriendly?: string) => {
const reasons: string[] = [];
if (hasReportsOnOtherIntegrations) {
- reasons.push(`${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[integration]}に接続されているレポートのみがエクスポートされます。`);
+ reasons.push(`${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[integration]} に接続されているレポートのみがエクスポートされます。`);
}
if (hasIneligibleReports) {
- reasons.push(`エクスポート可能なレポートのみがエクスポートされます。`);
+ reasons.push(`エクスポートの対象となるレポートのみがエクスポートされます。`);
}
- return `${reasons.join('\n\n')}\n\n以下のレポートがエクスポートされます:`;
+ return `${reasons.join('\n\n')}
+
+次のレポートがエクスポートされます。`;
},
confirmText: () => ({
one: `1件のレポートをエクスポート`,
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 221b9b42..eb3f3653 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -4570,7 +4570,7 @@ ${amount} voor ${merchant} - ${date}`,
subscription: 'Abonnement',
markAsEntered: 'Markeren als handmatig ingevoerd',
markAsExported: 'Markeren als geëxporteerd',
- exportIntegrationSelected: ({connectionName, connectionNameFriendly}) =>
+ exportIntegrationSelected: ({connectionName, connectionNameFriendly}: ExportIntegrationSelectedParams) =>
`Exporteren naar ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]}`,
letsDoubleCheck: 'Laten we nog even controleren of alles er goed uitziet.',
lineItemLevel: 'Op regelniveau',
@@ -7233,7 +7233,7 @@ Als je de facturering voor hun volledige abonnement wilt overnemen, laat hen je
reportName,
connectionName,
connectionNameFriendly,
- }) => `De volgende rapporten zijn al geëxporteerd naar ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]}. Weet je zeker dat je ze opnieuw wilt exporteren?
+ }: ExportAgainModalDescriptionParams) => `De volgende rapporten zijn al geëxporteerd naar ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]}. Weet je zeker dat je ze opnieuw wilt exporteren?
${reportName}`,
confirmText: 'Ja, opnieuw exporteren',
@@ -7242,21 +7242,23 @@ ${reportName}`,
exportDifferentCompaniesModal: {
title: 'Voorzichtig!',
description: (connectionName: ConnectionName, connectionNameFriendly?: string) =>
- `De geselecteerde rapporten zijn verbonden met verschillende ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]}-bedrijven en kunnen daarom niet samen worden geëxporteerd. Selecteer rapporten die met hetzelfde bedrijf zijn verbonden en probeer het opnieuw.`,
+ `De geselecteerde rapporten zijn gekoppeld aan verschillende ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]}-bedrijven, waardoor ze niet samen kunnen worden geëxporteerd. Selecteer rapporten die aan hetzelfde bedrijf zijn gekoppeld en probeer het opnieuw.`,
confirmText: 'Begrepen',
},
exportPartialModal: {
title: (exportableCount: number, selectedCount: number, integration: ConnectionName, connectionNameFriendly?: string) =>
- `${exportableCount}/${selectedCount} rapporten exporteren naar ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[integration]}?`,
+ `Wil je ${exportableCount}/${selectedCount} rapporten exporteren naar ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[integration]}?`,
description: (integration: ConnectionName, hasReportsOnOtherIntegrations: boolean, hasIneligibleReports: boolean, connectionNameFriendly?: string) => {
const reasons: string[] = [];
if (hasReportsOnOtherIntegrations) {
- reasons.push(`Alleen rapporten die zijn verbonden met ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[integration]} worden geëxporteerd.`);
+ reasons.push(`Alleen rapporten die zijn gekoppeld aan ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[integration]} worden geëxporteerd.`);
}
if (hasIneligibleReports) {
- reasons.push(`Alleen rapporten die in aanmerking komen voor export worden geëxporteerd.`);
+ reasons.push(`Alleen rapporten die in aanmerking komen om te exporteren, worden geëxporteerd.`);
}
- return `${reasons.join('\n\n')}\n\nDe volgende rapporten worden geëxporteerd:`;
+ return `${reasons.join('\n\n')}
+
+De volgende rapporten worden geëxporteerd:`;
},
confirmText: () => ({
one: `1 rapport exporteren`,
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 09eadee4..ea69e452 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -4555,7 +4555,8 @@ ${amount} dla ${merchant} - ${date}`,
subscription: 'Subskrypcja',
markAsEntered: 'Oznacz jako wprowadzone ręcznie',
markAsExported: 'Oznacz jako wyeksportowane',
- exportIntegrationSelected: ({connectionName, connectionNameFriendly}) => `Eksportuj do ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]}`,
+ exportIntegrationSelected: ({connectionName, connectionNameFriendly}: ExportIntegrationSelectedParams) =>
+ `Eksportuj do ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]}`,
letsDoubleCheck: 'Sprawdźmy jeszcze raz, czy wszystko wygląda poprawnie.',
lineItemLevel: 'Poziom pozycji liniowej',
reportLevel: 'Poziom raportu',
@@ -7213,7 +7214,7 @@ Jeśli chcesz przejąć rozliczenia za całą ich subskrypcję, poproś ich najp
reportName,
connectionName,
connectionNameFriendly,
- }) => `Następujące raporty zostały już wyeksportowane do ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]}. Na pewno chcesz wyeksportować je ponownie?
+ }: ExportAgainModalDescriptionParams) => `Następujące raporty zostały już wyeksportowane do ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]}. Na pewno chcesz wyeksportować je ponownie?
${reportName}`,
confirmText: 'Tak, wyeksportuj ponownie',
@@ -7231,12 +7232,14 @@ ${reportName}`,
description: (integration: ConnectionName, hasReportsOnOtherIntegrations: boolean, hasIneligibleReports: boolean, connectionNameFriendly?: string) => {
const reasons: string[] = [];
if (hasReportsOnOtherIntegrations) {
- reasons.push(`Wyeksportowane zostaną tylko raporty połączone z ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[integration]}.`);
+ reasons.push(`Zostaną wyeksportowane tylko raporty połączone z ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[integration]}.`);
}
if (hasIneligibleReports) {
- reasons.push(`Wyeksportowane zostaną tylko raporty kwalifikujące się do eksportu.`);
+ reasons.push(`Zostaną wyeksportowane tylko raporty kwalifikujące się do eksportu.`);
}
- return `${reasons.join('\n\n')}\n\nWyeksportowane zostaną następujące raporty:`;
+ return `${reasons.join('\n\n')}
+
+Następujące raporty zostaną wyeksportowane:`;
},
confirmText: () => ({
one: `Wyeksportuj 1 raport`,
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 2bca83df..d39204ba 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -4564,7 +4564,8 @@ ${amount} para ${merchant} - ${date}`,
subscription: 'Assinatura',
markAsEntered: 'Marcar como inserido manualmente',
markAsExported: 'Marcar como exportado',
- exportIntegrationSelected: ({connectionName, connectionNameFriendly}) => `Exportar para ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]}`,
+ exportIntegrationSelected: ({connectionName, connectionNameFriendly}: ExportIntegrationSelectedParams) =>
+ `Exportar para ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]}`,
letsDoubleCheck: 'Vamos conferir se está tudo certo.',
lineItemLevel: 'Nível de item de linha',
reportLevel: 'Nível do relatório',
@@ -7234,7 +7235,7 @@ Se você quiser assumir a cobrança de toda a assinatura deles, peça para que a
reportName,
connectionName,
connectionNameFriendly,
- }) => `Os seguintes relatórios já foram exportados para ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]}. Tem certeza de que quer exportá-los novamente?
+ }: ExportAgainModalDescriptionParams) => `Os seguintes relatórios já foram exportados para ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]}. Tem certeza de que quer exportá-los novamente?
${reportName}`,
confirmText: 'Sim, exportar novamente',
@@ -7243,7 +7244,7 @@ ${reportName}`,
exportDifferentCompaniesModal: {
title: 'Cuidado!',
description: (connectionName: ConnectionName, connectionNameFriendly?: string) =>
- `Os relatórios selecionados estão conectados a empresas ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]} diferentes, portanto não podem ser exportados juntos. Selecione relatórios conectados à mesma empresa e tente novamente.`,
+ `Os relatórios selecionados estão conectados a diferentes empresas ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]}, então não podem ser exportados juntos. Selecione relatórios conectados à mesma empresa e tente novamente.`,
confirmText: 'Entendi',
},
exportPartialModal: {
@@ -7252,12 +7253,14 @@ ${reportName}`,
description: (integration: ConnectionName, hasReportsOnOtherIntegrations: boolean, hasIneligibleReports: boolean, connectionNameFriendly?: string) => {
const reasons: string[] = [];
if (hasReportsOnOtherIntegrations) {
- reasons.push(`Somente os relatórios conectados a ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[integration]} serão exportados.`);
+ reasons.push(`Somente relatórios conectados a ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[integration]} serão exportados.`);
}
if (hasIneligibleReports) {
- reasons.push(`Somente os relatórios elegíveis para exportação serão exportados.`);
+ reasons.push(`Somente relatórios que forem elegíveis para exportação serão exportados.`);
}
- return `${reasons.join('\n\n')}\n\nOs seguintes relatórios serão exportados:`;
+ return `${reasons.join('\n\n')}
+
+Os seguintes relatórios serão exportados:`;
},
confirmText: () => ({
one: `Exportar 1 relatório`,
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 6cb66161..a297d79d 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -4430,7 +4430,8 @@ ${amount},商户:${merchant} - 日期:${date}`,
subscription: '订阅',
markAsEntered: '标记为手动输入',
markAsExported: '标记为已导出',
- exportIntegrationSelected: ({connectionName, connectionNameFriendly}) => `导出到 ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]}`,
+ exportIntegrationSelected: ({connectionName, connectionNameFriendly}: ExportIntegrationSelectedParams) =>
+ `导出到 ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]}`,
letsDoubleCheck: '我们再仔细检查一下,确保一切都正确。',
lineItemLevel: '单行项目级别',
reportLevel: '报表级别',
@@ -6990,7 +6991,7 @@ _如需更详细的说明,请[访问我们的帮助网站](${CONST.NETSUITE_IM
reportName,
connectionName,
connectionNameFriendly,
- }) => `以下报销报告已导出到 ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]}。确定要再次导出吗?
+ }: ExportAgainModalDescriptionParams) => `以下报表已导出到 ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]}。确定要再次导出吗?
${reportName}`,
confirmText: '是,再次导出',
@@ -6999,21 +7000,23 @@ ${reportName}`,
exportDifferentCompaniesModal: {
title: '小心!',
description: (connectionName: ConnectionName, connectionNameFriendly?: string) =>
- `所选报表连接到不同的 ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]} 公司,因此无法一起导出。请选择连接到同一公司的报表,然后重试。`,
+ `所选报表关联到不同的 ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]} 公司,因此无法一起导出。请选择关联到同一公司的报表后重试。`,
confirmText: '知道了',
},
exportPartialModal: {
title: (exportableCount: number, selectedCount: number, integration: ConnectionName, connectionNameFriendly?: string) =>
- `将 ${exportableCount}/${selectedCount} 份报表导出到 ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[integration]}?`,
+ `将 ${exportableCount}/${selectedCount} 份报表导出到 ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[integration]} 吗?`,
description: (integration: ConnectionName, hasReportsOnOtherIntegrations: boolean, hasIneligibleReports: boolean, connectionNameFriendly?: string) => {
const reasons: string[] = [];
if (hasReportsOnOtherIntegrations) {
- reasons.push(`只有连接到 ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[integration]} 的报表会被导出。`);
+ reasons.push(`只有与 ${connectionNameFriendly ?? CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[integration]} 关联的报表会被导出。`);
}
if (hasIneligibleReports) {
- reasons.push(`只有符合导出条件的报表会被导出。`);
+ reasons.push(`只有符合导出条件的报表才会被导出。`);
}
- return `${reasons.join('\n\n')}\n\n将导出以下报表:`;
+ return `${reasons.join('\n\n')}
+
+将导出以下报表:`;
},
confirmText: () => ({
one: `导出 1 份报表`,
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
|
@ShridharGoel Could you apply the translation? |
|
The translations diff has unrelated changes which are not worth applying.
|
|
Applied some of the changes. |
|
@huult can you please do final check? |
Screen.Recording.2026-08-20.at.21.43.18.mov@mountiny We can move forward with this PR. |
mountiny
left a comment
There was a problem hiding this comment.
@ShridharGoel one comment
| import type {OnyxEntry} from 'react-native-onyx'; | ||
| import type {ValueOf} from 'type-fest'; | ||
|
|
||
| const INTUIT_ENTERPRISE_SUITE_SCOPE = 'app-foundations.custom-dimensions.read'; |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.59-0 🚀
|
No help site changes requiredI reviewed this PR against the help articles in Why: This PR is a UI display-label change — it shows Intuit Enterprise Suite instead of QuickBooks Online on export surfaces (export menu, re-export prompt, optimistic export action, The help site already reflects this reality and doesn't document the specific per-tier export button/menu labels that this PR touches:
Since the docs describe how the connection/export works (not the exact in-app label variant shown per subscription tier), and IES is already covered as a QBO variant, there's nothing to add or correct. I did not open a draft docs PR. If you'd like the articles to explicitly note that IES workspaces will now see "Intuit Enterprise Suite" as the label on export surfaces, let me know with |
|
@ShridharGoel we need credentials for the 1st step intuitEnterpriseSuite beta enabled. Can you share please or is this a internal PR? |
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.4.59-5 🚀
Bundle Size Analysis (Sentry): |
|
🤖 Payment issue created: #99360 |
Explanation of Change
Shows Intuit Enterprise Suite instead of QuickBooks Online on export menus, export filters, re-export prompts, and optimistic export actions when the workspace has an IES connection.
The search and API values stay unchanged because IES reuses the QuickBooks Online backend connection.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/658857
PROPOSAL:
Tests
intuitEnterpriseSuitebeta.Offline tests
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
MacOS: Chrome / Safari