Repository navigation
Remove Onyx.connect() for the key: ONYXKEYS.COLLECTION.REPORT in src/libs/OptionsListUtils.ts (Part 2) - #97934
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
sorry for the delay, I will comeback this issue today |
|
@DylanDylann Please review again |
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
DylanDylann
left a comment
There was a problem hiding this comment.
All good. @thelullabyy could you resolve conflict?
Reviewer Checklist
Screenshots/VideosScreen.Recording.2026-09-11.at.15.38.38.mov |
|
ok looks like there are a lot of conflicts |
|
@DylanDylann Reverted the changes |
|
@DylanDylann I pushed the fix, kindly review again |
|
@thelullabyy Failed typecheck |
|
@thelullabyy Kindly bump |
|
@DylanDylann Type issue fixed |
|
🚧 danieldoglas has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/danieldoglas in version: 9.4.95-0 🚀
|
|
No help site changes are required for this PR, so I didn't create a docs PR. This PR is an internal refactor. It removes the module-level Why no docs update is needed
|
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.95-4 🚀
|
Explanation of Change
Fixed Issues
$ #66378
PROPOSAL:
Tests
Setup
Test 1:
Test 2:
in:Offline tests
QA Steps
Setup
Test 1:
Test 2:
in:PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-08-06.at.12.25.57.mov
Screen.Recording.2026-08-06.at.12.29.37.mov