Repository navigation
fix: display read-only Role selector at full opacity in member details - #98109
Conversation
Gate disabled/interactive/shouldShowRightIcon on a single canEditSelectedMemberRole flag and pass shouldGreyOutWhenDisabled={false} + shouldUseDefaultCursorWhenDisabled, so the read-only Role field renders at full opacity with no caret and a default cursor, matching the Email field.
|
@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@eVoloshchak kindly bump |
Reviewer Checklist
Screenshots/Videos |
|
🚧 mollfpr has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mollfpr in version: 9.4.56-0 🚀
|
|
🤖 No help site changes required. This PR is a presentation-only fix: the read-only Role field in the member details panel now renders at full opacity with no caret and a default cursor (matching the read-only Email field), instead of appearing greyed out. It does not change who can edit a member's role, add any feature, or introduce/rename any user-facing copy, labels, tabs, or settings. Because nothing about the documented behavior in What I checked
If you'd still like an article touched (for example to add or refresh a screenshot of the member details panel), let me know which article and I'll open a draft PR. |
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.4.56-3 🚀
Bundle Size Analysis (Sentry): |





Explanation of Change
The Role field in the member details panel was passed
disabled, andMenuItemdims any disabled row toopacity: 0.5, so a read-only role looked greyed out.interactive/shouldShowRightIconused a different condition that ignored the owner and current-user cases, so the caret could still show.Now a single
canEditSelectedMemberRoleflag drivesdisabled,interactiveandshouldShowRightIcon, plusshouldGreyOutWhenDisabled={false}andshouldUseDefaultCursorWhenDisabled. The press guard stays, and the read-only Role field renders at full opacity, with no caret and a default cursor, matching the Email field.Fixed Issues
$ #96791
PROPOSAL: #96791 (comment)
Tests
>) is displayed on the Role row, and hovering it shows the normal cursor, so it looks the same as the read-only Email field above it.Offline tests
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android_app.mp4
Android: mWeb Chrome
android_web.mp4
iOS: Native
ios_app.mp4
iOS: mWeb Safari
ios_web.mp4
MacOS: Chrome / Safari
web.mp4