Repository navigation
Fix - Search bulk pay drops the selected payment method after magic code verification - #98310
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 215cf0c823
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
| }, 0); | ||
| }, [selectedTransactions, selectedTransactionsKeys, isExpenseReportType, searchData]); | ||
|
|
||
| const handleBulkPaySubItemSelected = (subItem: PopoverMenuItem, triggerKYCFlow: (kycParams: ContinueActionParams) => void) => |
There was a problem hiding this comment.
❌ CONSISTENCY-12 (docs)
handleBulkPaySubItemSelected is named for the event slot it is wired to (onSubItemSelected) rather than the action it performs. Per STYLE.md, a callback should be named for the behavior it triggers so it stays searchable by intent and reusable across triggers; the on*/handle* naming belongs on the JSX prop, not on the function definition.
Rename the declaration to describe the action, and keep the event name only at the call site. For example:
const payBulkSelectedItem = (subItem: PopoverMenuItem, triggerKYCFlow: (kycParams: ContinueActionParams) => void) =>
handleBulkPayItemSelected({ /* ... */ });
// call site keeps the on* naming on the prop:
onSubItemSelected={(subItem) => payBulkSelectedItem(subItem, triggerKYCFlow)}Reviewed at: 215cf0c | Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.
There was a problem hiding this comment.
@jmusial did you want to address this one as well?
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppios.moviOS: mWeb SafariMacOS: Chrome / Safariweb.mov |
|
@aimane-chnaif bumpity bump |
|
🤖 Code review — LGTM overall. The change correctly adopts the established Why it's correct
Minor notes (non-blocking)
I couldn't run an end‑to‑end verification of this flow here (it needs an unvalidated account, a USD workspace with payable reports, a bank‑funded method, and a real magic code), so I relied on code analysis plus the per‑platform videos already attached. Tests in the changed area ( |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
🤖 Regression scan — low risk. The only behavioral change is on the previously-broken unvalidated-user bulk-pay path; validated users are entirely unaffected, so I found no regression to existing behavior. Flagging two things to watch on the new resume path (they're new-feature edge cases, not regressions). Why the blast radius is small
New-path edge cases to watch (not regressions)The resume closure
Testing note: I couldn't exercise the interactive bulk-pay flow end-to-end — the fresh test account has no expenses/reports, so selection mode and the green bulk-action button were never reachable. What I could confirm on the PR branch: the Search page (Expenses + Reports tabs) loads with no crash or console error, so the refactored component isn't broken on mount. A full regression pass really needs an admin account with payable reports plus the unvalidated-user + bank-account scenario from the PR's test steps. |
| }, 0); | ||
| }, [selectedTransactions, selectedTransactionsKeys, isExpenseReportType, searchData]); | ||
|
|
||
| const handleBulkPaySubItemSelected = (subItem: PopoverMenuItem, triggerKYCFlow: (kycParams: ContinueActionParams) => void) => |
There was a problem hiding this comment.
@jmusial did you want to address this one as well?
mountiny
left a comment
There was a problem hiding this comment.
Thanks for addressing that
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.56-0 🚀
|
|
🤖 No help site changes required. This PR is an internal bug fix — it makes Search bulk pay store the selected payment method via How I checked
Since no documentation is affected, I did not create a draft help site PR — there's nothing to link. @jmusial, please confirm you agree no help site changes are needed. If you think an article should be updated (or created) to cover this flow, let me know and I'll draft the PR. |
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.4.56-3 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Search bulk pay now stores the selected payment method via
useVerifyAccountAndResumeand resumes the payment automatically after magic-code verification, instead of dropping the selection when redirecting an unvalidated user to the verify-account screen.Fixed Issues
$ #98063
PROPOSAL:
Tests
Pay with bank account).Offline tests
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-08-11.at.16.54.07.mov
Android: mWeb Chrome
Screen.Recording.2026-08-11.at.16.46.01.mov
iOS: Native
Screen.Recording.2026-08-11.at.16.48.58.mov
iOS: mWeb Safari
Screen.Recording.2026-08-11.at.16.51.05.mov
MacOS: Chrome / Safari
Screen.Recording.2026-08-11.at.16.34.06.mov