Repository navigation
[No QA] Use native concurrency queue for test builds - #98694
Merged
Merged
Conversation
|
@neil-marcellini Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
66 tasks done
Contributor
|
🚀 Deployed to staging by https://github.com/Beamanator in version: 9.4.56-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.4.56-3 🚀
Bundle Size Analysis (Sentry): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
testBuildOnPush.ymlused a dedicated runner-consuming job to poll for earlier workflow runs and serialize builds. This replaces that custom FIFO queue with GitHub Actions' native concurrency queue, which keeps up to 100 pending runs automatically.The workflow now uses the existing
testBuildOnPushconcurrency group withcancel-in-progress: falseandqueue: max, so pending builds are retained and processed serially without holding an extra runner while they wait.Fixed Issues
N/A
Tests
.github/workflows/testBuildOnPush.ymlwith Ruby's YAML parser.git diff --checkand review the workflow diff.Offline tests
N/A
QA Steps
N/A
PR Author Checklist
### Fixed Issuessection above (N/A)TestssectionOffline stepssection (N/A)QA stepssection (N/A)createNewVersion.ymlpattern)mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps (not applicable)Screenshots/Videos
Android: Native
N/A - CI workflow configuration change, no UI impact.
Android: mWeb Chrome
N/A - CI workflow configuration change, no UI impact.
iOS: Native
N/A - CI workflow configuration change, no UI impact.
iOS: mWeb Safari
N/A - CI workflow configuration change, no UI impact.
MacOS: Chrome / Safari
N/A - CI workflow configuration change, no UI impact.