Skip to content

[No QA] Use native concurrency queue for test builds - #98694

Merged
Beamanator merged 2 commits into
mainfrom
rory/use-concurrency-queue-test-build
Aug 18, 2026
Merged

Beamanator merged 2 commits into
mainfrom
rory/use-concurrency-queue-test-build

Conversation

@roryabraham

Copy link
Copy Markdown
Contributor

Explanation of Change

testBuildOnPush.yml used a dedicated runner-consuming job to poll for earlier workflow runs and serialize builds. This replaces that custom FIFO queue with GitHub Actions' native concurrency queue, which keeps up to 100 pending runs automatically.

The workflow now uses the existing testBuildOnPush concurrency group with cancel-in-progress: false and queue: max, so pending builds are retained and processed serially without holding an extra runner while they wait.

Fixed Issues

N/A

Tests

  1. Parse .github/workflows/testBuildOnPush.yml with Ruby's YAML parser.
  2. Run git diff --check and review the workflow diff.
  • Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

N/A

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above (N/A)
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section (N/A)
    • I added steps for Staging and/or Production testing in the QA steps section (N/A)
    • I added steps to cover failure scenarios (N/A for workflow configuration)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (N/A for workflow configuration)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (N/A for workflow configuration)
  • I included screenshots or videos for tests on all platforms (N/A for CI workflow configuration)
  • I ran the tests on all platforms & verified they passed on (N/A for CI workflow configuration)
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (N/A for CI workflow configuration)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory (no comments needed)
    • I verified that any new or modified comments were clear, correct English, and explained why the code was doing something instead of only explaining what it was doing (no comments modified)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers (matches existing createNewVersion.yml pattern)
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (N/A for CI workflow configuration)
  • I added unit tests for any new feature or bug fix in this PR (N/A for CI workflow configuration)
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps (not applicable)

Screenshots/Videos

Android: Native

N/A - CI workflow configuration change, no UI impact.

Android: mWeb Chrome

N/A - CI workflow configuration change, no UI impact.

iOS: Native

N/A - CI workflow configuration change, no UI impact.

iOS: mWeb Safari

N/A - CI workflow configuration change, no UI impact.

MacOS: Chrome / Safari

N/A - CI workflow configuration change, no UI impact.

@roryabraham
roryabraham requested a review from a team as a code owner August 14, 2026 21:55
@melvin-bot
melvin-bot Bot requested a review from neil-marcellini August 14, 2026 21:56
@melvin-bot

melvin-bot Bot commented Aug 14, 2026

Copy link
Copy Markdown

@neil-marcellini Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team August 14, 2026 21:56

@Beamanator Beamanator left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Beamanator
Beamanator merged commit 45ef064 into main Aug 18, 2026
33 of 34 checks passed
@Beamanator
Beamanator deleted the rory/use-concurrency-queue-test-build branch August 18, 2026 16:41
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Aug 18, 2026
66 tasks done
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/Beamanator in version: 9.4.56-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Beamanator in version: 9.4.56-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants