Skip to content

Migrate money request participants step to a dynamic route - #98937

Merged
mjasikowski merged 6 commits into
Expensify:mainfrom
suneox:83852-migrate-money-request-part-2-suneox
Aug 20, 2026
Merged

mjasikowski merged 6 commits into
Expensify:mainfrom
suneox:83852-migrate-money-request-part-2-suneox

Conversation

@suneox

@suneox suneox commented Aug 19, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

This is part 2 of migrating the money request steps from backTo/forwardTo to dynamic URL navigation. It replaces the static :action/:iouType/participants/:transactionID/:reportID route with the expense-participants dynamic suffix, following the query-param suffix pattern already used on main by expense-merchant, expense-tag and taxRate: the params that used to live in the path are now query params on the suffix, and the page derives its back path from useDynamicBackPath instead of a backTo param.

Fixed Issues

$ #83852
PROPOSAL:

Tests

DYNAMIC_ROUTES.MONEY_REQUEST_STEP_PARTICIPANTS — recipient / workspace picker for an expense

Case 2.1 — Global create (Manual tab) → participants → back

Target: src/libs/IOUUtils.ts navigateToParticipantPage via src/libs/IOUAmountSubmission.ts submitGlobalCreate

Precondition: the account has no default expense policy, so shouldUseDefaultExpensePolicy is false and the flow reaches the participant picker.

Steps:

  1. Open the app and sign in with the test account.
  2. Press the FAB (+) → Create expense.
  3. On the Manual tab, enter an amount → Next.
  4. Press the header back button.

Expected:

  • After step 3 the URL is /create/create/start/<transactionID>/<reportID>/expense-participants?action=create&iouType=create&transactionID=…&reportID=… and the Choose recipient page opens.
  • After step 4 you are back on the create page, the expense-participants suffix is gone from the URL and the amount you entered is still there.

Case 2.2 — Global create (Scan tab) → participants

Target: src/pages/iou/request/step/IOURequestStepScan/components/NavigateGlobalCreateContext.tsx

Precondition: same as Case 2.1.

Steps:

  1. Press the FAB → Create expense → Scan tab.
  2. Choose Choose file and upload any receipt image.
  3. Press the header back button.

Expected: the URL gains /expense-participants?action=create&iouType=create&… and the recipient picker opens; back returns to the create page (Scan tab) with the uploaded receipt still there.


Case 2.3 — Global create (Distance tab) → participants

Target: src/pages/iou/request/step/IOURequestStepDistance/handleMoneyRequestStepDistanceNavigation.ts

Precondition: same as Case 2.1.

Steps:

  1. Press the FAB → Create expense → Distance tab.
  2. Enter a valid Start and Stop waypoint → Next.
  3. Press the header back button.

Expected: the URL gains /expense-participants?… and the recipient picker opens; back returns to the create page (Distance tab) with the waypoints still there.


Case 2.4 — Drag & drop a receipt on the Inbox → participants

Target: src/hooks/useReceiptScanDrop.tsx

Precondition: same as Case 2.1. Web only (drag & drop is web-only).

Steps:

  1. Open the app on the Inbox.
  2. Drag a receipt image from the desktop and drop it on the chat list.
  3. Press the header back button.

Expected: the URL is /create/create/start/<optimisticTransactionID>/<reportID>/expense-participants?action=create&iouType=create&…, the recipient picker opens (not /not-found), and back returns to the create page.


Case 2.5 — Drag & drop a receipt in Search → participants

Target: src/pages/Search/SearchPageWide.tsx → same hook as Case 2.4

Precondition: same as Case 2.4.

Steps:

  1. Open the Reports / Search tab (URL /search/...).
  2. Drag & drop a receipt image on the search results.

Expected: same as Case 2.4 — the base path is the create page, not /search/..., and the recipient picker opens normally.


Case 2.6 — Confirmation → tap the To field → pick a recipient → back to Confirmation

Target: src/components/MoneyRequestConfirmationList.tsx navigateToParticipantPage

Precondition: you are on the Confirmation step of a new expense with the To field still editable (canEditParticipant), and the NEW_MANUAL_EXPENSE_FLOW beta is off (with it on the picker opens inline instead of navigating).

Steps:

  1. Press the FAB → Create expense → Manual tab → enter an amount → Next.
  2. Pick a recipient to reach the Confirmation page.
  3. Tap the To row.
  4. Pick a different recipient.
  5. Repeat step 3, then press the header back button instead of picking anyone.

Expected:

  • After step 3 the URL is <confirmation-url>/expense-participants?action=create&iouType=create&transactionID=…&reportID=… and the recipient picker opens.
  • After step 4 you are back on the Confirmation page (suffix gone) and the To field shows the new recipient.
  • After step 5 you are back on Confirmation with the recipient unchanged.

Case 2.7 — Incomplete split bill (Split details) → tap To

Target: SCREENS.SPLIT_DETAILS.DYNAMIC_ROOT in the route's entryScreens

Precondition: an incomplete split bill exists in a group chat and you are signed in as the original actor, so MoneyRequestConfirmationList renders the editable fields.

Steps:

  1. Open the group chat with the incomplete split bill → tap the split action to open Split details (URL /r/<reportID>/split/<reportActionID>).
  2. Tap the To row.
  3. Press the header back button.

Expected: the URL is /r/<reportID>/split/<reportActionID>/expense-participants?… and the recipient picker opens — not /not-found; back returns to Split details.


Case 2.8 — Submit a tracked expense with multiple workspaces → workspaces-only picker

Target: src/libs/ReportUtils.ts createDraftTransactionAndNavigateToParticipantSelector (multiple-workspaces branch)

Precondition: the account is a member of 2 or more submit-enabled workspaces and has a tracked expense in the Self DM. submitDestination = EMPLOYER.

Steps:

  1. Open the Self DM and find a tracked expense.
  2. Press Submit it to my employer.
  3. Press the header back button.

Expected:

  • The URL is /r/<selfDMReportID>/expense-participants?action=submit&iouType=submit&transactionID=…&reportID=…&isWorkspacesOnly=true.
  • The list shows workspaces only — no Recents or individual recipients.
  • Back returns to the Self DM chat.

Case 2.9 — Submit a tracked expense, SUBMIT action (not workspaces-only)

Target: src/libs/ReportUtils.ts createDraftTransactionAndNavigateToParticipantSelector (submit branch)

Precondition: a tracked expense in the Self DM; submitDestination = FRIEND, or filteredPoliciesCount > 0 with actionName = SUBMIT.

Steps:

  1. Open the Self DM → tracked expense → press Submit it to someone.
  2. Pick a recipient.
  3. Press back on the Confirmation page.

Expected:

  • The URL is /r/<selfDMReportID>/expense-participants?action=submit&iouType=submit&transactionID=…&reportID=… with no isWorkspacesOnly.
  • The list shows Recents / individuals as well as workspaces.
  • Step 2 moves on to the Confirmation page (/create/submit/confirmation/...).
  • Step 3 lands on the recipient picker or the previous screen — no blank screen and no /not-found.

Case 2.10 — Categorize a tracked expense → participants

Target: same call site as Case 2.9 with actionName = CATEGORIZE

Precondition: a tracked expense in the Self DM and at least one workspace.

Steps:

  1. Open the Self DM → tracked expense → press Categorize it.
  2. Pick a workspace.
  3. Repeat step 1 and press the header back button instead.

Expected:

  • The URL gains /expense-participants?action=categorize&iouType=submit&… and the header reads Categorize.
  • Step 2 continues to the Category step (…/category?…) and then Confirmation, with no /not-found.
  • Step 3 returns to the Self DM chat.

Case 2.11 — Share with an accountant → participants (dynamic route stacked on a dynamic route)

Target: src/pages/iou/request/step/DynamicIOURequestStepAccountant.tsx navigateToNextStep

Precondition: the account is an admin of at least one workspace (otherwise the flow creates a draft workspace instead) and has a tracked expense.

Steps:

  1. Open the Self DM → tracked expense → press Share it with my accountant.
  2. Pick or type an accountant → Next.
  3. Press the header back button.

Expected:

  • Step 1 opens Who is your accountant? with /accountant?action=share&… appended.
  • Step 2 gives <…>/accountant/expense-participants?action=share&iouType=…&transactionID=…&reportID=… (two stacked suffixes) and the recipient picker opens — not /not-found.
  • Step 3 returns to the accountant page (/accountant still in the URL, expense-participants gone).

Case 2.12 — Back from Confirmation to participants (global create, participants not auto-assigned)

Target: src/pages/iou/request/step/IOURequestStepConfirmation.tsx navigateBack

Precondition: the expense was started from global create (transaction.isFromGlobalCreate === true), participants were not auto-assigned, and the receipt is not a test receipt.

Steps:

  1. Press the FAB → Create expense → Manual tab → enter an amount → Next.
  2. Pick a recipient to reach Confirmation.
  3. Press the header back button on Confirmation.
  4. Press back again.

Expected:

  • Step 3 returns to the recipient picker at /create/<iouType>/start/<transactionID>/<reportID>/expense-participants?… — no blank screen, no /not-found.
  • Step 4 returns to the create page on the selected tab.

Case 2.13 — Legacy URL redirect (backward compatibility), pasted cold

Target: src/libs/Navigation/linkingConfig/OldRoutes.ts

Precondition: you know a live draft transactionID and reportID (copy them from the address bar in Case 2.1). Paste each URL into a new tab so it goes through getStateFromPath on a cold load.

Steps:

  1. Paste https://dev.new.expensify.com:8082/create/create/participants/<transactionID>/<reportID> and press Enter.
  2. Paste …/submit/submit/participants/<transactionID>/<reportID>?isWorkspacesOnly=true.
  3. Paste the already-migrated URL …/r/<reportID>/expense-participants?action=create&iouType=create&transactionID=…&reportID=….

Expected:

  • Step 1 redirects to /r/<reportID>/expense-participants?action=create&iouType=create&transactionID=<transactionID>&reportID=<reportID> and the recipient picker opens.
  • Step 2 redirects to /r/<reportID>/expense-participants?action=submit&iouType=submit&transactionID=…&reportID=…&isWorkspacesOnly=true and the list shows workspaces only (the query is preserved).
  • Step 3 is not redirected again — the URL stays as-is with no duplicated suffix.

Case 2.14 — Guard: the report participant routes are not swallowed by the new pattern

Target: the two identity entries in src/libs/Navigation/linkingConfig/OldRoutes.ts (/r/*/participants/participants-details/*, /e/*/participants/participants-details/*)

Precondition: a group chat or room with at least two members.

Steps:

  1. Open the group chat → header → Members → tap a member.
  2. Tap Role on that page.
  3. Refresh (F5) on both URLs.

Expected:

  • Step 1 keeps the URL at /r/<reportID>/participants/participants-details/<accountID> and opens the member details page — it is not rewritten to /r/…/expense-participants… and does not land on /not-found.
  • Step 2 gives /r/<reportID>/participants/participants-details/<accountID>/participants-role and opens the role page.
  • Step 3 restores both pages correctly with no wrong redirect.

The new /*/*/participants/*/* pattern has the same segment count as /r/<id>/participants/participants-details/<acc>. The matcher picks the longest pattern, so the two identity entries must win — this case guards against that regression. It is also covered by tests/navigation/getMatchingNewRouteTest.ts.


Case 2.15 — Refresh / deep link on the new URL (stack restore)

Target: getMatchingFullScreenRoute / getDynamicRouteAdaptedState

Precondition: the recipient picker is open from Case 2.6 (base = Confirmation) and from Case 2.11 (base = accountant, stacked suffix).

Steps:

  1. From Case 2.6, at <confirmation-url>/expense-participants?…, press F5, then press back.
  2. From Case 2.11, at <…>/accountant/expense-participants?…, press F5, then press back twice.
  3. Copy the URL from step 2 and paste it into a new tab (cold deep link).

Expected:

  • Step 1 reopens the recipient picker and back returns to the Confirmation page (the stack is restored, it does not jump to the Inbox).
  • Step 2 reopens the recipient picker; the first back goes to the accountant page and the second to the base report.
  • Step 3 behaves the same as step 2.

Case 2.16 — Invalid entry screen → /not-found

Target: entryScreens of DYNAMIC_ROUTES.MONEY_REQUEST_STEP_PARTICIPANTS in src/ROUTES.ts

Steps:

  1. Paste https://dev.new.expensify.com:8082/settings/profile/expense-participants?action=create&iouType=create&transactionID=1&reportID=2 and press Enter.

Expected: the Not found page, because Settings_Profile_Root is not in entryScreens. The console logs [getStateFromPath.ts][DynamicRoute] None of the … candidate(s) passed entryScreens validation.


Case 2.17 — Offline

Precondition: DevTools → Network → Offline.

Steps:

  1. Go offline.
  2. Repeat Case 2.1 (FAB → Create expense → Manual → amount → Next).
  3. Pick a recipient.

Expected: the recipient picker still opens with the correct suffix and back still works (navigation is client-side); picking a recipient continues to Confirmation with optimistic data and no crash.


  • Verify that no errors appear in the JS console

Offline tests

  • Same as tests — navigation refactor, offline behavior unchanged.

QA Steps

Test case 1: Change the recipient from the confirmation page

  1. Press + → Create expense → Manual tab, enter an amount and press Next.
  2. Pick a recipient so the confirmation page opens.
  3. Tap the To row.
  4. Verify the Choose recipient page opens and the address bar has expense-participants appended to the confirmation URL.
  5. Pick a different recipient.
  6. Verify you are returned to the confirmation page, the expense-participants part is gone from the address bar and the To row shows the recipient you just picked.

Test case 2: Submit a tracked expense to an employer with several workspaces

  1. Sign in with an account that belongs to at least two workspaces that accept submitted expenses.
  2. Open the chat with yourself and find an expense you tracked there.
  3. Press Submit it to my employer.
  4. Verify a picker opens that lists only workspaces — there is no Recents section and no individual people.
  5. Press the back arrow in the page header.
  6. Verify you are back in the chat with yourself.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
CleanShot.2026-08-20.at.11.35.38.1.mp4
CleanShot.2026-08-20.at.11.37.35.2.mp4
Case 2.1 — Global create (Manual tab) → participants → back 2 1-1-before-manual-amount-page 2 1-2-entry-participants-picker 2 1-3-after-back-manual-amount-restored
Case 2.2 — Global create (Scan tab) → participants 2 2-1-before-scan-upload-page 2 2-2-entry-participants-picker 2 2-3-after-back-scan-page-restored
Case 2.3 — Global create (Distance tab) → participants 2 3-1-before-distance-waypoints-page 2 3-2-entry-participants-picker 2 3-3-after-back-distance-page-restored
Case 2.4 — Drag & drop a receipt on the Inbox → participants 2 4-1-before-inbox-before-drop 2 4-2-entry-participants-picker
Case 2.5 — Drag & drop a receipt in Search → participants 2 5-1-before-search-results-before-drop 2 5-2-entry-participants-picker 2 5-3-after-back-search-page-restored
Case 2.6 — Confirmation → tap the To field → pick a recipient → back to Confirmation 2 6-1-before-confirmation-to-field 2 6-2-entry-participants-picker 2 6-3-after-back-confirmation-new-recipient
Case 2.7 — Incomplete split bill (Split details) → tap To 2 7-1-before-split-details-page 2 7-2-entry-participants-picker 2 7-3-after-back-split-details-restored
Case 2.8 — Submit a tracked expense with multiple workspaces → workspaces-only picker 2 8-1-before-selfdm-track-expense-cta 2 8-2-entry-workspaces-only-picker 2 8-3-after-back-selfdm-restored
Case 2.9 — Submit a tracked expense, SUBMIT action (not workspaces-only) 2 9-1-before-selfdm-track-expense 2 9-2-entry-participants-picker 2 9-3-after-submit-confirmation-reached
Case 2.10 — Categorize a tracked expense → participants 2 10-1-before-selfdm-categorize-gated 2 10-2-entry-category-page 2 10-3-after-back-report-restored
Case 2.11 — Share with an accountant → participants (dynamic route stacked on a dynamic route)

Skip since canUseTrackFlows is disabled

Case 2.12 — Back from Confirmation to participants (global create, participants not auto-assigned) 2 12-1-before-confirmation-page 2 12-2-entry-participants-restored 2 12-3-after-back-create-page-restored
Case 2.13 — Legacy URL redirect (backward compatibility), pasted cold 2 13-1-before-manual-page-oldurl 2 13-1-before-newurl-noredirect 2 13-2-entry-oldurl-redirected 2 13-2-entry-submit-workspaces-redirected
Case 2.14 — Guard: the report participant routes are not swallowed by the new pattern

Skip since canUseTrackFlows is disabled

Case 2.15 — Refresh / deep link on the new URL (stack restore) 2 15-1-before-participants-before-refresh 2 15-2-entry-accountant-nested-deeplink 2 15-2-entry-participants-restored-after-refresh 2 15-3-after-back-confirmation-restored-after-refresh
Case 2.16 — Invalid entry screen → /not-found 2 16-1-before-home-before-paste 2 16-2-entry-invalid-entry-notfound
Case 2.17 — Offline 2 17-1-before-offline-create-page 2 17-2-entry-offline-participants 2 17-3-after-back-offline-back-works

@suneox
suneox requested review from a team as code owners August 19, 2026 02:12
@melvin-bot
melvin-bot Bot requested review from garrettmknight and huult and removed request for a team and garrettmknight August 19, 2026 02:12
@melvin-bot

melvin-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown

@huult Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team August 19, 2026 02:12
@suneox
suneox marked this pull request as draft August 19, 2026 02:13

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5e55a3f4bd

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@codecov

codecov Bot commented Aug 19, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/ROUTES.ts 23.78% <100.00%> (ø)
src/SCREENS.ts 100.00% <ø> (ø)
src/components/MoneyRequestConfirmationList.tsx 94.24% <ø> (ø)
src/hooks/useParticipantSubmission.ts 0.00% <ø> (ø)
src/libs/Navigation/linkingConfig/OldRoutes.ts 100.00% <ø> (ø)
src/libs/Navigation/linkingConfig/config.ts 66.66% <ø> (ø)
src/libs/ReportUtils.ts 87.02% <100.00%> (-0.09%) ⬇️
...iou/request/step/withFullTransactionOrNotFound.tsx 96.29% <ø> (ø)
.../iou/request/step/withWritableReportOrNotFound.tsx 87.50% <ø> (ø)
...gation/AppNavigator/ModalStackNavigators/index.tsx 6.33% <0.00%> (ø)
... and 4 more
... and 3 files with indirect coverage changes

@suneox
suneox force-pushed the 83852-migrate-money-request-part-2-suneox branch from f0052a1 to 375c137 Compare August 20, 2026 04:10
@suneox
suneox marked this pull request as ready for review August 20, 2026 04:56

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f67ec7e8c5

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@huult

huult commented Aug 20, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-08-20.at.22.43.26.mov

@huult huult left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@melvin-bot
melvin-bot Bot requested a review from mjasikowski August 20, 2026 15:45
@mjasikowski
mjasikowski merged commit a1f2b3a into Expensify:main Aug 20, 2026
36 of 38 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 mjasikowski has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Aug 21, 2026
55 tasks done
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.4.58-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site changes required

I reviewed the changes in this PR and no updates to App/docs/articles are needed, so I did not create a draft PR.

Why: This is an internal navigation/routing refactor — it migrates the money request participants step from backTo/forwardTo to a dynamic URL suffix (expense-participants with query params). Every file changed is routing config, navigation code, components, or tests:

  • src/ROUTES.ts, src/SCREENS.ts, src/libs/Navigation/*, src/libs/IOUUtils.ts, src/libs/ReportUtils.ts
  • src/pages/iou/request/step/*, src/components/MoneyRequestConfirmationList.tsx, src/hooks/useParticipantSubmission.ts
  • tests/*

The user-facing behavior is unchanged: the Choose recipient picker, the confirmation flow, submit-to-employer, categorize, and share-with-accountant flows all work exactly as before — only the internal URL structure changed. Help articles document product features and workflows, not internal URL/route structures, so there is nothing to update.

I also searched App/docs/articles for related terms; the only "participants" matches are unrelated (task assignment, creating a chat, and a travel glossary) and don't reference this flow or its URLs.

@suneox, let me know if you believe a specific article should be updated and I'll take another look.


view run

@jponikarchuk

Copy link
Copy Markdown

Deploy Blocker #99145 was identified to be related to this PR.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Beamanator in version: 9.4.58-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants