Repository navigation
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
jmusial
left a comment
There was a problem hiding this comment.
Overall looks good, but I'd suggest a second look on the modal paddings to make sure they align with what was before
| const safeAreaStyle = useBottomSafeSafeAreaPaddingStyle({ | ||
| addBottomSafeAreaPadding: addBottomSafeAreaPadding && !isInLandscapeMode, | ||
| style: [shouldUseNarrowLayout && styles.pt2, !isInLandscapeMode && styles.pb5, safeAreaHorizontalPadding, contentStyle], | ||
| style: [shouldDockToBottom && styles.pt2, !isInLandscapeMode && styles.pb5, safeAreaHorizontalPadding, contentStyle], |
| function CenteredModalLayout({children, width, height, onBackdropPress, contentStyle, addBottomSafeAreaPadding = true}: CenteredModalLayoutProps) { | ||
| const styles = useThemeStyles(); | ||
| const {shouldUseNarrowLayout} = useResponsiveLayout(); | ||
| const {onboardingIsMediumOrLargerScreenWidth} = useResponsiveLayout(); |
There was a problem hiding this comment.
this flag is oboarding scoped, should we really use it in generic component?
There was a problem hiding this comment.
yeah I don't like it, but we could say the same thing about using it in FeatureTrainingModal/FeatureTrainingCarousel. Alternatively we could change shouldUseNarrowLayout to take into consideration screen size but it could require more changes/checking if other things would break, but in case of this flag I wouldn't like the fact that it would suggest that on native we do not use narrow layout on tablets, when we do. We could also add a new flag to useResponsiveLayout, but I'm not sure it's worth it, using onboardingIsMediumOrLargerScreenWidth looks like the safest option apart from adding a new flag IMO
Yeah, that seems way better to me. Though check the bottom padding there, seems like we have extra space at the bottom of that modal (maybe we don't need the SafeSpace buffer there anymore) |
|
@abzokhattab @mountiny One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@MelvinBot @codex review the PR and check for regressions, breaking changes or bugs |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Code Review — no regressions found ✅The change is safe and correctly scoped. Why it's equivalent where it should be: Verification detailsNo web regression. All six consumers of
Because Renamed style helpers are internal-only. Minor nit (non-blocking)Reusing the onboarding-scoped One thing to eyeball manuallyOn a phone in landscape, Note: I reviewed this statically. The fix targets native tablet layout, which can't be exercised on the web test platform, so I did not run a live test. Types weren't run in this environment, but the change is a param rename plus a hook property that already exists on the return type. |
Reviewer Checklist
Screenshots/VideosAndroid: mWeb Chrome |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.59-0 🚀
|
Help site review — no docs changes required ✅I reviewed the changes in this PR against the help site articles under Why: This PR is a layout-only fix. It only touches
Help site articles document features and how-to workflows, not internal modal positioning/layout, so there's nothing to update here. If you believe a specific article should be revised, point me at it and I'll take another look. |
|
@GCyganek could you provide the QA steps for Applause to execute? |
CenteredModalLayout on native wider screensCenteredModalLayout on native wider screens
|
@kavimuru I will check this off and @GCyganek @abzokhattab will check in staging. I am not sure how to easily get these modals |
|
Sorry I missed this, from what I tested AI promo modal usually appears after I create a new account, finish onboarding, sign out and log in again. I will check on staging as Vit requested |
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.4.59-5 🚀
Bundle Size Analysis (Sentry): |
















Explanation of Change
CenteredModalLayoutusedshouldUseNarrowLayout, which is alwaystrueon native, so the modal was always docked to the bottom full-width even on tablets. It now usesonboardingIsMediumOrLargerScreenWidth(via ashouldDockToBottomflag), so wide native screens get a centered modal.Fixed Issues
$ #98770
PROPOSAL: N/A
Tests
Verify these modals stay bottom docked on iOS/Android phones (native app) without changes
To trigger AI Feature Promo Modal:
isAIPromoModalDismissedandisEligibletofalseinuseAIFeaturesPromoModaland open theSpendscreenTo trigger Auto Submit/Track Training add this to
src/hooks/useOnboardingFlow.tsinside the useEffect:Offline tests
N/A — the change is layout-only and does not touch API calls, data fetching, or Onyx.
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-08-19.at.13.21.12.mov