Skip to content

Show the picker's own AM/PM marker on time rows - #99170

Merged
blimpich merged 3 commits into
Expensify:mainfrom
mukhrr:fix/per-diem-time-meridiem
Aug 27, 2026
Merged

blimpich merged 3 commits into
Expensify:mainfrom
mukhrr:fix/per-diem-time-meridiem

Conversation

@mukhrr

@mukhrr mukhrr commented Aug 21, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

A displayed time and the TimePicker that sets it took the AM/PM marker from two different sources. Renders used date-fns under the app language, the picker labels its buttons from common.am / common.pm. Only de (vorm. / nachm.) and el (π.μ. / μ.μ.) ever disagreed, every other locale already matches its keys.

Every render site now reads the same two keys, through DateUtils.getTimePeriodLabel and the two formatters built on it.

Bugs this closes

  • Per diem Zeit rows and Custom status Zeit showed vorm. / nachm. above a picker offering AM / PM
  • the Status page Nach Ablauf löschen row disagreed with the Clear after row it mirrors
  • the Bis … status label disagreed with both
  • the per diem confirmation Zeit row disagreed with the time step one screen earlier
  • chat timestamps (Gestern um 8:51 nachm.) disagreed with everything else
  • Greek dropped a dot on its PM marker, so the picker read μμ. where every other screen read μ.μ.
  • a time inside the local DST-skipped hour displayed an hour late, because the marker used to come from re-parsing a formatted string against today

Everywhere else the marker renders, swept in the same pass so the mismatch cannot come back on a screen nobody listed:

Surface Where
Recipient's local time above the composer ParticipantLocalTime
A member's local time on their profile AutoUpdateTime → ProfilePage
Chronos OOO event ranges ChronosOOOListActions
Travel update messages in chat formatTravelDate → getTravelUpdateMessage
Flight, train, car and hotel trip details getFormattedTransportDate / getFormattedTransportDateAndHour
Travel cancellation deadline getFormattedCancellationDate
Book-a-call time slots and confirmation ScheduleCallPage, ScheduleCallConfirmationPage
Next scheduled call in the header dropdown OnboardingHelpDropdownButton

extractTime12Hour is unchanged and is now picker-internal only. TimePicker still formats with it and parses the result back with get12HourTimeObjectFromDate under the same default locale, which is what #98110 relies on to save a German Per Diem. The other parse sites (combineDateAndTime, the chart's server As of formats) are untouched, so nothing that reads a string back changes.

The As of: label on chart cards is deliberately left alone. VictoryChartLabel is bundled into the standalone server/victory-chart-renderer binary against react-native stubs, and reaching the locale context from there pulls asyncOpenURL and its Linking import into a bundle that has no such export. That label's sentence is server-generated English anyway.

Timezone-aware surfaces take the marker from the hour in that timezone, not the reader's, so a call slot or a cancellation deadline cannot flip AM/PM across a timezone boundary.

CONST.DATE.LOCAL_TIME_FORMAT_WITHOUT_PERIOD and TIME_FORMAT_WITHOUT_PERIOD are added to MACHINE_DATE_CONSTANTS in require-locale-for-localized-date-format, since they carry no language-dependent token and the rule treats every other CONST.DATE format as localized by default.

Fixed Issues

$ #99345
PROPOSAL:

Tests

  1. Go to Settings > Preferences > Language and pick Deutsch
  2. Settings > Profile > Status > Nach Ablauf löschen > Benutzerdefiniert
  3. Verify the Zeit row reads hh:mm AM / hh:mm PM, not vorm. / nachm., and matches the picker it opens
  4. Set an afternoon time, save, then go back one screen to Status and verify Nach Ablauf löschen reads the same marker
  5. Set the status to Eine Woche with an emoji and save, then hover the emoji next to your name in a chat and verify the (Bis …) label reads AM / PM
  6. Verify chat message timestamps read Gestern um 8:51 PM, not 8:51 nachm.
  7. Start a Per Diem expense on a workspace with Per Diem enabled, set Startzeit and Endzeit, and verify the rows, the picker and the Zeit row on the confirmation screen all agree
  8. Switch to Ελληνικά and verify the picker's PM button reads μ.μ. (it previously read μμ.) and that times elsewhere read the same
  9. Switch to 日本語 and verify times still read 午前 / 午後
  10. Switch to English and verify nothing changed
  • Verify that no errors appear in the JS console

Offline tests

Same as tests. Every one of these renders from a local value with a static translation, so nothing changes offline.

QA Steps

Same as tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop

The row formatted the meridiem with date-fns' active locale while the picker labels it from common.am/common.pm, so German showed 12:00 vorm. above a picker offering AM/PM. Both now read the same translation key.
@mukhrr
mukhrr force-pushed the fix/per-diem-time-meridiem branch from 3d5836e to 799a157 Compare August 21, 2026 10:02
@codecov

codecov Bot commented Aug 21, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/CONST/index.ts 94.85% <ø> (ø)
src/components/LocaleContextProvider.tsx 85.71% <100.00%> (ø)
src/components/OnboardingHelpDropdownButton.tsx 95.65% <100.00%> (ø)
...ponents/ReportActionItem/ChronosOOOListActions.tsx 43.75% <ø> (ø)
src/pages/ScheduleCall/ScheduleCallPage.tsx 0.00% <ø> (ø)
src/pages/Travel/FlightTripDetails.tsx 100.00% <100.00%> (ø)
src/pages/Travel/HotelTripDetails.tsx 96.66% <100.00%> (ø)
...ages/ScheduleCall/ScheduleCallConfirmationPage.tsx 0.00% <0.00%> (ø)
src/pages/inbox/report/ParticipantLocalTime.tsx 92.00% <80.00%> (ø)
...ings/Profile/CustomStatus/StatusClearAfterPage.tsx 0.00% <0.00%> (ø)
... and 7 more
... and 4 files with indirect coverage changes

@mukhrr
mukhrr marked this pull request as ready for review August 21, 2026 10:07
@mukhrr
mukhrr requested review from a team as code owners August 21, 2026 10:07
@melvin-bot
melvin-bot Bot requested review from JmillsExpensify and chuckdries and removed request for a team August 21, 2026 10:07
@melvin-bot

melvin-bot Bot commented Aug 21, 2026

Copy link
Copy Markdown

@chuckdries Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team August 21, 2026 10:08
@mukhrr

mukhrr commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

well, created this PR per #98110 (comment). @blimpich can we have a dedicated issue for this?! thanks cc @aimane-chnaif

@aimane-chnaif

aimane-chnaif commented Aug 21, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
ios.mov
iOS: mWeb Safari
MacOS: Chrome / Safari
test1.mov
test2.mov

@aimane-chnaif aimane-chnaif left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found inconsistency issue in other places:

Clear After row no longer matches the Status page or the "Until…" label

Repro:

  1. Settings → Profil → Status → Nach Ablauf löschen → Benutzerdefiniert.
  2. Tap Zeit, set 02:30 PM, save.
    • Row under Zeit: 02:30 PM.
  3. Go back one screen to Status.
    • Nach Ablauf löschen row: 2026-08-24 02:30 nachm. — different marker for the same value.

In Greek this also surfaces the typo in el.ts:322 (pm: 'μμ.'), so the row reads μμ. where every other screen reads μ.μ..

Image The similar issue also happens on per-diem request confirmation page: Image

While these are existing inconsistencies in production, I think we can fix all of them in this PR.

Comment thread src/libs/DateUtils.ts
const {hour, minute, period} = get12HourTimeObjectFromDate(time12Hour);
return `${hour}:${minute} ${translate(period === CONST.TIME_PERIOD.AM ? 'common.am' : 'common.pm')}`;
}

@aimane-chnaif aimane-chnaif Aug 24, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also check this edge case:

DST spring-forward shifts the displayed time by an hour

getTime12HourWithTranslatedPeriod formats the time, then re-parses it via get12HourTimeObjectFromDate, which anchors the parse to today (DateUtils.ts:638).
On the local spring-forward day, a time inside the skipped hour normalizes forward.
Confirmed with the repo's date-fns:

TZ=America/New_York, ref = 2026-03-08
parse('02:30 AM','hh:mm a') -> Sun Mar 08 2026 03:30:00 GMT-0400

Repro step:

  1. Set the device date to March 7, 2026.
  2. Settings → Profile → Status → Clear after → select Custom.
  3. Tap Date → pick March 8, 2026. Tap Time → set 02:30 AM → Save.
  4. Set the device date to March 8, 2026, 00:30.
  5. Reopen Settings → Profile → Status → Clear after.
    • Expected (and main): Time row reads 02:30 AM.
    • With the PR: Time row reads 03:30 AM.

Production repro step:

Setup (do this on a day that is not the transition day):

  1. Set the device date to March 7, 2026.
  2. Settings → Profile → Status → Clear after → select Custom.
  3. Tap Date → pick March 8, 2026. Tap Time → enter 02:30, tap AM, tap Save.
  4. Back on Clear after, the Time row reads 02:30 AM. Tap Save.

Observe (on the transition day):

  1. Set the device date to March 8, 2026, 00:30 (before the 2 AM jump).
  2. Settings → Profile → Status → Clear after. The Time row still reads 02:30 AM — correct, this row is a plain format on production.
  3. Tap the Time row.
    • Bug: the picker opens pre-filled with 03:30 AM, not 02:30 AM.
  4. Tap Save without touching anything.
    • The stored value becomes 2026-03-08 03:30:00: the Time row now reads 03:30 AM, and the Status page summary reads 2026-03-08 03:30 AM.

The root cause exists in production and it's edge so we might not block on this?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's fix this here? cc @blimpich

@aimane-chnaif

Copy link
Copy Markdown
Contributor
Surface Production With PR
Clear After Zeit row 02:30 nachm. 02:30 PM
Status page Nach Ablauf löschen 02:30 nachm. 02:30 nachm.
Bis 02:30 … status label 02:30 nachm. 02:30 nachm.
Per-diem time rows 02:30 nachm. 02:30 PM
Per-diem confirmation Zeit row 02:30 nachm. 02:30 nachm.
TimePicker AM/PM buttons AM / PM AM / PM

@mukhrr

mukhrr commented Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

@aimane-chnaif more cases and fixed them. you can find them in PR OP

@mukhrr
mukhrr requested a review from aimane-chnaif August 25, 2026 03:44
A time was formatted with date-fns under the app language while the picker that sets it labels its buttons from common.am/common.pm, so German read vorm. in one place and AM in another. Every render site now reads the same keys. The format/parse pair the picker round-trips through is untouched, and the marker is no longer derived by re-parsing a formatted string, which shifted an hour on the local DST change. Greek was also missing a dot on its PM marker.
@mukhrr
mukhrr force-pushed the fix/per-diem-time-meridiem branch from b5bb08d to bd818c0 Compare August 25, 2026 03:50
@aimane-chnaif

Copy link
Copy Markdown
Contributor

I suspect German localization for am/pm is correct. I see on internet that Germans do not use "am" or "pm".
This is more like language problem, no need to block on this.

App/src/languages/de.ts

Lines 319 to 320 in 1d0d7de

am: 'AM',
pm: 'PM',

@mukhrr

mukhrr commented Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

I suspect German localization for am/pm is correct. I see on internet that Germans do not use "am" or "pm". This is more like language problem, no need to block on this.

App/src/languages/de.ts

Lines 319 to 320 in 1d0d7de

am: 'AM',
pm: 'PM',

yeah but we use am/pm in time picker. I think we need consistency: either am/pm or native vorm/nachm. I am curios what others think cc @blimpich @trjExpensify

image

Comment thread src/libs/DateUtils.ts
* returns {string} example: 11:10 PM
*/
function formatTimeWithPeriod(translate: LocalizedTranslate, date: Date, timeFormat: string = CONST.DATE.LOCAL_TIME_FORMAT_WITHOUT_PERIOD): string {
return `${format(date, timeFormat)} ${getTimePeriodLabel(translate, date.getHours())}`;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth noting:

locale formatLong.time format(d,'p') format(d,'h:mm a')
zh-hans zzzz a h:mm:ss 下午 2:30 2:30 下午
el h:mm:ss a zzzz 2:30 μ.μ. 2:30 μ.μ.
ja H時mm分ss秒 zzzz 14:30 2:30 午後
de / en / es / fr / it / nl / pl / pt-BR HH:mm:ss zzzz 14:30 2:30 PM

Chinese (zh-Hans) is marker-first — 下午 2:30. Japanese is interesting too: CLDR treats ja as 24-hour, so its localized time format has no meridiem at all.

Does date-fns support that already? Only through the localized-format tokens — p, pp, ppp, pppp (and P, Pp, PPpp), which read locale.formatLong.time and therefore honor both the ordering and the 12-vs-24-hour convention. The plain tokens are strictly positional: format(d, 'h:mm a') emits time-then-marker in every locale, because you wrote the pattern that way.

The app uses p nowhere — zero occurrences across src/. CONST.DATE.LOCAL_TIME_FORMAT has always been the hardcoded 'h:mm a', so main and this PR produce identical ordering. Not a regression.

So for zh-Hans the app shows 2:30 下午 where native convention is 下午2:30 — a pre-existing i18n gap, unchanged by the PR, and now easier to fix in one place than it was before.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aimane-chnaif I think this is NAB? I am supposing not to touch formats further. what do you think?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup I didn't say this is blocker but just worth noting.

@aimane-chnaif

Copy link
Copy Markdown
Contributor

Just awaiting product feedback on #99170 (comment)

@blimpich

Copy link
Copy Markdown
Contributor

Just awaiting product feedback on (earlier comment)

@JmillsExpensify as the product person on this PR, do you have a take?

Copy link
Copy Markdown
Contributor

Sorry for the delay! I think we just go with the straight literal translation: orm/nachm. This is more of a localization consideration that isn't supported and we don't need to block on it. A lot of Europe uses 24 time, and we can consider adding that separately.

@JmillsExpensify JmillsExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blimpich
blimpich merged commit 8036bc3 into Expensify:main Aug 27, 2026
41 of 46 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 blimpich has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Aug 27, 2026
65 tasks done
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/blimpich in version: 9.4.63-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

Help site review — no changes required

I reviewed the changes in this PR and no help site updates are needed under docs/articles.

Why: This is an internal localization/formatting bug fix. It makes the AM/PM (meridiem) marker shown on time rows read from the same translation keys as the TimePicker itself, so displayed times and the picker agree in every locale (fixing de vorm./nachm. and el μμ. mismatches, plus a DST-skipped-hour edge case). All 20 touched files are code, formatting utilities, an eslint rule, and unit tests.

The help articles that mention the affected surfaces (Per Diem, Custom Status, Travel, Scheduled Calls) document how to use those features — none of them document how the AM/PM marker is rendered per locale, which is the only thing this PR changes. There is no user-facing workflow, feature name, button, or setting change to reflect. Since the fix simply brings mismatched locales into line with the behavior the rest of the app already had, there's nothing to add or correct.

No draft PR was created since no documentation changes are warranted. @mukhrr, if you believe a specific article should still be updated, let me know which surface and I'll draft it.


view run

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.4.63-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants