Repository navigation
[No QA] Reseed personal details after Onyx.clear in OptionsListUtils tests - #99241
Merged
Merged
Conversation
Onyx.clear() models sign-out. Report-holder names resolve from the live allPersonalDetails connect, so restore PERSONAL_DETAILS_LIST.
MonilBhavsar
approved these changes
Aug 22, 2026
77 tasks done
Contributor
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.4.60-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.4.60-2 🚀
Bundle Size Analysis (Sentry): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
OptionsListUtilsreport-holder option text is supposed to resolve fromReportUtils.allPersonalDetails(the liveOnyx.connect(PERSONAL_DETAILS_LIST)), not from the snapshot passed intocreateFilteredOptionList. That asymmetry is intentional (#97087).The suite hoisted
Onyx.clear()into the top-levelbeforeEachind7136c90687af("fix test") for isolation.Onyx.clear()models sign-out and emptiesPERSONAL_DETAILS_LIST, so latergetValidOptions()/ hydrate calls fall back to emails (tchalla@expensify.cominstead ofBlack Panther).This PR restores
PERSONAL_DETAILS_LISTafter clear, the same way a signed-in session would after login.Fixed Issues
$ n/a - This test is passing on main, but is failing on any PR in which I try to upgrade Onyx. Aome PR already merged in Onyx but not yet upgraded in the E/App Onyx bump queue breaks it.
Tests
Automated test only.
Offline tests
n/a
QA Steps
None.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop