Skip to content

Show generated thread title - #99317

Merged
puneetlath merged 39 commits into
Expensify:mainfrom
rushatgabhane:concierge-thread-title
Sep 14, 2026
Merged

puneetlath merged 39 commits into
Expensify:mainfrom
rushatgabhane:concierge-thread-title

Conversation

@rushatgabhane

@rushatgabhane rushatgabhane commented Aug 24, 2026 •

Copy link
Copy Markdown
Member

Explanation of Change

Chat thread names are derived from the parent message, so a Concierge thread ignored the title the backend now sets. This prefers a real stored reportName when the thread's parent is the Concierge DM, compared against DEFAULT_REPORT_NAME since Auth persists the literal "Chat Report".

Also drops the optimistic reportName, which was HTML and would have rendered raw <strong> tags in the LHN.

Fixed Issues

$ #94503
PROPOSAL:

Tests

  1. Enable the conciergeRespondInThread beta and ask Concierge a multi-sentence question containing bold text or a link.
  2. Verify the thread shows your question with no raw HTML tags, then changes to a short title once the backend job runs.
  3. Verify the thread shows the Concierge avatar in the LHN rather than your own.
  4. Send Concierge a single attachment, once with a comment and once without, and verify each opens its own thread.
  5. Send two attachments at once and verify they stay in the DM without opening a thread.
  6. Open a thread in any non-Concierge chat and verify its name is still the parent message text.
  7. Ask Concierge from the home page and verify it opens a thread instead of the side panel.
  • Verify that no errors appear in the JS console

Offline tests

  1. Go offline and ask Concierge a question; verify the thread opens showing your question, with no raw HTML.
  2. Come back online and verify the title replaces it once the job runs.

QA Steps

Same as tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari image
Screen.Recording.2026-08-26.at.06.32.03.mov

@rushatgabhane
rushatgabhane requested review from a team as code owners August 24, 2026 09:21
@melvin-bot
melvin-bot Bot requested review from JmillsExpensify and justinpersaud and removed request for a team August 24, 2026 09:21
@melvin-bot

melvin-bot Bot commented Aug 24, 2026

Copy link
Copy Markdown

@justinpersaud Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@rushatgabhane
rushatgabhane marked this pull request as draft August 24, 2026 09:22

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 130ca3b257

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/libs/ReportNameUtils.ts Resolved
@codecov

codecov Bot commented Aug 26, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
...s/LHNOptionsList/OptionRowLHN/OptionRow/Avatar.tsx 73.80% <100.00%> (ø)
src/components/ReportActionAvatars/index.tsx 96.29% <100.00%> (ø)
...ents/ReportActionAvatars/useReportActionAvatars.ts 88.37% <100.00%> (+0.13%) ⬆️
src/components/ReportHeaderAvatars.tsx 93.54% <100.00%> (ø)
...components/Search/SearchRouter/useAskConcierge.tsx 96.77% <100.00%> (+1.12%) ⬆️
.../components/SidePanel/SidePanelContextProvider.tsx 88.00% <100.00%> (+0.24%) ⬆️
...rc/hooks/useOpenConciergeAnywhere/index.native.tsx 100.00% <100.00%> (ø)
src/libs/OptionsListUtils/index.ts 91.28% <ø> (ø)
src/libs/ReportNameUtils.ts 81.76% <100.00%> (+0.48%) ⬆️
src/libs/ReportUtils.ts 87.22% <100.00%> (-0.02%) ⬇️
... and 9 more
... and 12 files with indirect coverage changes

@rushatgabhane rushatgabhane changed the title Show thread title Show generated thread title Sep 8, 2026
@rushatgabhane

Copy link
Copy Markdown
Member Author

all fixed

@puneetlath

Copy link
Copy Markdown
Contributor

I notice that the thread header starts out as Concierge's avatar and then switches to the user's avatar. Is that a bug?

CleanShot 2026-09-14 at 10 41 56@2x CleanShot 2026-09-14 at 10 42 10@2x

Also, I would think that we open the thread in the right-hand pane when asking a question from the homepage, not that we would send the user to the Inbox.

@rushatgabhane

Copy link
Copy Markdown
Member Author

I notice that the thread header starts out as Concierge's avatar and then switches to the user's avatar. Is that a bug?

that bug has been fixed

@rushatgabhane

Copy link
Copy Markdown
Member Author

Also, I would think that we open the thread in the right-hand pane when asking a question from the homepage, not that we would send the user to the Inbox.

cool, let me update that

@rushatgabhane

rushatgabhane commented Sep 14, 2026 •

Copy link
Copy Markdown
Member Author

@puneetlath all done

Screen.Recording.2026-09-14.at.17.20.15.mov
image

puneetlath
puneetlath previously approved these changes Sep 14, 2026
@puneetlath
puneetlath merged commit f0f89a9 into Expensify:main Sep 14, 2026
35 of 36 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 puneetlath has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.4.78-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@kavimuru

Copy link
Copy Markdown

@rushatgabhane is applause.expensifail.com domain accounts are beta enabled?

@MelvinBot

MelvinBot commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

Yes — help site changes are required. Draft PR: #101139

What changed for members

This PR changes what a member sees when they ask Concierge a question, and two articles described the old behavior:

  • Asking from the Expensify Concierge chat now opens a separate chat thread per question instead of replying inline.
  • The thread is renamed to a short Concierge-generated summary once the backend job runs — previously a thread was always named after the parent message text (ReportNameUtils.ts:1064-1075).
  • The thread shows the Concierge avatar rather than the asker's (ReportUtils.ts:3862-3866).
  • A single attachment sent with a question opens its own thread; several attachments at once stay in the DM (useAskConcierge.tsx:78-79).

Articles updated

  • docs/articles/new-expensify/concierge-ai/What-Concierge-Can-Do.md — new ## How Concierge organizes each question into its own chat thread section, fixed the "What happens after you message Concierge" bullet that said Concierge "responds in the same chat", plus two FAQ entries.
  • docs/articles/new-expensify/concierge-ai/Concierge-Basics.md — short note and a cross-link to the new section.

One thing to confirm before merging

The behavior is gated behind the conciergeRespondInThread beta, and it is not live yet. I drove the current web build to check: selecting Ask Concierge from the search bar still posts into the single Expensify Concierge chat, and no separate thread row appears in the Inbox.

So the new section ends with "This is rolling out gradually, so you may still see Concierge reply directly in your Expensify Concierge chat" — accurate both before and after the beta ships. Please keep the docs PR in draft until the beta is enabled broadly.

UI verification and a separate docs bug I found

Labels used in the new copy, all verified against the live web build: the search option reads exactly Ask Concierge, the chat is named Expensify Concierge, and threads live under the Inbox tab. There is no navigation tab literally named "Ask Concierge" — that string only appears as a search-suggestion row and as Home composer placeholder text.

Authoring follows docs/HELP_AUTHORING_GUIDELINES.md (single # title, task-based ## headings, relative cross-links, no ###) and docs/HELPSITE_NAMING_CONVENTIONS.md (bolded, exact-case UI labels).

Out of scope for this PR, but worth a separate fix: Concierge-Basics.md and Support-Agent.md both tell members to click the Concierge icon in the top-right corner. That control's accessible label in the current build is Help. I left it alone since it is unrelated to this PR.


@MelvinBot, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review


view run · no recording available

@rushatgabhane

rushatgabhane commented Sep 15, 2026 •

Copy link
Copy Markdown
Member Author

applause.expensifail.com

i'm not sure. cc @puneetlath #99317 (comment)

@puneetlath

Copy link
Copy Markdown
Contributor

@kavimuru I believe it should be part of the default betas, which applause is added to. But if not, I see that applauseexpensifyteam@gmail.com is on the beta.

@lanitochka17

Copy link
Copy Markdown

Deploy Blocker #101244 was identified to be related to this PR.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/luacmartins in version: 9.4.78-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants