Repository navigation
Show generated thread title - #99317
Conversation
|
@justinpersaud Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 130ca3b257
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
# Conflicts: # src/libs/ReportNameUtils.ts # src/libs/SidebarUtils.ts
|
all fixed |
that bug has been fixed |
cool, let me update that |
|
@puneetlath all done Screen.Recording.2026-09-14.at.17.20.15.mov
|
|
🚧 puneetlath has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/puneetlath in version: 9.4.78-0 🚀
|
|
@rushatgabhane is applause.expensifail.com domain accounts are beta enabled? |
|
Yes — help site changes are required. Draft PR: #101139 What changed for membersThis PR changes what a member sees when they ask Concierge a question, and two articles described the old behavior:
Articles updated
One thing to confirm before mergingThe behavior is gated behind the So the new section ends with "This is rolling out gradually, so you may still see Concierge reply directly in your Expensify Concierge chat" — accurate both before and after the beta ships. Please keep the docs PR in draft until the beta is enabled broadly. UI verification and a separate docs bug I foundLabels used in the new copy, all verified against the live web build: the search option reads exactly Ask Concierge, the chat is named Expensify Concierge, and threads live under the Inbox tab. There is no navigation tab literally named "Ask Concierge" — that string only appears as a search-suggestion row and as Home composer placeholder text. Authoring follows Out of scope for this PR, but worth a separate fix: @MelvinBot, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR view run · no recording available |
i'm not sure. cc @puneetlath #99317 (comment) |
|
@kavimuru I believe it should be part of the default betas, which applause is added to. But if not, I see that applauseexpensifyteam@gmail.com is on the beta. |
|
Deploy Blocker #101244 was identified to be related to this PR. |
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.4.78-3 🚀
Bundle Size Analysis (Sentry): |



Explanation of Change
Chat thread names are derived from the parent message, so a Concierge thread ignored the title the backend now sets. This prefers a real stored
reportNamewhen the thread's parent is the Concierge DM, compared againstDEFAULT_REPORT_NAMEsince Auth persists the literal"Chat Report".Also drops the optimistic
reportName, which was HTML and would have rendered raw<strong>tags in the LHN.Fixed Issues
$ #94503
PROPOSAL:
Tests
conciergeRespondInThreadbeta and ask Concierge a multi-sentence question containing bold text or a link.Offline tests
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-08-26.at.06.32.03.mov