Repository navigation
Fix Add field button cut off at bottom of workspace Reports page on Android - #99455
Conversation
…dd field button is not cut off Co-authored-by: Manan <mananjadhav@users.noreply.github.com>
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
🤖 Ran the PR's testing steps on Web (dev NewDot). Result: ✅ pass — after enabling Report fields on a workspace's Reports page and scrolling to the bottom of a list of 6 fields, the Add field button renders fully visible and not clipped. This confirms no regression on web from the native safe-area padding fix (web has no system nav bar).
Notes
Evidence (2)Workspace Reports page scrolled to bottom, Add field button fully visible with 6 report fields listed above it
Pixel-level crop of the very bottom edge of the viewport showing the Add field icon and text fully rendered, not clipped
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid-bottom-padding.movMacOS: Chrome / Safariweb-report-field-padding.mov |
|
🚧 mjasikowski has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
I can't update the author checklist, hence I've completed the reviewer checklist here. @mjasikowski Can you mark it ready for review and merge? |
|
@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@mananjadhav you'll need to approve this again after it's marked as ready to review |
|
🚧 mjasikowski has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.4.63-0 🚀
|
|
🤖 I reviewed the changes and no help site updates are required under This PR is a purely visual layout fix — it adds @mananjadhav, since no help site changes are required, there's no linked help site PR to review. If you disagree and think a specific article should be updated, let me know which one and I'll draft it. |
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.4.63-1 🚀
Bundle Size Analysis (Sentry): |







Explanation of Change
On the workspace Reports page, the Add field button was cut off / hidden behind the Android system navigation bar when scrolled to the bottom.
ScreenWrapperon this page usesenableEdgeToEdgeBottomSafeAreaPadding, which makes the wrapper stop applying its own bottom safe-area inset and delegate that to the scrollable content. But the page'sScrollViewwas rendered withoutaddBottomSafeAreaPadding, so nothing reserved the bottom inset — on Android (edge-to-edge draws content under the system nav bar) the last row was drawn behind the nav bar.This adds
addBottomSafeAreaPaddingto theScrollView, matching the pattern already used on other edge-to-edge workspace pages (e.g.WorkspacePerDiemSettingsPage). TheScrollViewnow reserves the bottom safe-area inset so the Add field button clears the system navigation bar. It also covers the offline-indicator inset, sinceaddOfflineIndicatorBottomSafeAreaPaddingdefaults on with it.Fixed Issues
$ #99335
PROPOSAL: #99335 (comment)
Tests
Offline tests
Same as tests.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.