Repository navigation
Fix: make company card CSV import help links reliably tappable on Android - #99783
Conversation
…roid Co-authored-by: Nyoman Jyotisa <nyomanjyotisa@users.noreply.github.com>
Co-authored-by: Nyoman Jyotisa <nyomanjyotisa@users.noreply.github.com>
Co-authored-by: Nyoman Jyotisa <nyomanjyotisa@users.noreply.github.com>
Co-authored-by: Nyoman Jyotisa <nyomanjyotisa@users.noreply.github.com>
Co-authored-by: Nyoman Jyotisa <nyomanjyotisa@users.noreply.github.com>
…ink coverage Co-authored-by: Nyoman Jyotisa <nyomanjyotisa@users.noreply.github.com>
Co-authored-by: Nyoman Jyotisa <nyomanjyotisa@users.noreply.github.com>
…oc header Co-authored-by: Nyoman Jyotisa <nyomanjyotisa@users.noreply.github.com>
Co-authored-by: Nyoman Jyotisa <nyomanjyotisa@users.noreply.github.com>
|
@nyomanjyotisa Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1f8e1e8c9b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…spaced locales Split spliced comment sentence. Hide per-word Text nodes from accessibility and expose one screen-reader-only node per run so TalkBack announces coherent prose instead of per-word nodes. Replace whitespace regex with Intl.Segmenter word segmentation so locales without spaces (ja, zh-hans) get real break points and wrap within the run.
|
Working on getting my android emulator running |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Hermes doesn't implement Intl.Segmenter, causing a render crash (undefined cannot be used as a constructor) on the company-card CSV import screen. Fall back to a whitespace split that preserves the same segment structure.
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
🚧 youssef-lr has triggered a test Expensify/App build. You can view the workflow run here. |
…GuideLinkTappable Fix: make company card CSV import help links reliably tappable on Android (cherry picked from commit b45b324) (cherry-picked to staging by AndrewGable)
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 9.4.63-1 🚀
|
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.4.63-1 🚀
Bundle Size Analysis (Sentry): |
|
No help site changes are required for this PR, so I did not create a docs PR. This PR only changes how the existing help text is rendered — it swaps the two inline The flow is already documented at Import Company Card Transactions From a Spreadsheet, and nothing in that article is invalidated by this change. Separate finding: three stale labels in that articleWhile verifying labels against the live UI, I found three capitalization/wording mismatches in the same article. These are pre-existing and unrelated to this PR — they were not introduced here, so I left them out rather than shipping them under a
"Import transactions from file" in step 5 is correct ( Reply with UI verification detailI drove the web app to confirm the labels rather than trusting the article. Result: partial — the first two labels and the More features toggle were confirmed, but the flow hit an account-validation magic-code gate on "Add cards", which needs email inbox access I don't have. The remaining two labels were confirmed from
|
|
🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 9.4.64-0 🚀
|
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.4.64-3 🚀
Bundle Size Analysis (Sentry): |




Explanation of Change
Fixes the deploy blocker where the inline "help guide" (and "Download our template") links on the company-card CSV import step were not tappable on Android at the minimum device font size.
The help text was rendered as a single
<Text>with two bare<TextLink>children nested inline. On Android, a link nested inside a<Text>becomes a nativeClickableSpanwhose touch area is limited to the glyph bounds, so it can become unreliable to tap (reproduced at the minimum device font size). This is the same rendering an<a>gets throughRenderHTMLfor non-comment links, so switching back toRenderHTMLwould not have fixed it — andRenderHTMLcan't invoke the client-side template download that #98058 requires.This change keeps both links inline (preserving the inline template link required by #98058) but renders each link as its own
PressableWithoutFeedback, which gives it a real native touch target. The surrounding copy is split into words inside aflexWraprow so the paragraph still flows and wraps naturally. This mirrors the existingTextLinkBlockapproach already used in the app for reliably tappable link text.Fixed Issues
$ #99719
PROPOSAL:
Tests
Offline tests
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Screen.Recording.2026-08-28.at.20.37.33.mov