Add EducationalTooltip for Unread Tab. by hungvu193 · Pull Request #99840 · Expensify/App

hungvu193 · 2026-08-30T08:22:55Z

Explanation of Change

As the PR title, in this PR we add the Educational Tooltip for Inbox Unread Tab, with the following requirements:

When someone views the Inbox and has at least one unread message older than 3 months, show the existing educational tooltip pointing at the Inbox tabs, promoting "Mark all as read".

Show it at most once every 7 days per account.
Dismissable and store the last-shown timestamp so the weekly cap survives reloads.

Fixed Issues

$ #99810
PROPOSAL: N/A

Tests

Same as QA steps

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Login with any account that has 3 month olds unread message.
Verify that the EducationalTooltip appears under the unread tab.
Verify that you can close it.
Reload the page after you close it.
Verify that it won't appear again.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2026-08-30.at.18.29.12.mov

Android: mWeb Chrome

Screen.Recording.2026-08-30.at.18.29.12.mov

iOS: Native

Screen.Recording.2026-08-30.at.18.27.09.mov

iOS: mWeb Safari

Screen.Recording.2026-08-30.at.18.23.04.mov

MacOS: Chrome / Safari

Screen.Recording.2026-08-30.at.16.24.06.mov

melvin-bot · 2026-08-30T08:22:59Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx bun ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx bun ./scripts/generateTranslations.ts --compare-ref main

codecov · 2026-08-30T08:26:03Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	`91.52% <ø> (ø)`
src/components/TabSelector/TabSelectorBase.tsx	`89.74% <ø> (ø)`
src/components/TabSelector/TabSelectorItem.tsx	`100.00% <ø> (ø)`
src/hooks/useSidebarOrderedReports.tsx	`87.27% <100.00%> (ø)`
src/libs/SidebarUtils.ts	`90.85% <100.00%> (+0.40%)`	⬆️
src/libs/TooltipUtils.ts	`100.00% <100.00%> (ø)`
src/pages/inbox/sidebar/InboxTabSelector.tsx	`81.35% <100.00%> (+2.11%)`	⬆️
src/types/onyx/DismissedProductTraining.ts	`0.00% <ø> (ø)`
src/components/ProductTrainingContext/index.tsx	`90.74% <75.00%> (-0.77%)`	⬇️
src/components/ProductTrainingContext/TOOLTIPS.ts	`31.57% <33.33%> (+0.32%)`	⬆️
... and 13 files with indirect coverage changes

melvin-bot · 2026-08-30T11:27:37Z

@truph01 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d60b966fdf

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

hungvu193 · 2026-08-30T11:33:05Z

@truph01 We need to wait for https://github.com/Expensify/Auth/pull/24116 to be deployed, but in the meantime, you can review the UI logic. The tricky part is the 3 month old check for unread message, you can comment it out:

- const {renderProductTrainingTooltip, shouldShowProductTrainingTooltip} = useProductTrainingContext(CONST.PRODUCT_TRAINING_TOOLTIP_NAMES.MARK_ALL_AS_READ, hasStaleUnreadReport);

+ const {renderProductTrainingTooltip, shouldShowProductTrainingTooltip} = useProductTrainingContext(CONST.PRODUCT_TRAINING_TOOLTIP_NAMES.MARK_ALL_AS_READ);

truph01 · 2026-09-03T11:45:44Z

@codex review

chatgpt-codex-connector · 2026-09-03T11:51:05Z

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: d8973daf34

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

hungvu193 · 2026-09-04T07:36:06Z

@truph01 this is ready for your another review 🙇

truph01 · 2026-09-07T07:22:48Z

Bug: The tooltip is still shown when opening other screens:

Screen.Recording.2026-09-07.at.14.22.11.mov

hungvu193 · 2026-09-07T08:32:21Z

Bug: The tooltip is still shown when opening other screens:

Screen.Recording.2026-09-07.at.14.22.11.mov

Fixed in f3d788f

truph01 · 2026-09-14T03:29:50Z

@hungvu193 With the new fix, the tooltip only appears in small device, but the desktop device.

melvin-bot · 2026-09-14T05:06:59Z

I could not review this diff, so I did not approve the workflow runs. An Expensify employee will review it and approve them manually.

hungvu193 · 2026-09-14T05:08:05Z

@truph01 Fixed. Can you verify again 😅 ?

Screen.Recording.2026-09-14.at.12.07.24.mov

truph01 · 2026-09-14T07:31:15Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained """"why"""" the code was doing something instead of only explaining """"what"""" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-09-14.at.14.17.57.mov

Android: mWeb Chrome

Screen.Recording.2026-09-14.at.14.30.52.mov

iOS: HybridApp

Screen.Recording.2026-09-14.at.14.18.32.mov

iOS: mWeb Safari

Screen.Recording.2026-09-14.at.14.20.50.mov

MacOS: Chrome / Safari

Screen.Recording.2026-09-14.at.14.10.47.mov

truph01 · 2026-09-14T07:47:41Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 561f93c037

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

melvin-bot · 2026-09-14T09:59:55Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #99810 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

JS00001

@hungvu193 was this NVP name added to the BE?

hungvu193 · 2026-09-14T14:52:52Z

@hungvu193 was this NVP name added to the BE?

Yes. It was added here (https://github.com/Expensify/Auth/pull/24116 was deployed to prod).

JS00001 · 2026-09-14T15:03:43Z

Nice, ty!

github-actions · 2026-09-14T15:04:26Z

🚧 JS00001 has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-09-14T15:08:09Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-09-14T15:08:13Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #99840.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-89355ab-e0b1529-ae56cb37e3309e3a5e47bf53e83cb5d9431aaac4/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-89355ab-e0b1529-4c45303ba217a36f98498b556b7041be04747c69/index.html

Web 🕸️
https://99840.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-09-15T01:27:34Z

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.4.78-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-09-15T01:41:56Z

Yes — a help site update is required

Draft PR: #101143 — Docs updates for E/A#99840 Document Mark all as read on Inbox tabs (labelled HelpDot, assigned to MelvinBot).

Why: this PR adds a tooltip on the Unread tab promoting Mark all as read, but the help site never documented that action. docs/articles/new-expensify/getting-started/Navigating-New-Expensify.md:69-85 describes the All, Unread, and To-dos tabs and their count badges, and stops there. A member who sees the tooltip — or dismisses it — has nothing to look up.

What changed (one file, docs-only):

New ## How to mark all chats as read from the Inbox tabs section, with separate web (right-click) and mobile (long-press) steps.
Documents the tab-dependent scope: All and Unread mark every unread chat as read, To-dos marks only the chats listed in To-dos (InboxTabSelector.tsx:97-99).
Notes the tooltip: shows when unread messages are older than three months, dismissable, reappears at most once a week.
Three new FAQ entries, plus expanded keywords and internalScope.

UI verification

Verified live on dev NewDot web: the three tab labels read exactly All, Unread, To-dos (confirmed in the accessibility tree).

The menu item, modal title, prompts, and buttons could not be confirmed live — the web automation harness rejects both click --button secondary and longpress with UNSUPPORTED_OPERATION, so the popover never opens. Those strings came from source instead:

Menu item / modal title / confirm button: Mark all as read (en.ts:3299)
Prompt from All / Unread: Are you sure you want to mark all chats as read? (en.ts:3300)
Prompt from To-dos: Are you sure you want to mark all to-do chats as read? (en.ts:3301)
Cancel button: Cancel (common.cancel)

Please spot-check those four strings by hand during review.

Three-month threshold: CONST/index.ts INBOX_TAB_STALE_UNREAD_MONTHS: 3. Seven-day reappear window: TOOLTIPS.ts.

What I deliberately did not document

The tooltip copy itself (Right-click to mark all as read. / Long-press to mark all as read.) and its per-account dismissal storage are in-product mechanics, not member workflows, so they don't belong in an article. The behavior the tooltip points at is what I documented.

The ten non-English language files in this PR are translations of that same tooltip string — the help site has no localized equivalent of this article, so no action there.

@MelvinBot, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

jponikarchuk · 2026-09-15T06:20:39Z

Deploy Blocker #101159 was identified to be related to this PR.

jponikarchuk · 2026-09-15T13:54:50Z

Deploy Blocker #101214 was identified to be related to this PR.

OSBotify · 2026-09-15T23:44:00Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.4.78-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

Init educationaltooltip for inbox unread

c1f7542

melvin-bot Bot assigned hungvu193 Aug 30, 2026

hungvu193 added 2 commits August 30, 2026 16:24

Wrap Educationaltooltip for Badge instead

b7045ef

Add platform check for text

f830471

hungvu193 mentioned this pull request Aug 30, 2026

[Due for payment 2026-09-22] Promote "Mark all as read" once a week when unreads are older than 3 months #99810

Closed

Only displays tooltip if we have 3 months old unread messages

d60b966

hungvu193 marked this pull request as ready for review August 30, 2026 11:27

hungvu193 requested review from a team as code owners August 30, 2026 11:27

melvin-bot Bot requested review from heyjennahay and truph01 and removed request for a team August 30, 2026 11:27

chatgpt-codex-connector Bot reviewed Aug 30, 2026

View reviewed changes

Comment thread src/pages/inbox/sidebar/InboxTabSelector.tsx Resolved

Comment thread src/selectors/Report.ts Resolved

Comment thread src/components/ProductTrainingContext/TOOLTIPS.ts Resolved

reuse useSidebarOrderedReports

d8973da

truph01 reviewed Sep 3, 2026

View reviewed changes

Comment thread src/hooks/useSidebarOrderedReports.tsx Resolved

Comment thread src/pages/inbox/sidebar/InboxTabSelector.tsx Resolved

Comment thread src/hooks/useSidebarOrderedReports.tsx Resolved

hungvu193 added 2 commits September 4, 2026 14:19

Merge remote-tracking branch 'origin' into feat-99810

a1de0e2

reuse getInboxTabCounts

6a1d644

hungvu193 requested a review from truph01 September 4, 2026 07:45

hungvu193 commented Sep 7, 2026

View reviewed changes

Comment thread src/pages/inbox/sidebar/InboxTabSelector.tsx Resolved

Update src/pages/inbox/sidebar/InboxTabSelector.tsx

f3d788f

hungvu193 added 2 commits September 14, 2026 11:44

Merge remote-tracking branch 'origin' into feat-99810

7edad7a

fix issue on wide screen

561f93c

chatgpt-codex-connector Bot reviewed Sep 14, 2026

View reviewed changes

Comment thread src/hooks/useSidebarOrderedReports.tsx Resolved

truph01 approved these changes Sep 14, 2026

View reviewed changes

melvin-bot Bot requested a review from JS00001 September 14, 2026 10:00

JS00001 approved these changes Sep 14, 2026

View reviewed changes

JS00001 merged commit 89355ab into Expensify:main Sep 14, 2026
38 of 42 checks passed

OSBotify mentioned this pull request Sep 15, 2026

Deploy Checklist: New Expensify 2026-09-15 #101132

Closed

62 tasks done

MelvinBot mentioned this pull request Sep 15, 2026

[No QA] Docs updates for E/A#99840 Document Mark all as read on Inbox tabs #101143

Closed

40 tasks

MelvinBot mentioned this pull request Sep 15, 2026

[Due for payment 2026-10-01] Android & iOS - Copilot - Copilot tooltip is out of view #101151

Closed

2 of 7 tasks

applause-bot Bot mentioned this pull request Sep 15, 2026

[Due for payment 2026-09-22] Tooltip on Unread tab has darker background with less rounded borders compared to other #101159

Closed

4 of 7 tasks

MelvinBot mentioned this pull request Sep 15, 2026

[Payment due @nkdengineer] [No QA] Remove duplicate shouldUseNarrowLayout declaration in InboxTabSelector #101195

Merged

41 of 43 tasks

applause-bot Bot mentioned this pull request Sep 15, 2026

[Due for payment 2026-09-30] Android & iOS - Inbox - Unread tab tooltip is out of view when device font size is maximum #101214

Closed

1 of 7 tasks

melvin-bot Bot mentioned this pull request Nov 4, 2026

[Due for payment 2026-11-20] Unread tooltip incorrectly treats partial reports and missing message dates as stale chats #106016

Open

Conversation

hungvu193 commented Aug 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Aug 30, 2026

Uh oh!

codecov Bot commented Aug 30, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Aug 30, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hungvu193 commented Aug 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

truph01 commented Sep 3, 2026

Uh oh!

chatgpt-codex-connector Bot commented Sep 3, 2026

Uh oh!

hungvu193 commented Sep 4, 2026

Uh oh!

truph01 commented Sep 7, 2026

Uh oh!

Uh oh!

hungvu193 commented Sep 7, 2026

Uh oh!

truph01 commented Sep 14, 2026

Uh oh!

melvin-bot Bot commented Sep 14, 2026

Uh oh!

hungvu193 commented Sep 14, 2026

Uh oh!

truph01 commented Sep 14, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

truph01 commented Sep 14, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

melvin-bot Bot commented Sep 14, 2026

Uh oh!

JS00001 left a comment

Choose a reason for hiding this comment

Uh oh!

hungvu193 commented Sep 14, 2026

Uh oh!

JS00001 commented Sep 14, 2026

Uh oh!

Uh oh!

github-actions Bot commented Sep 14, 2026

Uh oh!

OSBotify commented Sep 14, 2026

Uh oh!

github-actions Bot commented Sep 14, 2026

Uh oh!

OSBotify commented Sep 15, 2026

Uh oh!

MelvinBot commented Sep 15, 2026

Yes — a help site update is required

hungvu193 commented Aug 30, 2026 •

edited

Loading

codecov Bot commented Aug 30, 2026 •

edited by github-actions Bot

Loading

hungvu193 commented Aug 30, 2026 •

edited

Loading