Skip to content

Fix - Negative expenses appearing with positive amount in UnreportedExpenseListItem - #99913

Merged
madmax330 merged 1 commit into
Expensify:mainfrom
FitseTLT:fix-display-of-negative-expenses-in-existing-expenses-list
Sep 1, 2026
Merged

madmax330 merged 1 commit into
Expensify:mainfrom
FitseTLT:fix-display-of-negative-expenses-in-existing-expenses-list

Conversation

@FitseTLT

@FitseTLT FitseTLT commented Aug 31, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

TotalCell decides whether an amount may render as negative from effectiveReport/effectivePolicy, which fall back to transactionItem.report/transactionItem.policy. In the Add existing expense RHP, UnreportedExpenseListItem rendered TransactionItemRow without passing either, and the search-list transaction items carry no nested report or policy — so isFromExpenseReport evaluated false and getAmount returned Math.abs(...), showing a negative expense as positive.

This resolves the transaction's own report from Onyx and its policy via usePolicy, then passes both to TransactionItemRow. TotalCell now sees a real report/policy, isFromExpenseReport is correct, and the stored sign is preserved. Only this list item changes; every other TransactionItemRow caller already supplied these props.

Fixed Issues

$ #98627 (comment)
PROPOSAL: N/A

Tests

  1. Open a workspace chat and create a manual expense with a negative amount, leaving it draft.
  2. Go to the workspace chat and create a new empty report.
  3. Click Add expenses → Add existing expense.
  4. Verify the negative expense in the RHP list shows its amount as negative (e.g. -$5.00), not positive.
  • Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
2026-08-31.17-07-48.mp4
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
2026-08-31.17-26-05.mp4

@FitseTLT
FitseTLT requested review from a team as code owners August 31, 2026 14:30
@melvin-bot
melvin-bot Bot requested review from JmillsExpensify and youssef-lr and removed request for a team August 31, 2026 14:30
@melvin-bot

melvin-bot Bot commented Aug 31, 2026

Copy link
Copy Markdown

@youssef-lr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@FitseTLT

Copy link
Copy Markdown
Contributor Author

Created based on #98627 (comment) @madmax330 for 👀

@codecov

codecov Bot commented Aug 31, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/pages/UnreportedExpenseListItem.tsx 0.00% <0.00%> (ø)
... and 52 files with indirect coverage changes

@JmillsExpensify JmillsExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests make sense to me.

@FitseTLT

FitseTLT commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

bump @madmax330

@madmax330

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari

@madmax330
madmax330 merged commit 988de7c into Expensify:main Sep 1, 2026
37 of 40 checks passed
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

🚧 madmax330 has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

OSBotify commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

OSBotify commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/madmax330 in version: 9.4.66-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 No help site changes required.

This PR is a display-only bug fix — it passes report and policy into TransactionItemRow so TotalCell stops calling Math.abs() on a negative expense in the Add existing expense list. It adds no feature, changes no button or tab label, and alters no user workflow.

Why no docs update

The only article covering this flow is docs/articles/new-expensify/reports-and-expenses/Managing-Expenses-in-a-Report.md. Its "Add existing unreported expenses" steps describe how to open the list and pick expenses — they make no claim about how amounts are signed or formatted, so the corrected sign needs no documented change.

I also searched docs/articles for Add existing expense, unreported expense, and negative-amount wording. Nothing documents the previously incorrect behavior, so there is no stale text to fix.

Because no changes were needed, I did not create a draft help site PR, apply the HelpDot label, or assign one.

One unrelated observation, out of scope for this PR: the article says Click **More** > **Add expense** > **Add existing expense**, while your test steps say Add expenses → Add existing expense. I did not verify which matches the current UI. If the article's labels are stale, that's a separate docs fix worth filing.


view run

@OSBotify

OSBotify commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/madmax330 in version: 9.4.68-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 cancelled 🔪

@MelvinBot

MelvinBot commented Sep 2, 2026 •

Copy link
Copy Markdown
Contributor

No help site changes are required, so I did not create a docs PR.

This PR is a display-only bug fix. It passes the transaction's report and policy into TransactionItemRow so TotalCell renders a negative expense with its stored sign instead of Math.abs(...). See src/pages/UnreportedExpenseListItem.tsx:61-63.

Nothing user-facing changed in a way the help site documents:

  • No new or renamed feature, page, tab, setting, or button.
  • No change to the steps a user takes.
  • The help site never documented how amount signs render in this list, so there is no incorrect statement to correct.

The one article that covers this flow is already accurate. docs/articles/new-expensify/reports-and-expenses/Managing-Expenses-in-a-Report.md:32-37 documents More > Add expense > Add existing expense, then Add to report. I checked those labels against the live UI on web and they match exactly, including capitalization.

Live UI verification

On an empty workspace expense report, the Add expense dropdown contains Create expense, Track distance, and Add existing expense:

Add expense dropdown showing Add existing expense

The report header's More menu contains Add expense as a submenu with the same three options, which is the path the article documents:

Report More menu with Add expense submenu

Worth noting: Add expense also appears as a button directly on the empty report body, so the article's More path is correct but not the only route. That is pre-existing and unrelated to this PR, so I left it alone.

@FitseTLT, no help site PR was needed here. If you think a doc should call out how negative amounts display, reply and I'll draft one.


view run · no recording available

@OSBotify

OSBotify commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/francoisl in version: 9.4.68-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants