fix (batch 5): isNewManualExpenseFlowEnabled beta flag regressions by thelullabyy · Pull Request #99947 · Expensify/App

thelullabyy · 2026-08-31T18:32:07Z

Explanation of Change

Fixed Issues

$ #93854
$ #96565
$ #96568
$ #96562
PROPOSAL:

Tests

Verify that these bugs are not reproducible when new manual expense flow beta flag is enabled

#96568
#96565
#96562

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that these bugs are not reproducible when new manual expense flow beta flag is enabled

#96568
#96565
#96562

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-09-01.at.02.29.00.mov

Screen.Recording.2026-09-01.at.02.41.16.mov

Screen.Recording.2026-09-01.at.03.02.42.mov

…essions-from-93854-part-5

codecov · 2026-09-01T03:36:13Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/MoneyRequestConfirmationList.tsx	`94.24% <100.00%> (+0.04%)`	⬆️
...onfirmationList/hooks/useConfirmationValidation.ts	`89.61% <100.00%> (ø)`
...stConfirmationList/hooks/useFormErrorManagement.ts	`93.33% <100.00%> (+0.74%)`	⬆️
...eyRequestConfirmationList/sections/AmountField.tsx	`44.44% <100.00%> (ø)`
...oneyRequestConfirmationList/sections/DateField.tsx	`80.43% <100.00%> (+1.71%)`	⬆️
...ionListFooter/fieldGroups/ClassificationFields.tsx	`50.00% <ø> (ø)`
...onents/ParticipantPicker/BaseParticipantPicker.tsx	`95.23% <100.00%> (+90.23%)`	⬆️
src/libs/MoneyRequestUtils.ts	`98.71% <100.00%> (+0.06%)`	⬆️
...es/iou/request/step/IOURequestStepConfirmation.tsx	`74.93% <100.00%> (+0.85%)`	⬆️
... and 19 files with indirect coverage changes

melvin-bot · 2026-09-01T06:07:39Z

@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8b71811b7f

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

thelullabyy · 2026-09-01T06:42:20Z

This issue #96614 is not including in this fix yet, I'm still investigating the solution

ikevin127 · 2026-09-01T21:58:48Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

MacOS: Chrome / Safari

#96568 ✅

96568.mov

#96565 ⚠️ (regression)

96565.mov

#96562 ✅

96562.mov

ikevin127 · 2026-09-01T23:08:10Z

@thelullabyy Reviewer checklist completed ✅ 1/3 issues confirmed as fixed - ⚠️ 1 still regresses, see details here. Please tag me once you address all code comments and I'll do a second review, thank you 🙌

…essions-from-93854-part-5

thelullabyy · 2026-09-04T18:23:24Z

I fixed the regression and all other comments. @ikevin127 Back to you again

Screen.Recording.2026-09-05.at.02.22.31.mov

ikevin127 · 2026-09-04T23:38:03Z

+function createMockScreenNavigation(): MockScreenNavigation {
+    const focusListeners: Array<() => void> = [];
+
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion -- test-only navigation stub. The single assertion lives here so no render site needs one.


🟢 The one type assertion in the PR. createMockScreenNavigation.ts uses as unknown as ConfirmationScreenNavigation with an eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion and a written justification.

Worth a conscious sign-off given the no-casting guidance, but I would keep it: it is test-only, contained to one line in one helper, and it replaces roughly twenty @ts-expect-error directives spread across two files.

The alternative is strictly worse.

cc @blimpich for a take - given our effort with the seatbelt series

ikevin127

🟢 LGTM - The last regression was fixed and comments were addressed

puneetlath · 2026-09-08T13:53:11Z

NAB, but for the future can you (or can you teach your AI) to make the comments a little more succinct.

github-actions · 2026-09-08T13:53:57Z

🚧 puneetlath has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-09-08T13:56:04Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-09-08T13:57:54Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #99947.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-c9a7c38-57708e6-643d787afdc2871d0cfaacd0c73046d9d4958977/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-c9a7c38-57708e6-16f3443b5b61285c18896830bbcc910962acecec/index.html

Web 🕸️
https://99947.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-09-08T19:22:46Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.4.74-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-09-08T19:26:33Z

🤖 No help site changes are required for this PR. No draft docs PR was created.

Why: Every change here is internal bug-fix logic behind the isNewManualExpenseFlowEnabled beta flag. None of it adds, renames, removes, or reorders anything the help site documents.

Linked issue	What the PR fixes	Documented on the help site?
#96568	"This field is required" no longer strands after editing another field — the clear effect now reuses the same predicates validation raises the error from	No. Inline form validation errors aren't documented.
#96565	Duplicate "Invalid amount" errors on Split — footer error suppression is now re-checked against the debounced value	No. Same — error copy isn't in `docs/articles`.
#96562	Returning from the referral page reopens the contact list instead of Create expense — new `onCloseForReferralNavigation` callback plus a refocus listener	No. The referral round trip isn't documented.

Verification details

Docs checked

docs/articles/new-expensify/reports-and-expenses/Create-an-Expense.md — the canonical article for the flows this PR touches (SmartScan, manual cash, distance, time, split). Its step lists cover only the happy path: amount and currency → Next → recipient → coding → Create expense. This PR changes none of those steps, labels, or their order.
Distance-Expenses.md, Track-Expenses.md, Per-Diem-Expenses.md — the other surfaces the shared MoneyRequestConfirmationList renders. No validation or error-state content in any of them.

Searches run across all of docs/articles for field is required, invalid amount, referral, and refer a friend. The only hits are unrelated: Sage Intacct and NetSuite export-error articles about integration-side required fields, and partner referral links in the Expensify Card perks articles.

Scope note: 11 of the 16 changed files are tests or test utilities. The 5 source files are MoneyRequestConfirmationList.tsx, two of its hooks (useConfirmationValidation, useFormErrorManagement), two of its field sections (AmountField, DateField), plus MoneyRequestUtils.ts (two new shared predicates, isConfirmationAmountMissing and isConfirmationDateMissing), ParticipantPicker (one new optional callback prop), and IOURequestStepConfirmation.tsx. No new user-facing copy, no new setting, no new menu item.

About the parent feature: the beta this batch stabilizes — #93854, showing Merchant, Date, and Amount fields in the Scan flow — will need help site updates once it ships to everyone, because Create-an-Expense.md still describes the pre-beta manual flow ("Enter the amount and currency, then click Next"). That's a separate docs task to run when the flag goes GA, not something to write now against a beta-gated flow. Documenting it today would describe behavior most users don't have.

@thelullabyy, I found no help site changes to make, so there's no linked docs PR to review. Please confirm you agree with that assessment. If you'd rather document the new manual expense flow now (ahead of the beta going GA), reply with @MelvinBot and I'll draft that PR against Create-an-Expense.md.

view run · view recording

OSBotify · 2026-09-09T20:14:29Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.4.74-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

thelullabyy added 3 commits August 19, 2026 13:44

Merge branch 'main' of https://github.com/Expensify/App

77d7b6c

Merge branch 'main' of https://github.com/Expensify/App into fix/regr…

60646d9

…essions-from-93854-part-5

fix: 96568

5f022cc

melvin-bot Bot assigned thelullabyy Aug 31, 2026

thelullabyy added 2 commits September 1, 2026 02:43

fix: 96565

6747a20

fix: 96562

0093a1b

thelullabyy mentioned this pull request Aug 31, 2026

[Due for payment 2026-11-09] Create expense - Keyboard navigation is broken when user add a currency #96614

Closed

1 of 7 tasks

thelullabyy added 2 commits September 1, 2026 11:30

fix: test

304cec7

Merge branch 'main' of https://github.com/Expensify/App into fix/regr…

8b71811

…essions-from-93854-part-5

thelullabyy marked this pull request as ready for review September 1, 2026 06:07

thelullabyy requested review from a team as code owners September 1, 2026 06:07

melvin-bot Bot requested review from JmillsExpensify and ikevin127 and removed request for a team September 1, 2026 06:07

github-actions Bot reviewed Sep 1, 2026

View reviewed changes

Comment thread src/components/MoneyRequestConfirmationList/hooks/useFormErrorManagement.ts Resolved

chatgpt-codex-connector Bot reviewed Sep 1, 2026

View reviewed changes

Comment thread src/components/MoneyRequestConfirmationList/hooks/useFormErrorManagement.ts Resolved