Repository navigation
Protect merged object prototypes - #973
Merged
Merged
Conversation
Skip __proto__ keys so assignments cannot replace the result prototype.
melvin-bot
Bot
requested review from
blimpich
and removed request for
a team
November 11, 2026 17:54
blimpich
approved these changes
Nov 11, 2026
Contributor
21 of 38 tasks
41 of 43 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore unsafe keys when merging objects to preserve the result's prototype.
Fixed Issues
For https://github.com/Expensify/Expensify/issues/702578
Tests
npm test -- --runInBand __tests__/fastMergeTest.jsand confirm all 10 tests pass.npm run typecheck, ESLint and Prettier on the changed files and confirm they pass.QA
- Tim's A.I. Agent 🤖